Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Vu Looks good, Ack Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 22 september 2016 09:17 > To: Lennart Lund ; mahesh.va...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Vu, This patch looks optimal . ACK , not tested -AVM On 9/22/2016 12:47 PM, Vu Minh Nguyen wrote: > osaf/services/saf/logsv/lgs/lgs_amf.cc| 29 --- > osaf/services/saf/logsv/lgs/lgs_config.cc | 10 ++--- > osaf/services/saf/logsv/lgs/lgs_evt.cc| 27 --

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Thanks Mahesh, and Lennart. I just send V3 patch. Please have a look. Thanks. Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Thursday, September 22, 2016 11:34 AM > To: Vu Minh Nguyen ; > lennart.l...@ericsson.com

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Vu, Still we can convert this below logic to a function which is use in multiple places like log_stream_get_next_by_id() === /* Check existing streams */ uint32_t count = 0, stream_id = 0, max = 0; uint32_t num = get_number_of_streams(); max =

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Lennart, Thanks for your comments. Yesterday, I sent out the V2 patch as attached. Can you have a look to see it could cover your comments #1 and #3? I will handle your comment #2 before pushing the code. Regards, Vu > -Original Message- > From: Lennart Lund

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Vu I have a few comments. There are no comments inline. 1) In several places the following (or almost the same)code can be found: uint32_t count = 0, stream_id = 0; uint32_t num = get_number_of_streams(); stream = log_stream_get_by_id(stream_id); while (count < num) { if (stream

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

I will send the V2 patch soon. Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Wednesday, September 21, 2016 4:13 PM > To: Vu Minh Nguyen ; > lennart.l...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net >

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi VU, Try**to have function **log_stream_get_next_by_id(). -AVM On 9/21/2016 2:35 PM, Vu Minh Nguyen wrote: > Hi Mahesh, > > I do think about it but not yet found out the better way. > I can use the macro for this, somethings like > GET { > .. > } NEXT; > > but it will violate the coding

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Mahesh, I do think about it but not yet found out the better way. I can use the macro for this, somethings like GET { .. } NEXT; but it will violate the coding rule - avoid using the macro. I would appreciate if you have any proposal for this. Thanks. Regards, Vu > -Original

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Vu, You used this similar code logic number of time in multiple file in log service code is it possibly to optimize this logic in single function , to make maintainability of code , so that any bug fix will not trigger multiple places code changes