Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

2016-10-12 Thread A V Mahesh
Ok, ACK. -AVM On 10/12/2016 12:27 PM, Vu Minh Nguyen wrote: > Hi Mahesh, > > In README file, there is a note on this. Refer to "Note on memory handling > for writting log record" > > And caller here means the one that call the function `log_stream_write_h`, > not log client. > > Regards, Vu >

Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

2016-10-12 Thread Vu Minh Nguyen
Hi Mahesh, In README file, there is a note on this. Refer to "Note on memory handling for writting log record" And caller here means the one that call the function `log_stream_write_h`, not log client. Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com]

Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

2016-10-12 Thread A V Mahesh
Hi Vu, `Return (-1) to inform that it is caller's responsibility to free the allocated mem` is this existing practices for application ? or new , if new do we need to document it . -AVM On 10/12/2016 10:14 AM, A V Mahesh wrote: > ACK > > -AVM > > > On 9/13/2016 4:19 PM, Vu Minh Nguyen wrote:

Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

2016-10-11 Thread A V Mahesh
ACK -AVM On 9/13/2016 4:19 PM, Vu Minh Nguyen wrote: > osaf/services/saf/logsv/lgs/lgs_filehdl.cc | 16 +++- > osaf/services/saf/logsv/lgs/lgs_stream.cc | 6 ++ > 2 files changed, 17 insertions(+), 5 deletions(-) > > > logsv did pass the WRITE request to file handle

Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

2016-10-11 Thread Vu Minh Nguyen
Yes. That wrong review request is for #1986. It was pushed. Quoting Lennart Lund : > Ack > > Note: There seems to be another review request tagged with the same > ticket number? > > Thanks > Lennart > >> -Original Message- >> From: Vu Minh Nguyen

Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

2016-10-11 Thread Lennart Lund
Ack Note: There seems to be another review request tagged with the same ticket number? Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 13 september 2016 12:50 > To: Lennart Lund ;