[tickets] [opensaf:tickets] #680 AMF: Coverity issues in amfd/amfnd
- **status**: unassigned -- review --- ** [tickets:#680] AMF: Coverity issues in amfd/amfnd** **Status:** review **Milestone:** future **Created:** Thu Dec 19, 2013 11:08 AM UTC by Gary Lee **Last Updated:** Thu Dec 19, 2013 11:08 AM UTC **Owner:** Gary Lee Coverity detected a number of issues in amfd/amfnd. Some of these issues will be addressed in this ticket. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- ___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #807 AMF returns TRYAGAIN for saAmfRegister
Below is the description for returning BAD_OPERATION by saAmfComponentRegister() and it doesn't match with the ticket use case: SA_AIS_ERR_BAD_OPERATION: The proxy component which is identified by the name referred to by proxyCompName and which is registering a proxied component has not been assigned the proxy CSI with the active HA state through which the proxied component being registered is supposed to be proxied. The most suitable return is SA_AIS_ERR_TRY_AGAIN, which is being return. --- ** [tickets:#807] AMF returns TRYAGAIN for saAmfRegister** **Status:** accepted **Milestone:** future **Created:** Thu Mar 06, 2014 03:52 PM UTC by Hans Feldt **Last Updated:** Thu Mar 27, 2014 11:00 AM UTC **Owner:** Nagendra Kumar Use case: node lock followed by node lock instantiation, During node lock a component causes an SUfailover followed by repair of the component which means instantiation. So we have a component in state INSTANTIATING when the SU terminate request comes. AMF then (silently) escalates this to execute cleanup of the already instantiating component and changes its state to TERMINATING. Due to timing the cleanup script does not find any process to kill and returns 0. At the same time the instantiate script starts a process that calls saAmfRegister which returns TRYAGAIN because the component is in TERMINATING state. Suggestions: - AMF should probably return BAD-OPERATION in this case (is there any valid case where it should return TRYAGAIN?) - the reason for escalating to cleanup should be logged Finally, should AMF really start a second CLC CLI script while it knows one is already running? This implies that the cleanup script must be able to kill the instantiate script which is not stated in the specification besides I haven't any such script. So maybe AMF should kill the child process executing the instantiate script before it starts cleanup. This is a change in core since there is no interface to do this. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- ___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #459 Imm: Dynamic deletion of application stream returns SA_AIS_ERR_NOT_EXIST during failover
- Description has changed: Diff: --- old +++ new @@ -2,3 +2,4 @@ The immsv should add an error string to the reply for this case. +Error string should be added for same cases in object create and object delete. - **status**: accepted -- review - **Comment**: https://sourceforge.net/p/opensaf/mailman/message/32177493/ --- ** [tickets:#459] Imm: Dynamic deletion of application stream returns SA_AIS_ERR_NOT_EXIST during failover** **Status:** review **Milestone:** 4.5.FC **Created:** Mon Jun 17, 2013 02:17 PM UTC by Madhurika Koppula **Last Updated:** Tue Apr 01, 2014 09:06 AM UTC **Owner:** Zoran Milinkovic Migrated from http://devel.opensaf.org/ticket/2943 The immsv should add an error string to the reply for this case. Error string should be added for same cases in object create and object delete. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- ___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #625 osaf: Support constant strings in SAF APIs
- **status**: review -- fixed - **Comment**: changeset: 5098:eb646cb93f0c tag: tip parent: 5095:a29089d1696c user:Anders Widell anders.wid...@ericsson.com date:Wed Apr 02 16:47:39 2014 +0200 summary: osaf: Add definition of the new type SaConstStringT [#625] [staging:eb646c] --- ** [tickets:#625] osaf: Support constant strings in SAF APIs** **Status:** fixed **Milestone:** 4.5.FC **Created:** Wed Nov 13, 2013 11:25 AM UTC by Anders Widell **Last Updated:** Fri Mar 07, 2014 02:00 PM UTC **Owner:** Anders Widell There is a fundamental problem with the **SaStringT** type as it is currently defined: typedef char* SaStringT; When **SaStringT** is defined like this, it is impossible to declare a string constant using it. For example, a variable decleared like this: const SaStringT x; has the following meaning: char *const x; i.e., it is only the pointer **x** that is constant, not the string that it is pointing to. There are several possible ways to support constant strings in the SAF APIs: 1) Introduce a new type **SaCharT**, and use **SaCharT** pointers in the API calls instead of **SaStringT**. Since **SaStringT** is defined as a character pointer, it should be possible to replace occurrences of **SaStringT** with ** SaCharT* ** without breaking backwards compatibility. 2) Replace the **SaStringT** typedef with a C preprocessor macro, like this: #define SaStringT char* 3) Intruduce a new type **SaConstStringT**: typedef const char* SaConstStringT; The proposal is to go for 3), and to begin with only define the new type. The new type can later on be used when defining new APIs. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- ___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
