[tickets] [opensaf:tickets] #2927 smf: crash in CcbApplyCallback() due to NULL access
- **status**: assigned --> review
---
** [tickets:#2927] smf: crash in CcbApplyCallback() due to NULL access**
**Status:** review
**Milestone:** 5.18.09
**Created:** Mon Sep 17, 2018 10:57 AM UTC by Thuan
**Last Updated:** Mon Sep 17, 2018 10:57 AM UTC
**Owner:** Thuan
SMFD crash in following code:
src/smf/smfd/SmfImmApplierHdl.cc
static void CcbApplyCallback(SaImmOiHandleT immOiHandle, SaImmOiCcbIdT
ccbId) {
TRACE("%s: Read value in attributes", __FUNCTION__);
attrMod = opdata->param.modify.attrMods[0];
attribute = attrMod->modAttr;
for (int i = 1; attrMod != nullptr; i++) {
/* Get the value */
if (attribute_name.compare(attribute.attrName) != 0) {_
// Not found
attrMod = opdata->param.modify.attrMods[i];
attribute = attrMod->modAttr; <= CRASH HERE
continue;
}
Proposal solution:
~~~
--- a/src/smf/smfd/SmfImmApplierHdl.cc
+++ b/src/smf/smfd/SmfImmApplierHdl.cc
@@ -446,14 +446,13 @@ static void CcbApplyCallback(SaImmOiHandleT immOiHandle,
SaImmOiCcbIdT ccbId) {
*/
TRACE("%s: Read value in attributes", __FUNCTION__);
attrMod = opdata->param.modify.attrMods[0];
- attribute = attrMod->modAttr;
for (int i = 1; attrMod != nullptr; i++) {
/* Get the value */
+attribute = attrMod->modAttr;
if (attribute_name_.compare(attribute.attrName) != 0) {
// Not found
attrMod = opdata->param.modify.attrMods[i];
- attribute = attrMod->modAttr;
continue;
}
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2922 uml: allow plm (and plmtest) to run in UML
- **summary**: plm: allow plmtest to run in UML --> uml: allow plm (and plmtest) to run in UML - **status**: accepted --> review - **Component**: plm --> uml --- ** [tickets:#2922] uml: allow plm (and plmtest) to run in UML** **Status:** review **Milestone:** 5.18.09 **Created:** Thu Sep 06, 2018 02:10 PM UTC by Alex Jones **Last Updated:** Thu Sep 13, 2018 03:44 PM UTC **Owner:** Alex Jones Allow plmtest to run in UML so we can easily run the tests. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2928 osaf: Programmer's Reference and README need update
- **Component**: unknown --> ais - **Part**: - --> doc --- ** [tickets:#2928] osaf: Programmer's Reference and README need update** **Status:** unassigned **Milestone:** 5.18.09 **Created:** Mon Sep 17, 2018 01:24 PM UTC by Nagendra Kumar **Last Updated:** Mon Sep 17, 2018 01:24 PM UTC **Owner:** nobody Programmer's Reference and README need to be updated for better usability, readability and its coherence with OpenSAF functionalities. Few of the things to be corrected are: - References of devel lists tickets, which no longer exists. - Formatting of different sections are different. - Reference to old code structure: opensaf/osaf/, osaf/tools - References to devel lists tickets, which are inaccessible. - Sample output doesn't match with the current demo output. - Spelling mistakes. Some specific issues are: Ntf: The following command mentioned in Ntf PR doesn't work: ntfsend -T 0x5000 -s 4 --probableCause 74 -a “additional information” Smf; Mentioned in PR: smf-bundle-import, smf-bundle-remove, smf-backup-restore doesn't exists. Clm: Mentioned in PR: (see 1818). There is no links to it. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2928 osaf: Programmer's Reference and README need update
--- ** [tickets:#2928] osaf: Programmer's Reference and README need update** **Status:** unassigned **Milestone:** 5.18.09 **Created:** Mon Sep 17, 2018 01:24 PM UTC by Nagendra Kumar **Last Updated:** Mon Sep 17, 2018 01:24 PM UTC **Owner:** nobody Programmer's Reference and README need to be updated for better usability, readability and its coherence with OpenSAF functionalities. Few of the things to be corrected are: - References of devel lists tickets, which no longer exists. - Formatting of different sections are different. - Reference to old code structure: opensaf/osaf/, osaf/tools - References to devel lists tickets, which are inaccessible. - Sample output doesn't match with the current demo output. - Spelling mistakes. Some specific issues are: Ntf: The following command mentioned in Ntf PR doesn't work: ntfsend -T 0x5000 -s 4 --probableCause 74 -a “additional information” Smf; Mentioned in PR: smf-bundle-import, smf-bundle-remove, smf-backup-restore doesn't exists. Clm: Mentioned in PR: (see 1818). There is no links to it. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2927 smf: crash in CcbApplyCallback() due to NULL access
---
** [tickets:#2927] smf: crash in CcbApplyCallback() due to NULL access**
**Status:** assigned
**Milestone:** 5.18.09
**Created:** Mon Sep 17, 2018 10:57 AM UTC by Thuan
**Last Updated:** Mon Sep 17, 2018 10:57 AM UTC
**Owner:** Thuan
SMFD crash in following code:
src/smf/smfd/SmfImmApplierHdl.cc
static void CcbApplyCallback(SaImmOiHandleT immOiHandle, SaImmOiCcbIdT
ccbId) {
TRACE("%s: Read value in attributes", __FUNCTION__);
attrMod = opdata->param.modify.attrMods[0];
attribute = attrMod->modAttr;
for (int i = 1; attrMod != nullptr; i++) {
/* Get the value */
if (attribute_name.compare(attribute.attrName) != 0) {_
// Not found
attrMod = opdata->param.modify.attrMods[i];
attribute = attrMod->modAttr; <= CRASH HERE
continue;
}
Proposal solution:
~~~
--- a/src/smf/smfd/SmfImmApplierHdl.cc
+++ b/src/smf/smfd/SmfImmApplierHdl.cc
@@ -446,14 +446,13 @@ static void CcbApplyCallback(SaImmOiHandleT immOiHandle,
SaImmOiCcbIdT ccbId) {
*/
TRACE("%s: Read value in attributes", __FUNCTION__);
attrMod = opdata->param.modify.attrMods[0];
- attribute = attrMod->modAttr;
for (int i = 1; attrMod != nullptr; i++) {
/* Get the value */
+attribute = attrMod->modAttr;
if (attribute_name_.compare(attribute.attrName) != 0) {
// Not found
attrMod = opdata->param.modify.attrMods[i];
- attribute = attrMod->modAttr;
continue;
}
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
