[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- **Milestone**: 5.19.03 --> future --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** unassigned **Milestone:** future **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Wed Jan 09, 2019 09:51 PM UTC **Owner:** nobody This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- **Milestone**: 5.19.01 --> 5.19.03 --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** unassigned **Milestone:** 5.19.03 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Wed Jan 09, 2019 09:23 PM UTC **Owner:** nobody This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- **status**: review --> unassigned - **assigned_to**: Canh Truong --> nobody --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** unassigned **Milestone:** 5.18.12 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Sat Sep 29, 2018 09:29 AM UTC **Owner:** nobody This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
Is this still being reviewed? --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** review **Milestone:** 5.18.12 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Sat Sep 29, 2018 09:28 AM UTC **Owner:** Canh Truong This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- **Milestone**: 5.18.09 --> 5.18.12 --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** review **Milestone:** 5.18.12 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Thu Aug 30, 2018 12:45 PM UTC **Owner:** Canh Truong This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- **status**: accepted --> review --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** review **Milestone:** 5.17.10 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Fri Aug 11, 2017 03:44 AM UTC **Owner:** Canh Truong This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- **status**: review --> accepted - **Comment**: [develop] commit 8a15fb881c238d4e3246d97d7e5201e5ae235af5 Author: Canh Van Truong Date: Wed Jul 19 18:07:16 2017 +0700 log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445] --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** accepted **Milestone:** 5.17.10 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Thu Jul 20, 2017 06:32 AM UTC **Owner:** Canh Truong This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- **status**: accepted --> review - **Comment**: Part1 - Fix cppcheck, cpplint, replace nullptr for following files: - lgs_amf.*, lgs_config.*, lgs_dest.*, lgs_evt.*, lgs_file.*, lgs_filehdl.*, lgs_nildest.*, lgs_unixsock_dest.* lgs_util.*, lgs_dest_test.* --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** review **Milestone:** 5.17.10 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Sat Jul 01, 2017 04:15 PM UTC **Owner:** Canh Truong This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- Description has changed: Diff: --- old +++ new @@ -1,5 +1,7 @@ This ticket intends to do some enhancements: -1) Put headers and implementations in proper places +1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr + +Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** accepted **Milestone:** 5.17.08 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Tue May 30, 2017 01:25 PM UTC **Owner:** Canh Truong This ticket intends to do some enhancements: 1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file) 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
- Description has changed: Diff: --- old +++ new @@ -2,3 +2,4 @@ 1) Put headers and implementations in proper places 2) Fix all cppcheck messages 3) Fix all cpplint messages +4) Replace NULL by nullptr - **assigned_to**: Vu Minh Nguyen --> Canh Truong --- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** accepted **Milestone:** 5.17.08 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Fri Apr 28, 2017 08:28 AM UTC **Owner:** Canh Truong This ticket intends to do some enhancements: 1) Put headers and implementations in proper places 2) Fix all cppcheck messages 3) Fix all cpplint messages 4) Replace NULL by nullptr --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2445 log: reorganize headers and implementation
--- ** [tickets:#2445] log: reorganize headers and implementation** **Status:** accepted **Milestone:** 5.17.08 **Created:** Fri Apr 28, 2017 08:28 AM UTC by Vu Minh Nguyen **Last Updated:** Fri Apr 28, 2017 08:28 AM UTC **Owner:** Vu Minh Nguyen This ticket intends to do some enhancements: 1) Put headers and implementations in proper places 2) Fix all cppcheck messages 3) Fix all cpplint messages --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets