Looks OK. Perhaps in avd_try_send_notification(), you could change
notificationHandle to a reference, to avoid duplicating"if
(myntf->notificationType == YYY)" twice in that function.
---
** [tickets:#314] AMF looses alarms and notifications during switch-over**
**Status:** fixed
**Milestone:
Notifications are pused in job queue. During switchover, active controller will
empty the job queue. Since notifications allocate memory it needs to be freed.
Here is the patch to avoid this memory leak:
diff --git a/osaf/services/saf/amf/amfd/ntf.cc
b/osaf/services/saf/amf/amfd/ntf.cc
--- a/osa
- **status**: review --> fixed
- **Comment**:
changeset: 8306:45b922ca767a
branch: opensaf-5.0.x
user:Praveen Malviya
date:Thu Nov 10 13:59:08 2016 +0530
summary: amfd: push notification in existing job queue for retries [#314] V2
changeset: 8307:174a2701e3ad
branch:
V2 published. Includes suggestions given by Gary.
---
** [tickets:#314] AMF looses alarms and notifications during switch-over**
**Status:** review
**Milestone:** 5.0.2
**Created:** Fri May 24, 2013 08:34 AM UTC by Nagendra Kumar
**Last Updated:** Thu Oct 13, 2016 10:10 AM UTC
**Owner:** Pravee
- **status**: assigned --> review
- **Milestone**: future --> 5.0.2
---
** [tickets:#314] AMF looses alarms and notifications during switch-over**
**Status:** review
**Milestone:** 5.0.2
**Created:** Fri May 24, 2013 08:34 AM UTC by Nagendra Kumar
**Last Updated:** Tue Oct 04, 2016 09:11 AM UT
Attached is the patch that pushes notifications as job by making imm_ntf_job as
common queue for both imm and ntf. It handles TRY_AGAIN and TIMEOUT in the same
way as it is handled for IMM jobs. Thus AMFD will not get blocked for retrying
to send notification and also it will not log then as err
We are seeing this regularly ..
---
** [tickets:#314] AMF looses alarms and notifications during switch-over**
**Status:** assigned
**Milestone:** future
**Created:** Fri May 24, 2013 08:34 AM UTC by Nagendra Kumar
**Last Updated:** Mon Jul 18, 2016 09:36 AM UTC
**Owner:** Praveen
**Attachments
- **status**: accepted --> assigned
- **Milestone**: 4.7.2 --> future
- **Comment**:
Not planned for 4.7.2.
---
** [tickets:#314] AMF looses alarms and notifications during switch-over**
**Status:** assigned
**Milestone:** future
**Created:** Fri May 24, 2013 08:34 AM UTC by Nagendra Kumar
**
Hi Praveen
Any ETA on this?
Thanks
---
** [tickets:#314] AMF looses alarms and notifications during switch-over**
**Status:** accepted
**Milestone:** 4.7.2
**Created:** Fri May 24, 2013 08:34 AM UTC by Nagendra Kumar
**Last Updated:** Wed May 04, 2016 07:20 PM UTC
**Owner:** Praveen
**Attachm
- **Milestone**: 4.5.2 --> 4.6.2
---
** [tickets:#314] AMF looses alarms and notifications during switch-over**
**Status:** accepted
**Milestone:** 4.6.2
**Created:** Fri May 24, 2013 08:34 AM UTC by Nagendra Kumar
**Last Updated:** Mon Apr 20, 2015 06:42 AM UTC
**Owner:** Praveen
**Attachment
- **status**: unassigned --> accepted
- **assigned_to**: Praveen
- **Part**: - --> d
- **Milestone**: future --> 4.5.2
- **Comment**:
Issue is reproducible in default branch.
Attached are the AMFD traces and syslog after reproducing it.
---
** [tickets:#314] AMF looses alarms and notifications
11 matches
Mail list logo