Re: [Openslp-devel] Possible defects in source code

2012-07-10 Thread Roel van de Kraats
Hi all, I ran into this mail below, which I think we shouldn't simply ignore. Sorry Vitezslav, for doing so for almost a year :-[ After a little svn digging, I found out that the problem in common/slp_predicate.c seems to have been introduced in a code clean-up by John: http://openslp.svn.sou

[Openslp-devel] Possible defects in source code

2011-08-24 Thread Vitezslav Crhonek
Hello, We found possible defects in source code during Coverity scan (static analysis) of openslp-2.0.beta2. I'd like to discuss two of them. common/slp_predicate.c: 301 case opaque: 302 if (!memcmpchar *) (a->val.opaqueVal)) + 4), 303 (((char *)(b->val