Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/ --- (Updated March 12, 2011, 11:54 p.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Release 2.5.2 candidate is available

One request - at least for the Mac client (not sure if the other platform builds are set up this way). Please give pre-release builds an appropriate name (ie Project, Development, Developer, etc). If I were to follow the instructions and drag the application into my applications folder, it wou

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

> On March 12, 2011, 7:16 a.m., Oz Linden wrote: > > indra/llcharacter/llbvhloader.cpp, line 1199 > > > > > > I think it would be clearer to either add a new constant > > POSITION_MOTION_THRESHOLD_SQUARED or to write

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

> On March 11, 2011, 3:53 a.m., Boroondas Gupte wrote: > > indra/newview/llnetmap.cpp, line 337 > > > > > > Maybe add a short comment here, that this value is meant to be > > overwritten in the loop below it. Good id

Re: [opensource-dev] Review Request: STORM-1025 Chat preferences > font size should increase size of input text as well

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated March 12, 2011, 4:42 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated March 12, 2011, 4:33 p.m.) Review request for Viewer. Summary --

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

> On March 12, 2011, 7:16 a.m., Oz Linden wrote: > > indra/llcharacter/llbvhloader.cpp, line 1199 > > > > > > I think it would be clearer to either add a new constant > > POSITION_MOTION_THRESHOLD_SQUARED or to write

[opensource-dev] Outstanding patches since Januari...

This is just a reminder that there are still six patches of me waiting on the reviewboard: https://codereview.secondlife.com/r/88/ https://codereview.secondlife.com/r/92/ https://codereview.secondlife.com/r/80/ https://codereview.secondlife.com/r/95/ https://codereview.secondlife.com/r/81/ https:/

Re: [opensource-dev] PO Test Build (223545)

storm- 28: seems to work okay storm-357: fail Storm-399: fail object names do not seem to work properly if DN is on storm-1019: fail: see ardy's comments storm-1021: seems to work so far storm-1064: seems alright... ___

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- (Updated March 12, 2011, 8 a.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- (Updated March 12, 2011, 7:52 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- (Updated March 12, 2011, 7:51 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

On 2011-03-11 11:43, Ricky wrote: Thanks for the review! Yes, I am familiar with those "principles of optimization" - yet it seemed to just feel wrong to leave it alone... :P As to the variables that are initialized with high numbers, there has to be a better way: if these were standard for-lo

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review448 --- If the comments here are addressed, I think this is probably a goo

Re: [opensource-dev] PO Test Build (223545)

* STORM-28 : As a User, I want the ability to send my calling card to others (additional fixes) Tried it a few times. Seems to have worked but the message I got back appeared to be an IM from the recipient (I had an IM session open with them at the time), not a notice from the system: [06:22]

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

> On March 11, 2011, 3:53 a.m., Boroondas Gupte wrote: > > indra/newview/llselectmgr.cpp, lines 6574-6587 > > > > > > Memory reuse is good, I guess, but having variable names that only > > describe the variable's con

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/ --- (Updated March 12, 2011, 6:33 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

On 2011-03-11 14:21, Lance Corrimal wrote: > Am Freitag, 11. März 2011 schrieb Hitomi Tiponi: >> Thanks for that Jonathan. Having seen that I am worried that it may >> be a little too indistinct, especially as this would be a useful >> feature when sailing, when the blue of the sea is the backgroun