Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

2011-03-02 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/ --- (Updated March 2, 2011, 8:47 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

2011-03-01 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review401 --- I've nothing against lazy evaluation (I actually like that) but I

Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

2011-02-22 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review382 --- Looks good, except for a seemingly redundant code piece.

Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

2011-02-22 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review383 --- Ship it! Never mind, now I see that the buddies_uuids vector is

[opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

2011-02-21 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/ --- Review request for Viewer. Summary --- - Added creating own calling

Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others

2011-02-21 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review381 --- Ship it! Reduces code and a great feature. I remember going in