[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #30 from Damien

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Darren Tucker changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Attachment #3228|ok?(d...@mindrot.org)|ok+ Flags|

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Darren Tucker changed: What|Removed |Added Attachment #2858|0 |1 is obsolete|

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks|2893| --- Comment #27 from Damien Miller ---

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #26 from Damien Miller --- Retarget unfinished bugs to OpenSSH 8.0 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks||2915 --- Comment #25 from Damien Miller

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks|2852| Referenced Bugs:

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #24 from Damien Miller --- Retarget remaining bugs planned for 7.8 release to 7.9 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks||2893 --- Comment #23 from Damien Miller

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks|2782| --- Comment #22 from

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks||2852 Referenced Bugs:

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks|2698| Referenced Bugs:

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks||2782 Referenced Bugs:

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #21 from Damien Miller --- Comment on attachment 2942 --> https://bugzilla.mindrot.org/attachment.cgi?id=2942 Simplify population of file name display >This keeps the padded and/or truncated displayname in its own

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #20 from Damien Miller --- remove 7.5 target -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug.

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks|2647| Referenced Bugs:

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks||2698 --- Comment #19

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #18 from Damien Miller --- FYI I've fixed mprintf's truncation of escape characters in commit 011c8ffbb027 -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added CC||m...@arty.name ---

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #16 from Darren Tucker --- (In reply to Damien Miller from comment #15) > produces the expected "\022XXX" output too for both LC_CTYPE set to > UTF-8 and C... interesting, your test code behaves as expected on

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #15 from Damien Miller --- (In reply to Darren Tucker from comment #14) > > I think smprintf() will fallback to vis(3) internally so you > > shouldn't need this case. > > it doesn't. It gets to the first escape

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #14 from Darren Tucker --- (In reply to Damien Miller from comment #13) > oops, yes. What happens if a window size change happens between > update_progress_displayname() and update_progress_meter()? The display

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #13 from Damien Miller --- oops, yes. What happens if a window size change happens between update_progress_displayname() and update_progress_meter()? It looks like it will cause the filename to only be updated after

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #12 from Darren Tucker --- (In reply to Damien Miller from comment #11) > I don't this will give good output if it chops file in the middle of > a multibyte character. The first patch does not handle multibyte

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #11 from Damien Miller --- Comment on attachment 2942 --> https://bugzilla.mindrot.org/attachment.cgi?id=2942 Simplify population of file name display >+ displayname[0] = '\0'; >+ if (file_len > 0) >+

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #10 from Darren Tucker --- Created attachment 2943 --> https://bugzilla.mindrot.org/attachment.cgi?id=2943=edit Generate display name outside of sighandler patch 2 of 2. applies on top of attachment #2942. --

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #9 from Darren Tucker --- Created attachment 2942 --> https://bugzilla.mindrot.org/attachment.cgi?id=2942=edit Simplify population of file name display patch 1 of 2 -- You are receiving this mail because: You

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #8 from Darren Tucker --- (In reply to Damien Miller from comment #7) [...] > 3. Arrange for the formatting (at least of the filename) to happen > in a non-signal context this one gets my vote. > Perhaps we could

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #7 from Damien Miller --- TL;DR signals are hard, lets go do some neurosurgery Looking at this again, this is quite difficult to fix so long as our progress meter runs in signal context. Even if we got rid of the

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks||2647 --- Comment #6

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added Blocks|2594| Referenced Bugs:

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Damien Miller changed: What|Removed |Added CC||d...@mindrot.org ---

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Darren Tucker changed: What|Removed |Added Blocks||2594

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Jakub Jelen changed: What|Removed |Added Attachment #2678|0 |1 is obsolete|

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 --- Comment #2 from Jakub Jelen jje...@redhat.com --- Or better way would be use solution proposed in bug discussing banner [1] (which is lying there for over one year untouched). We use that solution for banner for some time in RH so applying it

[Bug 2434] scp can send arbitrary control characters / escape sequences to the terminal

https://bugzilla.mindrot.org/show_bug.cgi?id=2434 Jakub Jelen jje...@redhat.com changed: What|Removed |Added CC||jje...@redhat.com ---