[Bug 2956] New: using "sftp root@[2001::16%eth0]", output error: Could not resolve hostname: Name or service not known

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2956

Bug ID: 2956
   Summary: using "sftp root@[2001::16%eth0]", output error: Could
not resolve hostname: Name or service not known
   Product: Portable OpenSSH
   Version: 7.9p1
  Hardware: ix86
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5
 Component: sftp
  Assignee: unassigned-b...@mindrot.org
  Reporter: xuchun...@huawei.com

when using sftp to connect ipv6 address without path, error happens
like this:
sftp root@[2001::16%eth0]

ssh: Could not resolve hostname [2001::16%eth0]: Name
or service not known
Connection closed.
Connection closed

openssh version is:
openssh-clients-7.8p1-3.fc29.x86_64
OS is fedora29 x86

i try to analyse the error output,
when parse_user_host_path, colon funciton:
char *
colon(char *cp)
{
int flag = 0;

if (*cp == ':') /* Leading colon is part of file name.
*/
return NULL;
if (*cp == '[')
flag = 1;

for (; *cp; ++cp) {
if (*cp == '@' && *(cp+1) == '[')
flag = 1;
if (*cp == ']' && *(cp+1) == ':' && flag)
return (cp+1);
if (*cp == ':' && !flag)
return (cp);
if (*cp == '/')
return NULL;
}
return NULL;
}

after ']' there must be ':', otherwise return NULL, then the whole arg
"root@[2001::16%eth0]" be treated as a plain hostname, host 
resolv failed.

here is my solution:
---
 misc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/misc.c b/misc.c
index bdc06fd..84dc451 100644
--- a/misc.c
+++ b/misc.c
@@ -557,6 +557,8 @@ colon(char *cp)
flag = 1;
if (*cp == ']' && *(cp+1) == ':' && flag)
return (cp+1);
+   if (*cp == ']' && *(cp+1) == '\0' && flag)
+   return (cp+1);
if (*cp == ':' && !flag)
return (cp);
if (*cp == '/')
-- 

please check.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2635] Unable to use SSH Agent and user level PKCS11Provider configuration directive

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2635

Damien Miller  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Damien Miller  ---
Looks like this is an OpenSC bug. If it still persists with the
patch/version that Jakub recommended then please reopen this bug.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2620] Option AddKeysToAgent doesnt work with keys provided by PKCS11 libraries.

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2620

--- Comment #2 from Damien Miller  ---
I don't think we want to make AddKeysToAgent automate adding PKCS#11
tokens - there are too many side effects compared to the intended
use-case of adding regular keys.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2915] Tracking bug for 8.0 release

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2915

Damien Miller  changed:

   What|Removed |Added

 Depends on||2652


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2652
[Bug 2652] PKCS11 login skipped if login required and no pin set
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching the reporter of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2652] PKCS11 login skipped if login required and no pin set

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2652

Damien Miller  changed:

   What|Removed |Added

 Blocks||2915


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2915
[Bug 2915] Tracking bug for 8.0 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2652] PKCS11 login skipped if login required and no pin set

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2652

Damien Miller  changed:

   What|Removed |Added

   Attachment #3032|0   |1
is obsolete||
   Attachment #3124|0   |1
is obsolete||
   Attachment #3125|0   |1
is obsolete||
   Assignee|unassigned-b...@mindrot.org |d...@mindrot.org

--- Comment #21 from Damien Miller  ---
Created attachment 3226
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3226=edit
update patch to post-ECDSA PKCS#11 key merge

This updates the patch after the PKCS#11 ECDSA code has landed. Note
that this patch is now atop the one on bug 2638

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2817] Add support for PKCS#11 URIs (RFC 7512)

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2817

Damien Miller  changed:

   What|Removed |Added

   Keywords||pkcs11
 CC||d...@mindrot.org

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2652] PKCS11 login skipped if login required and no pin set

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2652

Damien Miller  changed:

   What|Removed |Added

   Keywords||pkcs11

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2808] Unable to add certificates to agent when using PKCS#11 backed keys.

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2808

Damien Miller  changed:

   What|Removed |Added

   Keywords||pkcs11

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2620] Option AddKeysToAgent doesnt work with keys provided by PKCS11 libraries.

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2620

Damien Miller  changed:

   What|Removed |Added

 CC||d...@mindrot.org
   Keywords||pkcs11

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2635] Unable to use SSH Agent and user level PKCS11Provider configuration directive

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2635

Damien Miller  changed:

   What|Removed |Added

   Keywords||pkcs11

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2638] Honor PKCS#11 CKA_ALWAYS_AUTHENTICATE attribute of the private objects

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2638

Damien Miller  changed:

   What|Removed |Added

   Keywords||pkcs11

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2915] Tracking bug for 8.0 release

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2915

Damien Miller  changed:

   What|Removed |Added

 Depends on||2638


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2638
[Bug 2638] Honor PKCS#11 CKA_ALWAYS_AUTHENTICATE attribute of the 
private objects
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching the reporter of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2638] Honor PKCS#11 CKA_ALWAYS_AUTHENTICATE attribute of the private objects

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2638

Damien Miller  changed:

   What|Removed |Added

   Attachment #3033|0   |1
is obsolete||
 CC||d...@mindrot.org

--- Comment #3 from Damien Miller  ---
Created attachment 3225
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3225=edit
revised patch after PKCS#11 ECDSA support landed

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2638] Honor PKCS#11 CKA_ALWAYS_AUTHENTICATE attribute of the private objects

2019-01-21 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2638

Damien Miller  changed:

   What|Removed |Added

 Blocks||2915

--- Comment #4 from Damien Miller  ---
Pity there seems no way to test this using softhsm2


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2915
[Bug 2915] Tracking bug for 8.0 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs