[Bug 2608] Signed overflow in openbsd-compat/strlcpy.c
https://bugzilla.mindrot.org/show_bug.cgi?id=2608 Damien Miller changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #6 from Damien Miller --- closing resolved bugs as of 8.6p1 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2608] Signed overflow in openbsd-compat/strlcpy.c
https://bugzilla.mindrot.org/show_bug.cgi?id=2608 Damien Miller changed: What|Removed |Added Resolution|--- |WONTFIX CC||d...@mindrot.org Status|NEW |RESOLVED --- Comment #5 from Damien Miller --- I agree with Darren's analysis - the existing implementation is compliant with ISO C. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2608] Signed overflow in openbsd-compat/strlcpy.c
https://bugzilla.mindrot.org/show_bug.cgi?id=2608 Hongxu Jia changed: What|Removed |Added CC||hongxu@windriver.com --- Comment #4 from Hongxu Jia --- Created attachment 3293 --> https://bugzilla.mindrot.org/attachment.cgi?id=3293&action=edit proposed fix v2 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2608] Signed overflow in openbsd-compat/strlcpy.c
https://bugzilla.mindrot.org/show_bug.cgi?id=2608 Darren Tucker changed: What|Removed |Added Blocks|2594| --- Comment #3 from Darren Tucker --- I applied then, after some discussion with some folks, reverted your change. The rationale is that C11 6.5.6.9 says: """ When two pointers are subtracted, both shall point to elements of the same array object, or one past the last element of the array object; the result is the difference of the subscripts of the two array elements. """ In these cases the objects are arrays of char so the result is defined, and we believe that the compiler incorrectly trapping on defined behaviour. I also found https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63303 ("Pointer subtraction is broken when using -fsanitize=undefined") which seems to support this position. Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=2594 [Bug 2594] Tracking bug for OpenSSH 7.4 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2608] Signed overflow in openbsd-compat/strlcpy.c
https://bugzilla.mindrot.org/show_bug.cgi?id=2608 Darren Tucker changed: What|Removed |Added Blocks||2594 CC||dtuc...@zip.com.au --- Comment #2 from Darren Tucker --- Thanks. Looking (these files are sourced from OpenBSD, so any changes will need to go upstream first). Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=2594 [Bug 2594] Tracking bug for OpenSSH 7.4 release -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2608] Signed overflow in openbsd-compat/strlcpy.c
https://bugzilla.mindrot.org/show_bug.cgi?id=2608 --- Comment #1 from Yuanjie Huang --- Created attachment 2867 --> https://bugzilla.mindrot.org/attachment.cgi?id=2867&action=edit proposed fix. -- You are receiving this mail because: You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs