Still FAILED build of OpenSSL branch master with options -d --strict-warnings no-cms
Platform and configuration command: $ uname -a Linux run 4.15.0-106-generic #107-Ubuntu SMP Thu Jun 4 11:27:52 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux $ CC=clang ../openssl/config -d --strict-warnings no-cms Commit log since last time: 458cb85d19 Fix ECX serializer import calls to use correct selection flags. d9cdfda24f Fix RSA serializer import calls to use correct selection flags. 81fca0e7c1 Fix DSA serializer import calls to use correct selection flags. 3fab56631f Fix DH serializer import calls to use correct selection flags. 835b290016 Fix PKCS#7 so that it still works with non fetchable cipher algorithms. bd1bbbfe51 Fix PKCS#7 so that it still works with non fetchable digest algorithms. 8e32ea633f Check whether we have MD5-SHA1 and whether we need it 7cd1420b3e Improve some error messages if a digest is not available e3bf65da88 Include "legacy" in the name of the various MAC bridge functions 52ae0f8fc2 Add some documentation about the EVP_PKEY MAC interface 2ef9a7ac5e Improve code reuse in the provider MAC bridge 2106b04719 Document the EVP_PKEY_new_CMAC_key_with_libctx() function e5bc0ce2ae Extend test_CMAC_keygen in evp_extra_test 2cf765e5a2 Delete unused PKEY MAC files a540ef90f5 Extend the provider MAC bridge for CMAC 4db71d0175 Extend the provider MAC bridge for Poly1305 8014b2a966 Don't require a default digest from signature algorithms b27b31b628 Extend the provider MAC bridge for SIPHASH 6f0bd6ca1c Ensure libssl creates libctx aware MAC keys ada0670bf6 Fix some EVP_MD_CTX_* functions 5d51925a90 Convert EVP_PKEY_CTX_set_mac_key() into a function 1bf625040c Fix evp_extra_test to not assume that HMAC is legacy b571e662cd Make the provider side EVP PKEY MAC bridge available in default and fips 409910be16 Implement signature functions for EVP_PKEY MAC to EVP_MAC provider bridge e538294f8f Implement key management for the EVP_PKEY MAC to EVP_MAC provider bridge bddfea0271 TEST: Adapt some tests for a stricter PEM_write_bio_PrivateKey_traditional() 87d91d223b Fix PEM_write_bio_PrivateKey_traditional() to not output PKCS#8 b6ef3c7089 Correct description of BN_mask_bits 33855c0af6 conf: add diagnostic option 3d94185718 provider_conf: report missing section on error cd84d8832d Ignore vendor name in Clang version number. 4516bf7422 rand: instantiate the DRBGs upon first use. edd53e9135 rand: add a note about a potentially misleading code analyzer warning. 1d6c86709c apps/pkcs12.c: Add -untrusted option 77a9bb83d7 X509_add_certs(): Add to doc some warning notes on memory management 0495a3ec4a Add OCSP_PARTIAL_CHAIN to OCSP_basic_verify() fcc3a5204c apps: -msg flag enhancement 2/2 50c911b0c5 apps: -msg flag enhancement 1/2 625679b6d7 EVP: NULL pctx pointer after free. Build log ended with (last 100 lines): clang -Iinclude -Iapps/include -I../openssl/include -I../openssl/apps/include -pthread -m64 -Wa,--noexecstack -Qunused-arguments -Wall -O0 -g -DDEBUG_UNUSED -DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wswitch -Wsign-compare -Wshadow -Wformat -Wtype-limits -Wundef -Werror -Wmissing-prototypes -Wstrict-prototypes -Wno-unknown-warning-option -Wswitch-default -Wno-parentheses-equality -Wno-language-extension-token -Wno-extended-offsetof -Wconditional-uninitialized -Wincompatible-pointer-types-discards-qualifiers -Wmissing-variable-declarations -DOPENSSL_BUILDING_OPENSSL -MMD -MF test/ssl_ctx_test-bin-ssl_ctx_test.d.tmp -MT test/ssl_ctx_test-bin-ssl_ctx_test.o -c -o test/ssl_ctx_test-bin-ssl_ctx_test.o ../openssl/test/ssl_ctx_test.c clang -I. -Iinclude -I../openssl -I../openssl/include -Iinclude -Iapps/include -I../openssl/include -I../openssl/apps/include -pthread -m64 -Wa,--noexecstack -Qunused-arguments -Wall -O0 -g -DDEBUG_UNUSED -DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wswitch -Wsign-compare -Wshadow -Wformat -Wtype-limits -Wundef -Werror -Wmissing-prototypes -Wstrict-prototypes -Wno-unknown-warning-option -Wswitch-default -Wno-parentheses-equality -Wno-language-extension-token -Wno-extended-offsetof -Wconditional-uninitialized -Wincompatible-pointer-types-discards-qualifiers -Wmissing-variable-declarations -DOPENSSL_BUILDING_OPENSSL -MMD -MF test/ssl_test-bin-handshake_helper.d.tmp -MT test/ssl_test-bin-handshake_helper.o -c -o test/ssl_test-bin-handshake_helper.o ../openssl/test/handshake_helper.c clang -Iinclude -Iapps/include -I../openssl/include -I../openssl/apps/include -pthread -m64 -Wa,--noexecstack -Qunused-arguments -Wall -O0 -g -DDEBUG_UNUSED -DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wswitch -Wsign-compare -Wshadow -Wformat -Wtype-limits -Wundef -Werror -Wmissing-prototypes -Wstrict-prototypes -Wno-unknown-warning-option -Wswitch-default -Wno-parentheses-equality -Wno-language-extension-token -Wno-extended-offsetof -Wconditional-uninitialized
[openssl] master update
The branch master has been updated via 23e77b0ba328afe3492d990cd24f7b8896b4246f (commit) via e2e46dfa8c42b5d47723aaed60d7fce3d84455c5 (commit) from 458cb85d1985aa3efe0a33eb59123d23b5fa975a (commit) - Log - commit 23e77b0ba328afe3492d990cd24f7b8896b4246f Author: Jon Spillett Date: Fri Aug 21 14:18:59 2020 +1000 Update test data for DSA public key text Reviewed-by: Matt Caswell Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/12688) commit e2e46dfa8c42b5d47723aaed60d7fce3d84455c5 Author: Jon Spillett Date: Thu Aug 20 09:13:28 2020 +1000 Add the correct enum value for DSA public key serialization Reviewed-by: Matt Caswell Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/12688) --- Summary of changes: providers/implementations/encode_decode/encoder_dsa_pub.c | 2 +- test/recipes/30-test_evp_pkey_provided/DSA.pub.txt| 6 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/providers/implementations/encode_decode/encoder_dsa_pub.c b/providers/implementations/encode_decode/encoder_dsa_pub.c index f99388e150..e1201634b9 100644 --- a/providers/implementations/encode_decode/encoder_dsa_pub.c +++ b/providers/implementations/encode_decode/encoder_dsa_pub.c @@ -173,7 +173,7 @@ static int dsa_pub_print(void *ctx, void *dsa, OSSL_CORE_BIO *cout, if (out == NULL) return 0; -ret = ossl_prov_print_dsa(out, dsa, 0); +ret = ossl_prov_print_dsa(out, dsa, dsa_print_pub); BIO_free(out); return ret; diff --git a/test/recipes/30-test_evp_pkey_provided/DSA.pub.txt b/test/recipes/30-test_evp_pkey_provided/DSA.pub.txt index 1b1b758b03..0cd037294c 100644 --- a/test/recipes/30-test_evp_pkey_provided/DSA.pub.txt +++ b/test/recipes/30-test_evp_pkey_provided/DSA.pub.txt @@ -1,8 +1,4 @@ -Private-Key: (2048 bit) -priv: -00:8f:c5:9e:d0:f7:2a:0b:66:f1:32:73:ae:f6:d9: -d4:db:2d:96:55:89:ff:ef:a8:5f:47:8f:ca:02:8a: -e1:35:90 +Public-Key: (2048 bit) pub: 44:19:c9:46:45:57:c1:a9:d8:30:99:29:6a:4b:63: 71:69:96:35:17:b2:62:9b:80:0a:95:9d:6a:c0:32:
Still FAILED build of OpenSSL branch master with options -d --strict-warnings no-autoerrinit
Platform and configuration command: $ uname -a Linux run 4.15.0-106-generic #107-Ubuntu SMP Thu Jun 4 11:27:52 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux $ CC=clang ../openssl/config -d --strict-warnings no-autoerrinit Commit log since last time: 458cb85d19 Fix ECX serializer import calls to use correct selection flags. d9cdfda24f Fix RSA serializer import calls to use correct selection flags. 81fca0e7c1 Fix DSA serializer import calls to use correct selection flags. 3fab56631f Fix DH serializer import calls to use correct selection flags. 835b290016 Fix PKCS#7 so that it still works with non fetchable cipher algorithms. bd1bbbfe51 Fix PKCS#7 so that it still works with non fetchable digest algorithms. 8e32ea633f Check whether we have MD5-SHA1 and whether we need it 7cd1420b3e Improve some error messages if a digest is not available e3bf65da88 Include "legacy" in the name of the various MAC bridge functions 52ae0f8fc2 Add some documentation about the EVP_PKEY MAC interface 2ef9a7ac5e Improve code reuse in the provider MAC bridge 2106b04719 Document the EVP_PKEY_new_CMAC_key_with_libctx() function e5bc0ce2ae Extend test_CMAC_keygen in evp_extra_test 2cf765e5a2 Delete unused PKEY MAC files a540ef90f5 Extend the provider MAC bridge for CMAC 4db71d0175 Extend the provider MAC bridge for Poly1305 8014b2a966 Don't require a default digest from signature algorithms b27b31b628 Extend the provider MAC bridge for SIPHASH 6f0bd6ca1c Ensure libssl creates libctx aware MAC keys ada0670bf6 Fix some EVP_MD_CTX_* functions 5d51925a90 Convert EVP_PKEY_CTX_set_mac_key() into a function 1bf625040c Fix evp_extra_test to not assume that HMAC is legacy b571e662cd Make the provider side EVP PKEY MAC bridge available in default and fips 409910be16 Implement signature functions for EVP_PKEY MAC to EVP_MAC provider bridge e538294f8f Implement key management for the EVP_PKEY MAC to EVP_MAC provider bridge bddfea0271 TEST: Adapt some tests for a stricter PEM_write_bio_PrivateKey_traditional() 87d91d223b Fix PEM_write_bio_PrivateKey_traditional() to not output PKCS#8 b6ef3c7089 Correct description of BN_mask_bits 33855c0af6 conf: add diagnostic option 3d94185718 provider_conf: report missing section on error cd84d8832d Ignore vendor name in Clang version number. 4516bf7422 rand: instantiate the DRBGs upon first use. edd53e9135 rand: add a note about a potentially misleading code analyzer warning. 1d6c86709c apps/pkcs12.c: Add -untrusted option 77a9bb83d7 X509_add_certs(): Add to doc some warning notes on memory management 0495a3ec4a Add OCSP_PARTIAL_CHAIN to OCSP_basic_verify() fcc3a5204c apps: -msg flag enhancement 2/2 50c911b0c5 apps: -msg flag enhancement 1/2 625679b6d7 EVP: NULL pctx pointer after free. Build log ended with (last 100 lines): 65-test_cmp_status.t ... ok 65-test_cmp_vfy.t .. ok 70-test_asyncio.t .. ok 70-test_bad_dtls.t . ok 70-test_clienthello.t .. ok 70-test_comp.t . ok 70-test_key_share.t ok 70-test_packet.t ... ok 70-test_recordlen.t ok 70-test_renegotiation.t ok 70-test_servername.t ... ok 70-test_sslcbcpadding.t ok 70-test_sslcertstatus.t ok 70-test_sslextension.t . ok 70-test_sslmessages.t .. ok 70-test_sslrecords.t ... ok 70-test_sslsessiontick.t ... ok 70-test_sslsigalgs.t ... ok 70-test_sslsignature.t . ok 70-test_sslskewith0p.t . ok 70-test_sslversions.t .. ok 70-test_sslvertol.t ok 70-test_tls13alerts.t .. ok 70-test_tls13cookie.t .. ok 70-test_tls13downgrade.t ... ok 70-test_tls13hrr.t . ok 70-test_tls13kexmodes.t ok 70-test_tls13messages.t ok 70-test_tls13psk.t . ok 70-test_tlsextms.t . ok 70-test_verify_extra.t . ok 70-test_wpacket.t .. ok 71-test_ssl_ctx.t .. ok 80-test_ca.t ... ok 80-test_cipherbytes.t .. ok 80-test_cipherlist.t ... ok 80-test_ciphername.t ... ok # 80-test_cms.t .. ok 80-test_cmsapi.t ... ok 80-test_ct.t ... ok 80-test_dane.t . ok 80-test_dtls.t . ok 80-test_dtls_mtu.t . ok 80-test_dtlsv1listen.t . ok 80-test_http.t . ok 80-test_ocsp.t . ok 80-test_pkcs12.t ... ok 80-test_ssl_new.t .. ok 80-test_ssl_old.t .. ok 80-test_ssl_test_ctx.t . ok 80-test_sslcorrupt.t ... ok 80-test_tsa.t .. ok 80-test_x509aux.t .. ok # 81-test_cmp_cli.t .. ok 90-test_asn1_time.t ok 90-test_async.t
Still FAILED build of OpenSSL branch master with options -d --strict-warnings enable-asan no-shared -DOPENSSL_SMALL_FOOTPRINT
Platform and configuration command: $ uname -a Linux run 4.15.0-106-generic #107-Ubuntu SMP Thu Jun 4 11:27:52 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux $ CC=clang ../openssl/config -d --strict-warnings enable-asan no-shared -DOPENSSL_SMALL_FOOTPRINT Commit log since last time: 458cb85d19 Fix ECX serializer import calls to use correct selection flags. d9cdfda24f Fix RSA serializer import calls to use correct selection flags. 81fca0e7c1 Fix DSA serializer import calls to use correct selection flags. 3fab56631f Fix DH serializer import calls to use correct selection flags. 835b290016 Fix PKCS#7 so that it still works with non fetchable cipher algorithms. bd1bbbfe51 Fix PKCS#7 so that it still works with non fetchable digest algorithms. 8e32ea633f Check whether we have MD5-SHA1 and whether we need it 7cd1420b3e Improve some error messages if a digest is not available e3bf65da88 Include "legacy" in the name of the various MAC bridge functions 52ae0f8fc2 Add some documentation about the EVP_PKEY MAC interface 2ef9a7ac5e Improve code reuse in the provider MAC bridge 2106b04719 Document the EVP_PKEY_new_CMAC_key_with_libctx() function e5bc0ce2ae Extend test_CMAC_keygen in evp_extra_test 2cf765e5a2 Delete unused PKEY MAC files a540ef90f5 Extend the provider MAC bridge for CMAC 4db71d0175 Extend the provider MAC bridge for Poly1305 8014b2a966 Don't require a default digest from signature algorithms b27b31b628 Extend the provider MAC bridge for SIPHASH 6f0bd6ca1c Ensure libssl creates libctx aware MAC keys ada0670bf6 Fix some EVP_MD_CTX_* functions 5d51925a90 Convert EVP_PKEY_CTX_set_mac_key() into a function 1bf625040c Fix evp_extra_test to not assume that HMAC is legacy b571e662cd Make the provider side EVP PKEY MAC bridge available in default and fips 409910be16 Implement signature functions for EVP_PKEY MAC to EVP_MAC provider bridge e538294f8f Implement key management for the EVP_PKEY MAC to EVP_MAC provider bridge bddfea0271 TEST: Adapt some tests for a stricter PEM_write_bio_PrivateKey_traditional() 87d91d223b Fix PEM_write_bio_PrivateKey_traditional() to not output PKCS#8 b6ef3c7089 Correct description of BN_mask_bits 33855c0af6 conf: add diagnostic option 3d94185718 provider_conf: report missing section on error cd84d8832d Ignore vendor name in Clang version number. 4516bf7422 rand: instantiate the DRBGs upon first use. edd53e9135 rand: add a note about a potentially misleading code analyzer warning. 1d6c86709c apps/pkcs12.c: Add -untrusted option 77a9bb83d7 X509_add_certs(): Add to doc some warning notes on memory management 0495a3ec4a Add OCSP_PARTIAL_CHAIN to OCSP_basic_verify() fcc3a5204c apps: -msg flag enhancement 2/2 50c911b0c5 apps: -msg flag enhancement 1/2 625679b6d7 EVP: NULL pctx pointer after free. Build log ended with (last 100 lines): # Server sent alert unexpected_message but client received no alert. # 80C7EA94297F:error::SSL routines::unexpected message:../openssl/ssl/statem/statem_srvr.c:318: not ok 9 - iteration 9 # -- not ok 1 - test_handshake # -- ../../util/wrap.pl ../../test/ssl_test 25-cipher.cnf.default default => 1 not ok 6 - running ssl_test 25-cipher.cnf # -- # Looks like you failed 2 tests of 9. not ok 26 - Test configuration 25-cipher.cnf # -- # Looks like you failed 1 test of 31.80-test_ssl_new.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/31 subtests 80-test_ssl_old.t .. ok 80-test_ssl_test_ctx.t . ok # INFO: @ ../openssl/test/sslcorrupttest.c:199 # Starting #2, ECDHE-RSA-CHACHA20-POLY1305 # ERROR: (int) 'SSL_get_error(clientssl, 0) == SSL_ERROR_WANT_READ' failed @ ../openssl/test/ssltestlib.c:1032 # [1] compared to [2] # ERROR: (bool) 'create_ssl_connection(server, client, SSL_ERROR_NONE) == true' failed @ ../openssl/test/sslcorrupttest.c:229 # false # 8047E747AA7F:error::SSL routines::unexpected message:../openssl/ssl/statem/statem_clnt.c:403: not ok 3 - iteration 3 # -- # INFO: @ ../openssl/test/sslcorrupttest.c:199 # Starting #3, DHE-RSA-CHACHA20-POLY1305 # ERROR: (int) 'SSL_get_error(clientssl, 0) == SSL_ERROR_WANT_READ' failed @ ../openssl/test/ssltestlib.c:1032 # [1] compared to [2] # ERROR: (bool) 'create_ssl_connection(server, client, SSL_ERROR_NONE) == true' failed @ ../openssl/test/sslcorrupttest.c:229 # false # 8047E747AA7F:error::SSL routines::unexpected message:../openssl/ssl/statem/statem_clnt.c:403: not ok 4 -
Coverity Scan: Analysis completed for openssl/openssl
Your request for analysis of openssl/openssl has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DOlEt_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeEpQTih7hfBfVCWkCof1olJKktB3RzYjONkMqmawQCnrTrmOKF6GddZBOXjaUzAyyb6Y9aylGoFMybF5uZkY239r98NJdad-2B1gEJJVi4BmpjYYGJWQgLeqzqEiCwl0vnNEHYnqhB4RcD8ghvxV0C2Tlhoeis8qcOj8yjaub-2FZnTG238kgm9Ny3P5UGk4mvdp5A-3D Build ID: 336156 Analysis Summary: New defects found: 9 Defects eliminated: 16 If you have difficulty understanding any defects, email us at scan-ad...@coverity.com, or post your question to StackOverflow at https://u15810271.ct.sendgrid.net/ls/click?upn=CTPegkVN6peWFCMEieYYmPWIi1E4yUS9EoqKFcNAiqhRq8qmgeBE-2Bdt3uvFRAFXd-2FlwX83-2FVVdybfzIMOby0qA-3D-3DWjJr_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeEpQTih7hfBfVCWkCof1olJKktB3RzYjONkMqmawQCnrQrsw1-2B5m1j8wO7FP349cUrzaPNKFjUmRbv01NQT-2BSMbuDaMzwJbgfITyKNX-2Ft1wiN3SyOPj0ux4gE5ejI72wWMllVRV5CJWYkXY4i3zKSN9N6KzLrilhLOzeoNNoyctpSkYjKslNqX84sVefgauFt8-3D
Coverity Scan: Analysis completed for OpenSSL-1.0.2
Your request for analysis of OpenSSL-1.0.2 has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7Hlun-2FGpeF2rhqKLKnzox0Gkw-3D-3Dm0Hr_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeEY49mBCUz0tsS-2FkJ5IEp4oDdg8Zzt6LwOCda-2FpwXaZel-2Fz-2FCx1JlkfrXYE7WGKKCETcXfCe1-2BIhOHRi6gtmenKCxJqtiDRoLm-2FutqNSNdSopQqbSOi9dC5ZemlKGcRPz6ltlNDVF0uZqM6Sv3NQ2DKJRSxxPZ80XyI3G-2BisQBKwjZqwYKdJg5za9rwjXhtVmE-3D Build ID: 336157 Analysis Summary: New defects found: 0 Defects eliminated: 0
Build completed: openssl master.36496
Build openssl master.36496 completed Commit 6fbcdce780 by Shane Lontis on 8/30/2020 9:58 AM: Add RSASVE from SP800-56Br2 Configure your notification preferences
Build failed: openssl master.36495
Build openssl master.36495 failed Commit 5a5f4cf9aa by Richard Levitte on 8/30/2020 9:46 AM: EC: Remove one error record that shadows another Configure your notification preferences
Build failed: openssl master.36493
Build openssl master.36493 failed Commit 0557e7cb01 by Richard Levitte on 8/30/2020 7:53 AM: TEST: Ensure that the base provider i activated when needed Configure your notification preferences
Still Failing: openssl/openssl#37031 (master - 458cb85)
Build Update for openssl/openssl - Build: #37031 Status: Still Failing Duration: 1 hr, 22 mins, and 56 secs Commit: 458cb85 (master) Author: Shane Lontis Message: Fix ECX serializer import calls to use correct selection flags. Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/12698) View the changeset: https://github.com/openssl/openssl/compare/835b2900168b...458cb85d1985 View the full build log and details: https://travis-ci.com/github/openssl/openssl/builds/181935154?utm_medium=notification_source=email -- You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.com/account/preferences/unsubscribe?repository=13885459_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.com/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
[openssl] master update
The branch master has been updated via 458cb85d1985aa3efe0a33eb59123d23b5fa975a (commit) via d9cdfda24fd140f3e4c7b4afd9b46a7929841c69 (commit) via 81fca0e7c1f4e874f860ac66415546fe8fc5ad18 (commit) via 3fab56631f597b969bb5849bd890e354d4062178 (commit) from 835b2900168bfd1cc471bf1d798d3b5b7219cd4d (commit) - Log - commit 458cb85d1985aa3efe0a33eb59123d23b5fa975a Author: Shane Lontis Date: Fri Aug 21 11:15:59 2020 +1000 Fix ECX serializer import calls to use correct selection flags. Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/12698) commit d9cdfda24fd140f3e4c7b4afd9b46a7929841c69 Author: Shane Lontis Date: Fri Aug 21 11:15:10 2020 +1000 Fix RSA serializer import calls to use correct selection flags. Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/12698) commit 81fca0e7c1f4e874f860ac66415546fe8fc5ad18 Author: Shane Lontis Date: Fri Aug 21 11:14:34 2020 +1000 Fix DSA serializer import calls to use correct selection flags. Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/12698) commit 3fab56631f597b969bb5849bd890e354d4062178 Author: Shane Lontis Date: Fri Aug 21 11:13:09 2020 +1000 Fix DH serializer import calls to use correct selection flags. Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/12698) --- Summary of changes: providers/implementations/encode_decode/encoder_dh_param.c | 6 +++--- providers/implementations/encode_decode/encoder_dh_priv.c | 9 ++--- providers/implementations/encode_decode/encoder_dh_pub.c| 9 ++--- providers/implementations/encode_decode/encoder_dsa_param.c | 6 +++--- providers/implementations/encode_decode/encoder_dsa_priv.c | 9 ++--- providers/implementations/encode_decode/encoder_dsa_pub.c | 10 ++ providers/implementations/encode_decode/encoder_ecx_pub.c | 6 +++--- providers/implementations/encode_decode/encoder_rsa_priv.c | 9 ++--- providers/implementations/encode_decode/encoder_rsa_pub.c | 9 ++--- 9 files changed, 45 insertions(+), 28 deletions(-) diff --git a/providers/implementations/encode_decode/encoder_dh_param.c b/providers/implementations/encode_decode/encoder_dh_param.c index 23cda024c4..32c8769b5e 100644 --- a/providers/implementations/encode_decode/encoder_dh_param.c +++ b/providers/implementations/encode_decode/encoder_dh_param.c @@ -63,7 +63,7 @@ static int dh_param_der_data(void *ctx, const OSSL_PARAM params[], /* ctx == provctx */ if ((dh = dh_new(ctx)) != NULL -&& dh_import(dh, OSSL_KEYMGMT_SELECT_ALL_PARAMETERS, params) +&& dh_import(dh, OSSL_KEYMGMT_SELECT_DOMAIN_PARAMETERS, params) && dh_param_der(ctx, dh, out, cb, cbarg)) ok = 1; dh_free(dh); @@ -100,7 +100,7 @@ static int dh_param_pem_data(void *ctx, const OSSL_PARAM params[], /* ctx == provctx */ if ((dh = dh_new(ctx)) != NULL -&& dh_import(dh, OSSL_KEYMGMT_SELECT_ALL_PARAMETERS, params) +&& dh_import(dh, OSSL_KEYMGMT_SELECT_DOMAIN_PARAMETERS, params) && dh_param_pem(ctx, dh, out, cb, cbarg)) ok = 1; dh_free(dh); @@ -137,7 +137,7 @@ static int dh_param_print_data(void *ctx, const OSSL_PARAM params[], /* ctx == provctx */ if ((dh = dh_new(ctx)) != NULL -&& dh_import(dh, OSSL_KEYMGMT_SELECT_ALL_PARAMETERS, params) +&& dh_import(dh, OSSL_KEYMGMT_SELECT_DOMAIN_PARAMETERS, params) && dh_param_print(ctx, dh, out, cb, cbarg)) ok = 1; dh_free(dh); diff --git a/providers/implementations/encode_decode/encoder_dh_priv.c b/providers/implementations/encode_decode/encoder_dh_priv.c index a9373df96a..dd94223084 100644 --- a/providers/implementations/encode_decode/encoder_dh_priv.c +++ b/providers/implementations/encode_decode/encoder_dh_priv.c @@ -25,6 +25,9 @@ #include "prov/provider_ctx.h" #include "encoder_local.h" +#define DH_SELECT_PRIVATE_IMPORTABLE \ +(OSSL_KEYMGMT_SELECT_KEYPAIR | OSSL_KEYMGMT_SELECT_DOMAIN_PARAMETERS) + static OSSL_FUNC_encoder_newctx_fn dh_priv_newctx; static OSSL_FUNC_encoder_freectx_fn dh_priv_freectx; static OSSL_FUNC_encoder_set_ctx_params_fn dh_priv_set_ctx_params; @@ -132,7 +135,7 @@ static int dh_priv_der_data(void *vctx, const OSSL_PARAM params[], DH *dh; if ((dh = dh_new(ctx->provctx)) != NULL -&& dh_import(dh, OSSL_KEYMGMT_SELECT_KEYPAIR, params) +&& dh_import(dh, DH_SELECT_PRIVATE_IMPORTABLE, params) && dh_priv_der(ctx, dh, out, cb, cbarg)) ok = 1; dh_free(dh); @@