Coverity Scan: Analysis completed for openssl/openssl

2022-07-20 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DIx7h_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeGAbdmswjPaKH8y3zbUuP0ySUm073x-2BL-2FmpNwoe4InyoXg1VRrPgfeMLgoon7fVwjE2meZRXMFqzGyDYuS-2FRkMBuf8BdbaCf0PJN-2FmnYZ6o2CWGLPc292z3lfP3BB6GkIFjnGHhGhcGhA-2Bay5ueqth7g-2BpTPDKD-2BdtEODHi-2FtCnNxlEcqMmpU4zrAewJFY2ULk-3D

Build ID: 468808

Analysis Summary:
   New defects found: 1
   Defects eliminated: 4

If you have difficulty understanding any defects, email us at 
scan-ad...@coverity.com,
or post your question to StackOverflow
at 
https://u15810271.ct.sendgrid.net/ls/click?upn=CTPegkVN6peWFCMEieYYmPWIi1E4yUS9EoqKFcNAiqhRq8qmgeBE-2Bdt3uvFRAFXd-2FlwX83-2FVVdybfzIMOby0qA-3D-3DS1JZ_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeGAbdmswjPaKH8y3zbUuP0ySUm073x-2BL-2FmpNwoe4InyoarbZhNFDMwGdvUvzYxawgN5niopXR01cqjpr9zwSf8i0qtbAIjEoP9v-2B2gZeLMAD7M-2FlFbMNkjOMiTwyv6DP8sgEW10wI-2BwYifCwdildiLuYKhPvKpMQtr81RpujVvmmdsKd2mhiEp6-2BBfu-2B4Z-2BUgA-3D


[openssl/openssl] fce3db: check-format.pl: Fix report on constant on LHS of ...

2022-07-20 Thread David von Oheimb
  Branch: refs/heads/openssl-3.0
  Home:   https://github.openssl.org/openssl/openssl
  Commit: fce3dbc0389b4021c9dba205ac8ef25c6786da93
  
https://github.openssl.org/openssl/openssl/commit/fce3dbc0389b4021c9dba205ac8ef25c6786da93
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: Fix report on constant on LHS of comparison or assignment

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(cherry picked from commit 2e6afe1079c6993868c5d8a813605d16980e8e10)


  Commit: 45fb04218b46902752763eb4bc47f9b077d139a5
  
https://github.openssl.org/openssl/openssl/commit/45fb04218b46902752763eb4bc47f9b077d139a5
  Author: Dimitris Apostolou 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format.pl

  Log Message:
  ---
  check_format.pl: Fix typos

Reviewed-by: Tim Hudson 
Reviewed-by: Tomas Mraz 
(cherry picked from commit e304aa87b35fac5ea97c405dd3c21549faa45e78)


  Commit: ac2a419e5175dc3c70ab7c85dd6d41bf5d870de3
  
https://github.openssl.org/openssl/openssl/commit/ac2a419e5175dc3c70ab7c85dd6d41bf5d870de3
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format-test-negatives.c
M util/check-format-test-positives.c
M util/check-format.pl

  Log Message:
  ---
  check_format.pl: Add checks for blank lines within/after local decls

Reviewed-by: Paul Dale 
(cherry picked from commit d8662f2f8716645164a9d4d8795a9c353fe315fb)


  Commit: f5650553da65af29c406edaab0fdbe688935f75f
  
https://github.openssl.org/openssl/openssl/commit/f5650553da65af29c406edaab0fdbe688935f75f
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format-test-negatives.c
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: Fix report on constant on LHS of comparison/assignment

Reviewed-by: Paul Dale 
(cherry picked from commit 15ae69fa7bc0f367edded19bc48e6d9a5ce8d547)


  Commit: e7abe53a19f571a06008ec8abe31cb6e1c074286
  
https://github.openssl.org/openssl/openssl/commit/e7abe53a19f571a06008ec8abe31cb6e1c074286
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format-test-negatives.c
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: Fix report on missing space before +/-: allow, e.g., '1e-6'

Reviewed-by: Paul Dale 
(cherry picked from commit d45c0e1a5e89f01d83f6059c788524e901a11604)


  Commit: 18b1d210c0a2e7a0b95d43088d3e922d47972b37
  
https://github.openssl.org/openssl/openssl/commit/18b1d210c0a2e7a0b95d43088d3e922d47972b37
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format-test-negatives.c
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: Fix report on space before ';' and allow it after ')'

Reviewed-by: Paul Dale 
(cherry picked from commit c30bc4e2093f47a37736944da548653bc08d774d)


  Commit: c4e65dc8a83118e27f27238c846fdffc5e7bb41f
  
https://github.openssl.org/openssl/openssl/commit/c4e65dc8a83118e27f27238c846fdffc5e7bb41f
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: improve wording: 'no' -> 'missing'; further minor 
improvements

Reviewed-by: Richard Levitte 
Reviewed-by: Paul Dale 
Reviewed-by: Hugo Landau 
(cherry picked from commit 63263147a3ad55cb26d7cfcdfca474ce324a15ac)


  Commit: 03421456b3eb745b8cdd908a3fcd3014132adf5b
  
https://github.openssl.org/openssl/openssl/commit/03421456b3eb745b8cdd908a3fcd3014132adf5b
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format-test-negatives.c
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: fix false positive on 'for(;; stmt)'

Reviewed-by: Richard Levitte 
Reviewed-by: Paul Dale 
Reviewed-by: Hugo Landau 
(cherry picked from commit 4e9fa07121abf3ebaaf7e0367bd9be3a8b273ebf)


  Commit: 54e38d82edef757c098341f0ef0f9e8fed6f6945
  
https://github.openssl.org/openssl/openssl/commit/54e38d82edef757c098341f0ef0f9e8fed6f6945
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format-test-negatives.c
M util/check-format-test-positives.c
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: fix detection of missing/extra blank lines in local decls

Reviewed-by: Richard Levitte 
Reviewed-by: Paul Dale 
Reviewed-by: Hugo Landau 
(cherry picked from commit 23757b61d49ac3e46440dc34e56b83201106e440)


Compare: 
https://github.openssl.org/openssl/openssl/compare/cc90ba66062a...54e38d82edef


[openssl/web] 239296: Convert all source/*.html to .md

2022-07-20 Thread Richard Levitte
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/web
  Commit: 239296da4d2d17929d7b5285b749cdeef3e44ad6
  
https://github.openssl.org/openssl/web/commit/239296da4d2d17929d7b5285b749cdeef3e44ad6
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M .gitignore
M Makefile
A source/dirdata.yaml
R source/gitrepo.html
A source/gitrepo.md
R source/index.html
A source/index.md
R source/license.html
A source/license.md
R source/mirror.html
A source/mirror.md
R source/sidebar.shtml

  Log Message:
  ---
  Convert all source/*.html to .md

Partial fix of #324

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/web/pull/349)


  Commit: fe6c01f3d893a28ccadd090f3908fe11b7dd6d3f
  
https://github.openssl.org/openssl/web/commit/fe6c01f3d893a28ccadd090f3908fe11b7dd6d3f
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M .gitignore
M Makefile
A source/old/dirdata.yaml
R source/old/index.html.tt
A source/old/index.md.tt
A source/old/sub-dirdata.yaml.tt
R source/old/sub-index.html.tt
A source/old/sub-index.md.tt

  Log Message:
  ---
  Convert all source/old/*.html to .md

Partial fix of #324

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/web/pull/349)


  Commit: a18e42645868ebce68957fc86cdcafe613016931
  
https://github.openssl.org/openssl/web/commit/a18e42645868ebce68957fc86cdcafe613016931
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M Makefile

  Log Message:
  ---
  $(SRCLISTS) isn't phony!

This was probably around because we used this variable to list tarballs.
Things have changed since, and making the contents of this variable phony
is now in error.

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/web/pull/349)


Compare: 
https://github.openssl.org/openssl/web/compare/e0824ffd90af...a18e42645868


[openssl/web] 9d6ac3: Convert docs/*.html to .md

2022-07-20 Thread Richard Levitte
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/web
  Commit: 9d6ac3f1db833a495df684429215e31c76c8ea4e
  
https://github.openssl.org/openssl/web/commit/9d6ac3f1db833a495df684429215e31c76c8ea4e
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M .gitignore
M Makefile
M bin/mk-faq
A docs/dirdata.yaml
R docs/faq.html
A docs/faq.md
R docs/fips.html
A docs/fips.md
A docs/fips/dirdata.yaml
R docs/fips/privatelabel.html
A docs/fips/privatelabel.md
R docs/fips/verifycd.html
A docs/fips/verifycd.md
R docs/index.html
A docs/index.md
R docs/manpages.html.tt
A docs/manpages.md.tt
R docs/sidebar.shtml

  Log Message:
  ---
  Convert docs/*.html to .md

We only take the easy parts, and leave manual page generation files alone.

Partial fix of #324

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/web/pull/345)


  Commit: 964dd4386ddb005b1dc52eb197ac53f4686041b2
  
https://github.openssl.org/openssl/web/commit/964dd4386ddb005b1dc52eb197ac53f4686041b2
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M Makefile
R docs/mansidebar.html.tt
A docs/sub-dirdata.yaml.tt
R docs/sub-index.html.tt
A docs/sub-index.md.tt
R docs/sub-man1-index.html.tt
A docs/sub-man1-index.md.tt
R docs/sub-man3-index.html.tt
A docs/sub-man3-index.md.tt
R docs/sub-man5-index.html.tt
A docs/sub-man5-index.md.tt
R docs/sub-man7-index.html.tt
A docs/sub-man7-index.md.tt

  Log Message:
  ---
  Convert docs/sub-*.html.tt to .md.tt

This removes docs/mansidebar.html.tt, which is essentially replaced
by docs/sub-dirdata.yaml.tt

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/web/pull/345)


  Commit: 18aaf09b6e2dc3b4e1194d561059cec9a2339155
  
https://github.openssl.org/openssl/web/commit/18aaf09b6e2dc3b4e1194d561059cec9a2339155
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M bin/from-tt

  Log Message:
  ---
  bin/from-tt: Correct bugs for determining [% top %]

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/web/pull/345)


  Commit: e0824ffd90afab8425e01c90594c03b13d9d9975
  
https://github.openssl.org/openssl/web/commit/e0824ffd90afab8425e01c90594c03b13d9d9975
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M Makefile

  Log Message:
  ---
  Bugfix: make knows $(dir ...), not $(dirname ...)

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/web/pull/345)


Compare: 
https://github.openssl.org/openssl/web/compare/f4fafd9051fd...e0824ffd90af


[openssl/openssl] b6fbef: Add OSSL_CMP_CTX_get0_validatedSrvCert(), correcti...

2022-07-20 Thread David von Oheimb
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/openssl
  Commit: b6fbef1159c9aeb1590c116a9426e169d2203506
  
https://github.openssl.org/openssl/openssl/commit/b6fbef1159c9aeb1590c116a9426e169d2203506
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M apps/cmp.c
M crypto/cmp/cmp_ctx.c
M crypto/cmp/cmp_local.h
M crypto/cmp/cmp_vfy.c
M doc/man1/openssl-cmp.pod.in
M doc/man3/OSSL_CMP_CTX_new.pod
M include/openssl/cmp.h.in
M test/cmp_ctx_test.c
M test/cmp_vfy_test.c
M util/libcrypto.num

  Log Message:
  ---
  Add OSSL_CMP_CTX_get0_validatedSrvCert(), correcting OSSL_CMP_validate_msg()

Also change ossl_cmp_ctx_set0_validatedSrvCert() to 
ossl_cmp_ctx_set1_validatedSrvCert(),
and add respective tests as well as the -srvcertout CLI option using the new 
function.

Reviewed-by: Dmitry Belyavskiy 
Reviewed-by: Tomas Mraz 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/18656)




[openssl/web] f4fafd: Correct case as asked

2022-07-20 Thread mark
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/web
  Commit: f4fafd9051fdf260c3b9ed40d010ddd09c0bb930
  
https://github.openssl.org/openssl/web/commit/f4fafd9051fdf260c3b9ed40d010ddd09c0bb930
  Author: Mark J. Cox 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M support/acks.md

  Log Message:
  ---
  Correct case as asked




[openssl/web] 97e829: Add Bronze sponsor Sakura Internet, remove Bronze ...

2022-07-20 Thread mark
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/web
  Commit: 97e8292ed30df9678c3ff3d8958eaa7a7efa0dda
  
https://github.openssl.org/openssl/web/commit/97e8292ed30df9678c3ff3d8958eaa7a7efa0dda
  Author: Mark J. Cox 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M support/acks.md

  Log Message:
  ---
  Add Bronze sponsor Sakura Internet, remove Bronze sponsor Jameson Lopp




[openssl/web] 5c1df8: Add a README as a guide how to write markdown page...

2022-07-20 Thread Richard Levitte
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/web
  Commit: 5c1df85cad5d26b4b6e05ad791ab2ec5df4535b5
  
https://github.openssl.org/openssl/web/commit/5c1df85cad5d26b4b6e05ad791ab2ec5df4535b5
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
A README.md

  Log Message:
  ---
  Add a README as a guide how to write markdown pages, and how to build

Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/web/pull/351)




[openssl/openssl] 86945b: Fix verify_callback in the openssl s_client/s_serv...

2022-07-20 Thread beldmit
  Branch: refs/heads/OpenSSL_1_1_1-stable
  Home:   https://github.openssl.org/openssl/openssl
  Commit: 86945b10ccd84f685bd6215bbb00d1e700303e49
  
https://github.openssl.org/openssl/openssl/commit/86945b10ccd84f685bd6215bbb00d1e700303e49
  Author: Dmitry Belyavskiy 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M apps/s_cb.c

  Log Message:
  ---
  Fix verify_callback in the openssl s_client/s_server app

We need to check that error cert is available before printing its data

Reviewed-by: Tomas Mraz 
Reviewed-by: David von Oheimb 
Reviewed-by: Viktor Dukhovni 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18805)

(cherry picked from commit fad0f80eff188ef938fed614245a56ed56110deb)




[openssl/openssl] cc90ba: Fix verify_callback in the openssl s_client/s_serv...

2022-07-20 Thread beldmit
  Branch: refs/heads/openssl-3.0
  Home:   https://github.openssl.org/openssl/openssl
  Commit: cc90ba66062afc27e31e403613711dba5a7475a8
  
https://github.openssl.org/openssl/openssl/commit/cc90ba66062afc27e31e403613711dba5a7475a8
  Author: Dmitry Belyavskiy 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M apps/lib/s_cb.c

  Log Message:
  ---
  Fix verify_callback in the openssl s_client/s_server app

We need to check that error cert is available before printing its data

Reviewed-by: Tomas Mraz 
Reviewed-by: David von Oheimb 
Reviewed-by: Viktor Dukhovni 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18805)

(cherry picked from commit fad0f80eff188ef938fed614245a56ed56110deb)




[openssl/openssl] fad0f8: Fix verify_callback in the openssl s_client/s_serv...

2022-07-20 Thread beldmit
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/openssl
  Commit: fad0f80eff188ef938fed614245a56ed56110deb
  
https://github.openssl.org/openssl/openssl/commit/fad0f80eff188ef938fed614245a56ed56110deb
  Author: Dmitry Belyavskiy 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M apps/lib/s_cb.c

  Log Message:
  ---
  Fix verify_callback in the openssl s_client/s_server app

We need to check that error cert is available before printing its data

Reviewed-by: Tomas Mraz 
Reviewed-by: David von Oheimb 
Reviewed-by: Viktor Dukhovni 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18805)




[openssl/openssl] 632631: check-format.pl: improve wording: 'no' -> 'missing...

2022-07-20 Thread David von Oheimb
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/openssl
  Commit: 63263147a3ad55cb26d7cfcdfca474ce324a15ac
  
https://github.openssl.org/openssl/openssl/commit/63263147a3ad55cb26d7cfcdfca474ce324a15ac
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: improve wording: 'no' -> 'missing'; further minor 
improvements

Reviewed-by: Richard Levitte 
Reviewed-by: Paul Dale 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18789)


  Commit: 4e9fa07121abf3ebaaf7e0367bd9be3a8b273ebf
  
https://github.openssl.org/openssl/openssl/commit/4e9fa07121abf3ebaaf7e0367bd9be3a8b273ebf
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format-test-negatives.c
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: fix false positive on 'for(;; stmt)'

Reviewed-by: Richard Levitte 
Reviewed-by: Paul Dale 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18789)


  Commit: 23757b61d49ac3e46440dc34e56b83201106e440
  
https://github.openssl.org/openssl/openssl/commit/23757b61d49ac3e46440dc34e56b83201106e440
  Author: Dr. David von Oheimb 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M util/check-format-test-negatives.c
M util/check-format-test-positives.c
M util/check-format.pl

  Log Message:
  ---
  check-format.pl: fix detection of missing/extra blank lines in local decls

Reviewed-by: Richard Levitte 
Reviewed-by: Paul Dale 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18789)


Compare: 
https://github.openssl.org/openssl/openssl/compare/e1eafe8c8761...23757b61d49a


[openssl/openssl] ddb81a: "Reserve" the method store when constructing methods

2022-07-20 Thread Richard Levitte
  Branch: refs/heads/openssl-3.0
  Home:   https://github.openssl.org/openssl/openssl
  Commit: ddb81a94ac8af145750940c20999ac952165bf10
  
https://github.openssl.org/openssl/openssl/commit/ddb81a94ac8af145750940c20999ac952165bf10
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M crypto/core_algorithm.c
M crypto/core_fetch.c
M crypto/encode_decode/decoder_meth.c
M crypto/encode_decode/encoder_meth.c
M crypto/evp/evp_fetch.c
M crypto/property/property.c
M crypto/store/store_meth.c
M include/internal/core.h
M include/internal/property.h

  Log Message:
  ---
  "Reserve" the method store when constructing methods

Introducing the concept of reserving the store where a number of
provided operation methods are to be stored.

This avoids racing when constructing provided methods, which is
especially pertinent when multiple threads are trying to fetch the
same method, or even any implementation for the same given operation
type.

This introduces a |biglock| in OSSL_METHOD_STORE, which is separate
from the |lock| which is used for more internal and finer grained
locking.

Fixes #18152

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/18153)

(cherry picked from commit e1eafe8c87612a94552e9ad5df56c489cb6f0ff2)




[openssl/openssl] e1eafe: "Reserve" the method store when constructing methods

2022-07-20 Thread Richard Levitte
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/openssl
  Commit: e1eafe8c87612a94552e9ad5df56c489cb6f0ff2
  
https://github.openssl.org/openssl/openssl/commit/e1eafe8c87612a94552e9ad5df56c489cb6f0ff2
  Author: Richard Levitte 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M crypto/core_algorithm.c
M crypto/core_fetch.c
M crypto/encode_decode/decoder_meth.c
M crypto/encode_decode/encoder_meth.c
M crypto/evp/evp_fetch.c
M crypto/property/property.c
M crypto/store/store_meth.c
M include/internal/core.h
M include/internal/property.h

  Log Message:
  ---
  "Reserve" the method store when constructing methods

Introducing the concept of reserving the store where a number of
provided operation methods are to be stored.

This avoids racing when constructing provided methods, which is
especially pertinent when multiple threads are trying to fetch the
same method, or even any implementation for the same given operation
type.

This introduces a |biglock| in OSSL_METHOD_STORE, which is separate
from the |lock| which is used for more internal and finer grained
locking.

Fixes #18152

Reviewed-by: Hugo Landau 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/18153)




[openssl/openssl] 3cfc2a: Coverity 1503321 & 1503327: dereference after null...

2022-07-20 Thread pauli
  Branch: refs/heads/openssl-3.0
  Home:   https://github.openssl.org/openssl/openssl
  Commit: 3cfc2a967a4a5313f141ae433b833f3c6c9a5643
  
https://github.openssl.org/openssl/openssl/commit/3cfc2a967a4a5313f141ae433b833f3c6c9a5643
  Author: Pauli 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M crypto/provider_core.c

  Log Message:
  ---
  Coverity 1503321 & 1503327: dereference after null check

The earlier fix being inadequate

Reviewed-by: Tomas Mraz 
Reviewed-by: Dmitry Belyavskiy 
(Merged from https://github.com/openssl/openssl/pull/18822)

(cherry picked from commit f913c3cd7e22eecbcc8f84b72c645081fa37fdf4)


  Commit: d3cc10eb0ee31a3950bb310c8201614fb076f759
  
https://github.openssl.org/openssl/openssl/commit/d3cc10eb0ee31a3950bb310c8201614fb076f759
  Author: Pauli 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M test/evp_extra_test2.c

  Log Message:
  ---
  Coverity 1507372: explicit null dereference

Reviewed-by: Tomas Mraz 
Reviewed-by: Dmitry Belyavskiy 
(Merged from https://github.com/openssl/openssl/pull/18822)

(cherry picked from commit d768f853bb05b5a49a2aeb5b5702776834e68d06)


Compare: 
https://github.openssl.org/openssl/openssl/compare/3f348a0f6c31...d3cc10eb0ee3


[openssl/openssl] f913c3: Coverity 1503321 & 1503327: dereference after null...

2022-07-20 Thread pauli
  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/openssl
  Commit: f913c3cd7e22eecbcc8f84b72c645081fa37fdf4
  
https://github.openssl.org/openssl/openssl/commit/f913c3cd7e22eecbcc8f84b72c645081fa37fdf4
  Author: Pauli 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M crypto/provider_core.c

  Log Message:
  ---
  Coverity 1503321 & 1503327: dereference after null check

The earlier fix being inadequate

Reviewed-by: Tomas Mraz 
Reviewed-by: Dmitry Belyavskiy 
(Merged from https://github.com/openssl/openssl/pull/18822)


  Commit: d768f853bb05b5a49a2aeb5b5702776834e68d06
  
https://github.openssl.org/openssl/openssl/commit/d768f853bb05b5a49a2aeb5b5702776834e68d06
  Author: Pauli 
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
M test/evp_extra_test2.c

  Log Message:
  ---
  Coverity 1507372: explicit null dereference

Reviewed-by: Tomas Mraz 
Reviewed-by: Dmitry Belyavskiy 
(Merged from https://github.com/openssl/openssl/pull/18822)


Compare: 
https://github.openssl.org/openssl/openssl/compare/1efd8533e1cc...d768f853bb05