"Doug Kaufman" <[EMAIL PROTECTED]> said:

> In crypto/bio/bss_file.c, you change the way that binary or text is
> chosen, and allow binary only if not going to stdout or or from stdin. I
> think that the usual way to handle this (at least under DJGPP) is to use
> "isatty", and not allow binary if isatty returns a nonzero result.

Good point, I'll revise the patch.

> Otherwise you may be interfering with redirected binary data. It might
> be more generalizable if you used "fileno(stdout)" rather than
> specifying "1" in the "else if" line, but I don't know of a system where
> the file numbers are different.

Those values (0 and 1) comes from the core of DOS/Windows and should 
never change. If they did fprintf (stdout) wouldn't work since stdout/stderr 
are normally indices into the __iob array.

--gv

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to