QA bug - unreachable code ./apps/s_server.c with -crl_check

2008-05-17 Thread Daniel Black
just came across this while attempting to work out how to do crl checking. from yesterdays openssl snapshot. I assume the second branch is unreachable. ./apps/s_server.c line 308 else if (strcmp(*argv,"-crl_check") == 0) { vflags |=

RE: valgrind and openssl

2008-05-17 Thread David Schwartz
> > If feeding predictable data into a PRNG that was already well > > seeded with > > unpredictable data produced a weaker PRNG, then you have found > > a security bug > > in the PRNG and I suggest you publish. > Yeah, I've heard that a few times. However, consider the > pathological case, > in

Re: valgrind and openssl

2008-05-17 Thread Thor Lancelot Simon
On Fri, May 16, 2008 at 11:24:45AM -0400, Geoff Thorpe wrote: > On Friday 16 May 2008 00:47:52 Thor Lancelot Simon wrote: > > On Thu, May 15, 2008 at 11:45:14PM +0200, Bodo Moeller wrote: > > > It may be zero, but it may be more, depending on what happened earlier > > > in the program if the same m

RE: valgrind and openssl

2008-05-17 Thread David Schwartz
> Unfortunately, it may also very well include data that would be > highly predictable to adversaries. That doesn't matter. > I am aware that this is an area without a lot of good theoretical > signposts, but I am just not very comfortable feeding arbitrary > amounts of possibly-known data into