heartbeat RFC 6520 and silently drop behaviour

2014-04-13 Thread tolga ceylan
The RFC has a lot of statements about silently dropping packets in case of various anomalies. But the correct action should be to drop the connection. This would uncover faulty implementations and other bugs that may slide due to 'silently drop' behavior. It'll also make malicious activity a bit

Unit/Regression test for Heartbleed bug

2014-04-13 Thread Mike Bland
I've prepared a proof-of-concept unit/regression test for the Heartbleed bug that I've posted at: http://goo.gl/wTYD9K If folks are interested, I can prepare an official patch to add it to OpenSSL. Thanks, Mike mbl...@acm.org

[openssl.org #3303] [PATCH] doc: fix forgot a '=back' before '=head1' error

2014-04-13 Thread Ben Noordhuis via RT
Add the =back that was making pod2man abort. Fixes the `make install` target, it was failing at the install_docs sub-target. --- doc/ssl/SSL_CONF_cmd.pod | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/ssl/SSL_CONF_cmd.pod b/doc/ssl/SSL_CONF_cmd.pod index bbda10a..552d4a8 100644 ---

[openssl.org #3304] [PATCH] typo in SSL_get_peer_cert_chain docs

2014-04-13 Thread Jeff Trawick via RT
STACKOF - STACK_OF See attachment... -- Born in Roswell... married an alien... http://emptyhammock.com/ http://edjective.org/ diff --git a/doc/ssl/SSL_get_peer_cert_chain.pod b/doc/ssl/SSL_get_peer_cert_chain.pod index 49fb88f..059376c 100644 --- a/doc/ssl/SSL_get_peer_cert_chain.pod +++

Re: [openssl.org #3303] [PATCH] doc: fix forgot a '=back' before '=head1' error

2014-04-13 Thread Kurt Roeckx via RT
That's also in github pull request #50 Kurt On Sun, Apr 13, 2014 at 12:20:37PM +0200, Ben Noordhuis via RT wrote: Add the =back that was making pod2man abort. Fixes the `make install` target, it was failing at the install_docs sub-target. --- doc/ssl/SSL_CONF_cmd.pod | 2 ++ 1 file

Re: heartbeat RFC 6520 and silently drop behaviour

2014-04-13 Thread Michael Tuexen
On 13 Apr 2014, at 01:54, tolga ceylan tolga.cey...@gmail.com wrote: The RFC has a lot of statements about silently dropping packets in case of various anomalies. But the correct action should be to drop the connection. This would uncover faulty implementations and other bugs that may

Re: Unit/Regression test for Heartbleed bug

2014-04-13 Thread Peter Dettman
Hi Mike, I downloaded the test and successfully ran it in my local build. Two changes were required (Ubuntu 13.04. gcc 4.8.1) to satisfy the compiler: - At line 170, move the declaration of int i outside the 'for' - Replace strlcpy (undefined) with a memcpy, although there may be