[openssl.org #3439]

2014-07-08 Thread Neitrino Photonov via RT
if ((a-method == NULL) || (a-method-destroy == NULL)) return(1); 136 a-method-destroy(a); 137 OPENSSL_free(a); 138 return(1); if haven't method destroy memory for a is never free. should write like this 135 if ((a-method == NULL) || (a-method-destroy ==

Re: [openssl.org #3439]

2014-07-08 Thread Viktor Dukhovni
On Tue, Jul 08, 2014 at 08:03:39AM +0200, Neitrino Photonov via RT wrote: if haven't method destroy memory for a is never free. diff --git a/crypto/bio/bio_lib.c b/crypto/bio/bio_lib.c index 9c9646a..d6950ad 100644 --- a/crypto/bio/bio_lib.c +++ b/crypto/bio/bio_lib.c @@ -132,8 +132,8 @@ int

[openssl.org #3440] show real GOST algorithm names instead of unknown

2014-07-08 Thread Support via RT
Hi, I noticed that while debugging some issues with GOST it was very practical to see the name of the 'real' algorithms being used instead of the string unknown. Currently the file ssl/ssl_ciph.c checks if an key exchange / authentication / encryption / digital signature algorithm is known, and

[openssl.org #3441] bug report - RAND_cleanup in apps_shutdown problem

2014-07-08 Thread valentin radulescu via RT
Hi, I want to report an issue : Calling RAND_cleanup in apps_shutdown makes SSL implementation not working for Thread Based Operating Systems. RAND_cleanup makes SSL work only in Operating Systems that have support for processes. Best regards, Valentin Radulescu

Re: [openssl.org #3441] bug report - RAND_cleanup in apps_shutdown problem

2014-07-08 Thread Kurt Roeckx via RT
On Tue, Jul 08, 2014 at 06:18:33PM +0200, valentin radulescu via RT wrote: Hi, I want to report an issue : Calling RAND_cleanup in apps_shutdown makes SSL implementation not working for Thread Based Operating Systems. RAND_cleanup makes SSL work only in Operating Systems that have support

Re: [openssl.org #2151] MGF1 not exported in 1.0.0

2014-07-08 Thread Kenneth Goldman via RT
openssl 1.0.1c rsa_oaep.c: line 31 static int MGF1(unsigned char *mask, long len, const unsigned char *seed, long seedlen); I know openssl doesn't guarantee portability, but this broke my application and forced me to reimplement MGF1. -- Ken Goldman kgold...@us.ibm.com 914-945-2415

Re: [openssl.org #3424] Misaligned pointers for buffers cast to a size_t*

2014-07-08 Thread Andy Polyakov via RT
As for warning. I personally would argue that we are looking at platform-specific i.e. implementation-defined behaviour, not undefined. Once again, this applies to all three tickets. One is effectively identical to this one, second is about variable shift in CAST. As mentioned they all are

crypto/ui/ui_lib.c

2014-07-08 Thread dcruette
Hello Seems to be a typo error in crypto/ui/ui_lib.c:919 Present in openssl-SNAP-20140703 Compilation is Ok but switch/case/default structure error This portion case UIT_BOOLEAN: { const char *p; if (!uis-result_buf)

Re: [openssl.org #3424] Misaligned pointers for buffers cast to a size_t*

2014-07-08 Thread noloa...@gmail.com via RT
On Tue, Jul 8, 2014 at 4:33 PM, Andy Polyakov via RT r...@openssl.org wrote: As for warning. I personally would argue that we are looking at platform-specific i.e. implementation-defined behaviour, not undefined. Once again, this applies to all three tickets. One is effectively identical to

Re: [openssl.org #3424] Misaligned pointers for buffers cast to a size_t*

2014-07-08 Thread Andy Polyakov via RT
... if you compile with -fsanitize, you should also add -DPEDANTIC. http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=021e5043e524b1cb28a929ef902548a987c16e65 As mentioned this applies to tickets #3422-4. Looks good to me. Self tests were fine with -DPEDANTIC. Andy - where

Re: [openssl.org #3424] Misaligned pointers for buffers cast to a size_t*

2014-07-08 Thread Jeffrey Walton
On Tue, Jul 8, 2014 at 4:33 PM, Andy Polyakov via RT r...@openssl.org wrote: As for warning. I personally would argue that we are looking at platform-specific i.e. implementation-defined behaviour, not undefined. Once again, this applies to all three tickets. One is effectively identical to

[openssl.org #3441]

2014-07-08 Thread valentin radulescu via RT
Hi, In Operating Systems that are thread based, in which all threads share the same memory address space, in case of multiple connections, calling apps_shutdown by one connection will cause the reset of static variables state and md in md_rand.c for all connections. Best regards, Valentin

Re: [openssl.org #3441]

2014-07-08 Thread Kurt Roeckx via RT
On Wed, Jul 09, 2014 at 12:36:45AM +0200, valentin radulescu via RT wrote: Hi, In Operating Systems that are thread based, in which all threads share the same memory address space, in case of multiple connections, calling apps_shutdown by one connection will cause the reset of static