Re: Subject: [PATCH] ssl: introduce async sign/decrypt APIs This patch is introducing `async_key_ex_cb` member of both `SSL_CTX` and `SSL`, and `SSL_supply()`. If `async_key_ex_cb` is present: * Serve

2014-08-28 Thread Fedor Indutny
Hello again! Here is a second patch that improves the first one. Additionally it copies and restores the packet data before/after calling out async callback. However it is almost evident for me that nothing could overwrite `s-init_buf-data` during async handshake, so if you feel confident about

RE: [openssl.org #3470] [BUG] DTLS abort

2014-08-28 Thread Brian Hassink
Thanks, we're rolling a new build with it now... -Brian -Original Message- From: Michael Tüxen via RT [mailto:r...@openssl.org] Sent: Wednesday, August 27, 2014 3:33 PM To: Brian Hassink Cc: openssl-dev@openssl.org Subject: Re: [openssl.org #3470] [BUG] DTLS abort On 18 Aug 2014, at

[openssl.org #3507] [PATCH] Fix memory leaks.

2014-08-28 Thread Kurt Cancemi via RT
Hello, The attached patch fixes some memory leaks that were found via Coverity. --- Kurt Cancemi https://www.x64architecture.com From 3d2c713113545255b61efe433e130078d4cf2e22 Mon Sep 17 00:00:00 2001 From: Kurt Cancemi k...@x64architecture.com Date: Wed, 27 Aug 2014 20:21:33 -0400 Subject:

Re: [openssl.org #3507] [PATCH] Fix memory leaks.

2014-08-28 Thread Kurt Cancemi via RT
The attached updated patch fixes a style error. --- Kurt Cancemi https://www.x64architecture.com From d112c3f7b36a60f8af109b90fe5299f7ac049cc6 Mon Sep 17 00:00:00 2001 From: Kurt Cancemi k...@x64architecture.com Date: Wed, 27 Aug 2014 20:37:45 -0400 Subject: [PATCH] Fix memory leaks. ---

RE: [openssl.org #3470] [BUG] DTLS abort

2014-08-28 Thread Brian Hassink via RT
Hello Michael, We can confirm that the patch resolves the disconnect abort. Thanks, Brian -Original Message- From: Michael Tüxen via RT [mailto:r...@openssl.org] Sent: Wednesday, August 27, 2014 3:33 PM To: Brian Hassink Cc: openssl-dev@openssl.org Subject: Re: [openssl.org #3470]

Re: [openssl.org #3470] [BUG] DTLS abort

2014-08-28 Thread Michael Tuexen
On 28 Aug 2014, at 17:25, Brian Hassink via RT r...@openssl.org wrote: Hello Michael, We can confirm that the patch resolves the disconnect abort. Great, thanks a lot for the feedback. Let me know if you have further issues with DTLS/SCTP. Best regards Michael Thanks, Brian

Re: [openssl.org #3470] [BUG] DTLS abort

2014-08-28 Thread Michael Tüxen via RT
On 28 Aug 2014, at 17:25, Brian Hassink via RT r...@openssl.org wrote: Hello Michael, We can confirm that the patch resolves the disconnect abort. Great, thanks a lot for the feedback. Let me know if you have further issues with DTLS/SCTP. Best regards Michael Thanks, Brian

Re: [openssl.org #3507] [PATCH] Fix memory leaks.

2014-08-28 Thread Kurt Roeckx
On Thu, Aug 28, 2014 at 03:11:14PM +0200, Kurt Cancemi via RT wrote: The attached updated patch fixes a style error. I still have a bunch of other patches like this to go thru, but did a quick look at this, and at least this looks weird: --- a/crypto/objects/obj_xref.h +++

Re: [openssl.org #3507] [PATCH] Fix memory leaks.

2014-08-28 Thread Kurt Cancemi
I ran make which regenerated the objects, thanks for pointing that out, I attached an updated patch without the change. --- Kurt Cancemi https://www.x64architecture.com On Thu, Aug 28, 2014 at 12:41 PM, Kurt Roeckx k...@roeckx.be wrote: On Thu, Aug 28, 2014 at 03:11:14PM +0200, Kurt Cancemi

Re: Subject: [PATCH] ssl: introduce async sign/decrypt APIs This patch is introducing `async_key_ex_cb` member of both `SSL_CTX` and `SSL`, and `SSL_supply()`. If `async_key_ex_cb` is present: * Serve

2014-08-28 Thread Fedor Indutny
Oh, and I have just realized that it doesn't handle `ssl3_get_cert_verify` case right now. I'll figure it out tomorrow. On Thu, Aug 28, 2014 at 2:26 PM, Fedor Indutny fe...@indutny.com wrote: Hello again! Here is a second patch that improves the first one. Additionally it copies and

[openssl.org #3102] s_server does not reject invalid client certificates in OpenSSL 1.0.1 14 Mar 2012 with -verify or -Verify options

2014-08-28 Thread Rich Salz via RT
commit 8d4193305b1634a0fb397cb8806cd7dedbff34ef Author: Rich Salz rs...@akamai.com Date: Wed Aug 27 14:23:39 2014 -0400 RT3102: Document -verify_error_return flag Also moved some options around so all the verify options. are clumped together. Reviewed-by: Matt Caswell m...@openssl.org -- Rich

[openssl.org #2193] bug report openssl-0.9.8m crypto/bio/bss_dgram.c

2014-08-28 Thread Rich Salz via RT
Fixed in HEAD commit ac53354b949a252610cf987dbc875a7717f295c4 Author: l.montecchi...@gmail.com l.montecchi...@gmail.com Date: Tue Aug 26 23:11:01 2014 -0400 RT2193: #ifdef errors in bss_dgram.c Problem with #ifdef in the BIO_CTRL_DGRAM_MTU_DISCOVER case that is different from the

Re: [openssl.org #3439] Memory leak bug

2014-08-28 Thread Neitrino Photonov via RT
This function act like destructor. It is really strange if destructor doesn't delete object, if object haven't one method. Also function end with free deallocate pointer, see OpenSSL_free. In your code you can just put new allocation or create clear function ( I think performance doesn't differ

[openssl.org #1665] Contribution of aes.pod

2014-08-28 Thread Rich Salz via RT
commit c7497f34fbf3824dd4a0881d598e598980f2edb1 Author: Rich Salz rs...@akamai.com Date: Thu Aug 14 10:50:26 2014 -0400 RT1665,2300: Crypto doc cleanups RT1665: aes documentation. Paul Green wrote a nice aes.pod file. But we now encourage the EVP interface. So I took his RT item and used it as

[openssl.org #2845] Impact on OpenSSL 0.9.8h from upcoming Microsoft patch

2014-08-28 Thread Rich Salz via RT
not an issue -- Rich Salz, OpenSSL dev team; rs...@openssl.org __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List

[openssl.org #1867] Fw:About OpenSSL crashed in 0.9.8g

2014-08-28 Thread Rich Salz via RT
very old release. not enough information to reproduce. closing ticket. -- Rich Salz, OpenSSL dev team; rs...@openssl.org __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #1155] openssl-0.9.8 causes MS Windows fatal error when executing 'openssl exngine xxx'

2014-08-28 Thread Rich Salz via RT
old release. cannot reproduce. closing ticket. -- Rich Salz, OpenSSL dev team; rs...@openssl.org __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #1673] ssl handshake failure when protocol specified (0.9.8g)

2014-08-28 Thread Rich Salz via RT
old release, cannot reproduce, closing ticket. -- Rich Salz, OpenSSL dev team; rs...@openssl.org __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #2948] thousands of getpid called inside libcrypto.sl.0.9.8

2014-08-28 Thread Rich Salz via RT
working as designed and required. no bug. closing ticket. -- Rich Salz, OpenSSL dev team; rs...@openssl.org __ OpenSSL Project http://www.openssl.org Development Mailing List

[openssl.org #1781] make makefiles traceable in 0.9.8i

2014-08-28 Thread Rich Salz via RT
Not doing this because of portability concerns. -- Rich Salz, OpenSSL dev team; rs...@openssl.org __ OpenSSL Project http://www.openssl.org Development Mailing List