[openssl-dev] [openssl.org #3638] [PATCH] Fix build with -DOPENSSL_NO_SRTP

2014-12-19 Thread Piotr Sikora via RT
Hey guys, 1.0.2-stable and master are currently broken when building with -DOPENSSL_NO_SRTP. Attached patches fix that. Best regards, Piotr Sikora OpenSSL_1_0_2__Fix-build-with-DOPENSSL_NO_SRTP.patch Description: Binary data OpenSSL_master__Fix-build-with-DOPENSSL_NO_SRTP.patch Description

[PATCH] Advance to the next state variant when reusing messages

2014-11-10 Thread Piotr Sikora
connections that were using SSLv2 ClientHello (hence reusing the message), because their state never advanced to SSL3_ST_SR_CLNT_HELLO_C variant required for the retry code path. Reported by Yichun Zhang (agentzh). Signed-off-by: Piotr Sikora pi...@cloudflare.com --- ssl/s3_both.c | 1 + 1 file

[openssl.org #3597] [PATCH] Advance to the next state variant when reusing messages.

2014-11-10 Thread Piotr Sikora via RT
the message), because their state never advanced to SSL3_ST_SR_CLNT_HELLO_C variant required for the retry code path. Reported by Yichun Zhang (agentzh). Signed-off-by: Piotr Sikora pi...@cloudflare.com --- ssl/s3_both.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ssl/s3_both.c b/ssl/s3_both.c

Re: [openssl.org #3336] 1.0.1g breaks IronPORT SMTP appliance (padding extension)

2014-05-02 Thread Piotr Sikora
of the CDN. For Amazon, you can distinguish S3 from CloudFront by looking for at the HTTP headers: - X-Amz-Cf-Id, - Via: ... .cloudfront.net (CloudFront), - X-Cache: ... from cloudfront. Best regards, Piotr Sikora __ OpenSSL Project

Re: [openssl.org #3191] [BUG] OpenSSL-1.0.2 segfaulting on sha1_block_data_order asm

2014-04-25 Thread Piotr Sikora via RT
Hey Andy, Some kind of deja vu here. I remember I was looking at this and drew some conclusion... I think it was addressed and commit b77b58a398c8b9b4113f3fb6b48e162a3b8d4527 actually mentions this ticket. Can you confirm? Yes, it's been fixed by this commit. Best regards, Piotr Sikora

Re: OpenSSL has exploit mitigation countermeasures to make sure its exploitable

2014-04-10 Thread Piotr Sikora
://rt.openssl.org/Ticket/Display.html?id=3265 (guest:guest) Best regards, Piotr Sikora __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org

[PATCH] Disable RC4 for TLS v1.1+ (server-side).

2014-02-03 Thread Piotr Sikora
. Best regards, Piotr Sikora openssl_1_0_1__disable_rc4.patch Description: Binary data openssl_1_0_2__disable_rc4.patch Description: Binary data

[openssl.org #3191] [BUG] OpenSSL-1.0.2 segfaulting on sha1_block_data_order asm

2013-12-06 Thread Piotr Sikora via RT
, as well when it's acting as a server. The OS is Linux 3.9.x and we are using relatively recent OpenSSL-1.0.2 checkout (commit: 5ff68e8f6dac3b0d8997b8bc379f9111c2bab74f). Let me know if you need any more details. Best regards, Piotr Sikora --- sha1_block_data_order_avx --- (gdb) bt #0

Re: [openssl.org #3106] [PATCH] Fix build with OPENSSL_NO_NEXTPROTONEG.

2013-11-13 Thread Piotr Sikora via RT
Hey guys, could you please look into it? Right now, this is show-stopper for adding ALPN support for nginx. Attached patches against current master and OpenSSL_1_0_2-stable branch. Best regards, Piotr Sikora Fix-compilation-with-no-nextprotoneg-master.patch Description: Binary data Fix

Re: ECDHE problem with 1.0.2-dev

2013-11-04 Thread Piotr Sikora
Hey Steve, It picks the highest preference curve supported by both sides, which is usually the strongest curve but it doesn't have to be. Oh, cool! Thanks for clarifying that, I somehow missed the new functions to set the curves list before. Best regards, Piotr Sikora

Re: ECDHE problem with 1.0.2-dev

2013-11-01 Thread Piotr Sikora
the preferred way as it just does the right thing. It always choses the strongest curve supported by both sides, which isn't always preferred (IMHO). Best regards, Piotr Sikora __ OpenSSL Project http

[openssl.org #3106] [PATCH] Fix build with OPENSSL_NO_NEXTPROTONEG.

2013-08-06 Thread Piotr Sikora via RT
on NPN code). Also, I wanted to make sure that SSL_select_next_proto() is not part of NPN and that it will be available going forward. Best regards, Piotr Sikora Fix-build-with-OPENSSL_NO_NEXTPROTONEG.patch Description: Binary data

Re: OpenSSL and the APLN Patch

2013-08-06 Thread Piotr Sikora
Hey Mark, ALPN support is already in the mainline: http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=6f017a8f9db3a79f3a3406cf8d493ccd346db691 Best regards, Piotr Sikora __ OpenSSL Project

Re: [openssl.org #3106] [PATCH] Fix build with OPENSSL_NO_NEXTPROTONEG.

2013-08-06 Thread Piotr Sikora
to disable NPN with no-npn (as described in CHANGES), which obviously didn't do much good... no-nextprotoneg works fine, though :) Best regards, Piotr Sikora __ OpenSSL Project http://www.openssl.org

Re: [openssl.org #3106] [PATCH] Fix build with OPENSSL_NO_NEXTPROTONEG.

2013-08-06 Thread Piotr Sikora via RT
to disable NPN with no-npn (as described in CHANGES), which obviously didn't do much good... no-nextprotoneg works fine, though :) Best regards, Piotr Sikora __ OpenSSL Project http://www.openssl.org

[openssl.org #3103] [PATCH] Set TLS EC curve_id from EC group alone.

2013-08-02 Thread Piotr Sikora via RT
(ctx, SSL_OP_SINGLE_ECDH_USE); SSL_CTX_set_tmp_ecdh(ctx, ecdh); The solution is to use only EC group and don't require EC key to be already generated. Signed-off-by: Piotr Sikora pi...@cloudflare.com --- ssl/t1_lib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ssl

[openssl.org #3104] [BUG] Build broken on OSX (RSAZ assembly)

2013-08-02 Thread Piotr Sikora via RT
, Piotr Sikora __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org

Re: [Patch] ALPN Implementation for OpenSSL

2013-06-20 Thread Piotr Sikora
) !defined(OPENSSL_NO_ALPN) +#error Cannot define both NPN and ALPN +#endif We simply cannot drop support for NPN (i.e. SPDY) just to add support for ALPN. IMHO, the correct solution would be to always prefer and offer ALPN, unless client announced only NPN support in Client Hello. Best regards, Piotr

Re: [Patch] ALPN Implementation for OpenSSL

2013-06-20 Thread Piotr Sikora
be used. I want to have a library that supports both, not either-or. Best regards, Piotr Sikora __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev

Re: [Patch] ALPN Implementation for OpenSSL

2013-06-20 Thread Piotr Sikora
Hey, Yes, supporting both at runtime would be best. But having a compile-time option now, and defaulting to NPN should keep this from being a blocking issue with the patch, correct? It would also make it kind of useless, at least from my non-authoritative point of view. Best regards, Piotr

Re: [openssl.org #3046] bug report, openssl 1.0.1e sha1 hash generation

2013-05-15 Thread Piotr Sikora
parameter: $ echo -n 12345 | openssl dgst -sha1 -hex (stdin)= 8cb2237d0679ca88db6464eac60da96345513964 $ echo -n 12345 | openssl dgst -sha1 -hex (stdin)= 10298ad22a68325ec5b2a69f209cac87135a5884 Best regards, Piotr Sikora __ OpenSSL