Re: [openssl-dev] [RFC 1/2] engine: add new flag based method for loading engine keys

2016-11-18 Thread David Woodhouse
On Thu, 2016-11-17 at 09:33 +0200, Roumen Petrov wrote: > David Woodhouse wrote: > > > The assumption in all the current engine code is that key_id can be > > > passed as something like a file name. > > This is mostly documentation issue. > Usually OpenSSL man pages use filename for , but

Re: [openssl-dev] [RFC 1/2] engine: add new flag based method for loading engine keys

2016-11-17 Thread Roumen Petrov
David Woodhouse wrote: The assumption in all the current engine code is that key_id can be passed as something like a file name. This is mostly documentation issue. Usually OpenSSL man pages use filename for , but actually it is just a string and engine is responsible how to process There

Re: [openssl-dev] [RFC 1/2] engine: add new flag based method for loading engine keys

2016-11-16 Thread Dr. Stephen Henson
On Wed, Nov 16, 2016, James Bottomley wrote: > The assumption in all the current engine code is that key_id can be > passed as something like a file name. Well no it's a null terminated string whose meaning is engine specific. In some cases it is a key ID, in others it is a more complex string

Re: [openssl-dev] [RFC 1/2] engine: add new flag based method for loading engine keys

2016-11-16 Thread Salz, Rich
It is a heck of a lot easier for everyone if you make pull requests and not just mail big patches. Can you do that? -- openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

[openssl-dev] [RFC 1/2] engine: add new flag based method for loading engine keys

2016-11-16 Thread James Bottomley
The assumption in all the current engine code is that key_id can be passed as something like a file name. There are some new users that actually want to pass a BIO, so add a new load_key method for engines that takes a flag value. The first defined flag is ENGINE_LOAD_KEY_FLAG_BIO which means

Re: [openssl-dev] [RFC 1/2] engine: add new flag based method for loading engine keys

2016-11-14 Thread David Woodhouse
> The assumption in all the current engine code is that key_id can be > passed as something like a file name. There are some new users that > actually want to pass a BIO, so add a new load_key method for engines > that takes a flag value. The first defined flag is > ENGINE_LOAD_KEY_FLAG_BIO