Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-29 Thread Dmitry Belyavsky
Hello all, Some engines configure themselves using config, so absence of config can mean non-functional engine. On Thu, May 28, 2015 at 3:36 PM, Short, Todd via RT r...@openssl.org wrote: The parameters in the configuration file, in general, apply only to certificate operations. The openssl

[openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Rich Salz via RT
fixed on master: commit cc01d21756cc9c79231ef21039782c5fe42008a2 Author: Rich Salz rs...@akamai.com Date: Thu May 28 13:52:55 2015 -0400 RT3876: Only load config when needed Create app_load_config(), a routine to load config file. Remove the always load config from the main app. Change the

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Blumenthal, Uri - 0553 - MITLL
Todd, I agree. Have the warning only where it matters (but have it there). From: Short, Todd [mailto:tsh...@akamai.com] Sent: Thursday, May 28, 2015 08:25 AM To: Blumenthal, Uri - 0553 - MITLL Cc: r...@openssl.org r...@openssl.org; openssl-dev@openssl.org openssl-dev@openssl.org Subject: Re:

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Blumenthal, Uri - 0553 - MITLL via RT
If I want and expect openssl to use a config file, and it did not find it - it's darn useful for me to be informed of that fact by openssl. - Original Message - From: Rich Salz via RT [mailto:r...@openssl.org] Sent: Wednesday, May 27, 2015 08:44 PM To: tsh...@akamai.com

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Blumenthal, Uri - 0553 - MITLL
If I want and expect openssl to use a config file, and it did not find it - it's darn useful for me to be informed of that fact by openssl. - Original Message - From: Rich Salz via RT [mailto:r...@openssl.org] Sent: Wednesday, May 27, 2015 08:44 PM To: tsh...@akamai.com

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Short, Todd
The parameters in the configuration file, in general, apply only to certificate operations. The openssl application does way more than certificate operations, and seeing a warning for a configuration file that has no impact on the operation being performed is annoying. Rather than completely

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Short, Todd via RT
The parameters in the configuration file, in general, apply only to certificate operations. The openssl application does way more than certificate operations, and seeing a warning for a configuration file that has no impact on the operation being performed is annoying. Rather than completely

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Blumenthal, Uri - 0553 - MITLL via RT
Todd, I agree. Have the warning only where it matters (but have it there). From: Short, Todd [mailto:tsh...@akamai.com] Sent: Thursday, May 28, 2015 08:25 AM To: Blumenthal, Uri - 0553 - MITLL Cc: r...@openssl.org r...@openssl.org; openssl-dev@openssl.org openssl-dev@openssl.org Subject: Re:

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Ann
If the environment variable OPENSSL_CNF points to non-existing file a warning seems also being informative. /Ann. Am 28.05.2015 um 14:25 schrieb Short, Todd: The parameters in the configuration file, in general, apply only to certificate operations. The openssl application does way more

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Salz, Rich via RT
My suggestion is, at least for 1.1 (but I don't see why this can't be ported down to 1.0.2 and 1.0.1) remove the config loading code from openssl.c:main() and add the same code in req.c as you can find in ts.c or srp.c... possibly refactoring that code into a helper function in apps.c. Yes,

[openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-28 Thread Richard Levitte via RT
On Thu May 28 02:44:11 2015, rsalz wrote: Because it goes ahead and proceeds. Not it is explicit testing ENOTFOUND. It should either error+exit or not complain. I can be convinced the current behavior is useful. -- Rich Salz, OpenSSL dev team; rs...@openssl.org The current behavior is

[openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-27 Thread Short, Todd via RT
Hello OpenSSL Org: This is a change that Akamai has made to its implementation of OpenSSL. Version: master branch Description: Do not complain if config file not found Remove warning when OpenSSL config file can't be found Github link:

[openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-27 Thread Rich Salz via RT
Because it goes ahead and proceeds. Not it is explicit testing ENOTFOUND. It should either error+exit or not complain. I can be convinced the current behavior is useful. -- Rich Salz, OpenSSL dev team; rs...@openssl.org ___ openssl-dev mailing list To

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-27 Thread Short, Todd via RT
I'll let the original author (Rich Salz, cc'd), explain. -- -Todd Short // tsh...@akamai.com // Sent from my iPhone // One if by land, two if by sea, three if by the Internet. On May 27, 2015, at 6:40 PM, Daniel Kahn Gillmor via RT r...@openssl.org wrote: On Wed 2015-05-27 16:32:45

Re: [openssl-dev] [openssl.org #3876] [PATCH] Do not complain if config file not found

2015-05-27 Thread Daniel Kahn Gillmor
On Wed 2015-05-27 16:32:45 -0400, Short, Todd via RT wrote: This is a change that Akamai has made to its implementation of OpenSSL. Version: master branch Description: Do not complain if config file not found Remove warning when OpenSSL config file can't be found Github link: