[openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-05-25 Thread Richard Levitte via RT
On Tue Mar 29 12:02:41 2016, noloa...@gmail.com wrote: > >>> $ cat conf_lib.patch > >>> diff --git a/crypto/conf/conf_lib.c b/crypto/conf/conf_lib.c > >>> index f197714..7bc3ac0 100644 > >>> --- a/crypto/conf/conf_lib.c > >>> +++ b/crypto/conf/conf_lib.c > >>> @@ -392,7 +392,7 @@ void > >>>

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-29 Thread Kaduk, Ben via RT
On 03/29/2016 08:58 AM, noloa...@gmail.com via RT wrote: > On Tue, Mar 29, 2016 at 9:53 AM, Salz, Rich via RT wrote: >> We use strdup because none of the openssl machinery (error stack, etc) might >> be set up yet. >> >> The comment a few lines above says this! > Thanks. > >

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-29 Thread noloa...@gmail.com via RT
On Tue, Mar 29, 2016 at 9:53 AM, Salz, Rich via RT wrote: > We use strdup because none of the openssl machinery (error stack, etc) might > be set up yet. > > The comment a few lines above says this! Thanks. That does not explain why this had not effect on Windows, even after

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-29 Thread Jeffrey Walton
On Tue, Mar 29, 2016 at 9:53 AM, Salz, Rich via RT wrote: > We use strdup because none of the openssl machinery (error stack, etc) might > be set up yet. > > The comment a few lines above says this! Thanks. That does not explain why this had not effect on Windows, even after

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-29 Thread Salz, Rich via RT
We use strdup because none of the openssl machinery (error stack, etc) might be set up yet. The comment a few lines above says this! -- Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4489 Please log in as guest with password guest if prompted -- openssl-dev mailing list To

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-29 Thread noloa...@gmail.com via RT
>>> $ cat conf_lib.patch >>> diff --git a/crypto/conf/conf_lib.c b/crypto/conf/conf_lib.c >>> index f197714..7bc3ac0 100644 >>> --- a/crypto/conf/conf_lib.c >>> +++ b/crypto/conf/conf_lib.c >>> @@ -392,7 +392,7 @@ void >>> OPENSSL_INIT_set_config_filename(OPENSSL_INIT_SETTINGS *settings, >>>

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-29 Thread Jeffrey Walton
>>> $ cat conf_lib.patch >>> diff --git a/crypto/conf/conf_lib.c b/crypto/conf/conf_lib.c >>> index f197714..7bc3ac0 100644 >>> --- a/crypto/conf/conf_lib.c >>> +++ b/crypto/conf/conf_lib.c >>> @@ -392,7 +392,7 @@ void >>> OPENSSL_INIT_set_config_filename(OPENSSL_INIT_SETTINGS *settings, >>>

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-29 Thread Andy Polyakov via RT
On 03/28/16 15:16, Viktor Dukhovni via RT wrote: > >> On Mar 28, 2016, at 4:38 AM, noloa...@gmail.com via RT >> wrote: >> >> On Windows, the fix below also depends upon the patch from Issue 4488 >> ("The POSIX name for this item is deprecated. Instead, use the ISO C++ >>

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-28 Thread Viktor Dukhovni via RT
> On Mar 28, 2016, at 4:38 AM, noloa...@gmail.com via RT > wrote: > > On Windows, the fix below also depends upon the patch from Issue 4488 > ("The POSIX name for this item is deprecated. Instead, use the ISO C++ > conformant name..."). > > This patch below also fixes some

Re: [openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-28 Thread Viktor Dukhovni
> On Mar 28, 2016, at 4:38 AM, noloa...@gmail.com via RT > wrote: > > On Windows, the fix below also depends upon the patch from Issue 4488 > ("The POSIX name for this item is deprecated. Instead, use the ISO C++ > conformant name..."). > > This patch below also fixes some

[openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-03-28 Thread noloa...@gmail.com via RT
On Windows, the fix below also depends upon the patch from Issue 4488 ("The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name..."). This patch below also fixes some problems with the older standards on Fedora, BSD and Linux. $ cat conf_lib.patch diff --git