Re: [openssl-dev] In ssl3_write_bytes, some checks related to hanlding write failure are missing

2017-04-04 Thread Raja ashok
Hi Matt, I created a Pull request for the second change on master, 1.0.2 and 1.1.0. I am creating PR in github for the first time, so if anything else I missed please update me. https://github.com/openssl/openssl/pull/3124 https://github.com/openssl/openssl/pull/3123

Re: [openssl-dev] In ssl3_write_bytes, some checks related to hanlding write failure are missing

2017-04-03 Thread Matt Caswell
On 31/03/17 18:54, Raja ashok wrote: > Hi All, > > > > In ssl3_write_bytes, if (len < tot) we are returning failure with > SSL_R_BAD_LENGTH error. In this place I hope we should set “tot” back to > “s->s3->wnum”. Otherwise when application calls back SSL_write with > correct buffer, it causes

Re: [openssl-dev] In ssl3_write_bytes, some checks related to hanlding write failure are missing

2017-03-31 Thread Raja ashok
Hi All, In ssl3_write_bytes, if (len < tot) we are returning failure with SSL_R_BAD_LENGTH error. In this place I hope we should set “tot” back to “s->s3->wnum”. Otherwise when application calls back SSL_write with correct buffer, it causes serious problem (“tot” is 0 and iLeft is not NULL). I

[openssl-dev] In ssl3_write_bytes, some checks related to hanlding write failure are missing

2017-03-27 Thread Raja ashok
Hi, I feel there is a check missing in ssl3_write_bytes, in case of handling write failure. Consider SSL_write is called with 2 bytes buffer, then internally in ssl3_write_bytes we try to send it as two record (16384 and 3616). If TCP send failed for the second record then we store the