[openssl.org #1984] [PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-13 Thread Stephen Henson via RT
Applied to 1.0 and HEAD. Patch doesn't work with 0.9.8, please supply an version for 0.9.8. Steve. -- Dr Stephen N. Henson. OpenSSL project core developer. Commercial tech support now available see: http://www.openssl.org __

Re: [openssl.org #1984] [PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-13 Thread Michael Tüxen via RT
Hi Steve, please find attached a similar patch for 0.9.8. Best regards Michael dtls.patch Description: Binary data On Jul 13, 2009, at 1:46 PM, Stephen Henson via RT wrote: Applied to 1.0 and HEAD. Patch doesn't work with 0.9.8, please supply an version for 0.9.8. Steve. -- Dr

Re: [openssl.org #1984] [PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-10 Thread Daniel Mentz via RT
Dear Michael, I've got some concerns regarding your patch: Michael Tuexen via RT wrote: I have looked at the patch provided by Daniel. All suggested changes are OK, but there are two additional things which should be fixed: 1. In ssl3_read_n() the argument max is overwritten before used. I

Re: [openssl.org #1984] [PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-10 Thread Daniel Mentz
Dear Michael, I've got some concerns regarding your patch: Michael Tuexen via RT wrote: I have looked at the patch provided by Daniel. All suggested changes are OK, but there are two additional things which should be fixed: 1. In ssl3_read_n() the argument max is overwritten before used. I

Re: [openssl.org #1984] [PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-10 Thread Michael Tüxen
Dear Daniel, comments in-line. Best regards Michael On Jul 10, 2009, at 1:19 PM, Daniel Mentz via RT wrote: Dear Michael, I've got some concerns regarding your patch: Michael Tuexen via RT wrote: I have looked at the patch provided by Daniel. All suggested changes are OK, but there are

Re: [openssl.org #1984] [PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-10 Thread Michael Tüxen via RT
Dear Daniel, comments in-line. Best regards Michael On Jul 10, 2009, at 1:19 PM, Daniel Mentz via RT wrote: Dear Michael, I've got some concerns regarding your patch: Michael Tuexen via RT wrote: I have looked at the patch provided by Daniel. All suggested changes are OK, but there

[openssl.org #1984] [PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-09 Thread Daniel Mentz via RT
ssl3_read_n() was conceived to read blocks of data from a byte oriented stream. This can be easily explained by an example: You call ssl3_read_n() with the a parameter like Read 50 bytes of data. As opposed to the read() function provided by the OS, ssl3_read_n() makes sure you really get 50

Re: [openssl.org #1984][PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-09 Thread Michael Tuexen via RT
Dear all, I agree with Daniel that reading a record from multiple UDP packets is a bug. I need some time to figure out if the proposed fix is the right one. Robin is on holiday for two weeks. Best regards Michael On Jul 8, 2009, at 10:15 PM, Daniel Mentz wrote: ssl3_read_n() was conceived to

[openssl.org #1984] [PATCH]: DTLS: ssl3_read_n() concatenates UDP datagrams in DTLS case

2009-07-09 Thread Michael Tuexen via RT
Dear all, I have looked at the patch provided by Daniel. All suggested changes are OK, but there are two additional things which should be fixed: 1. In ssl3_read_n() the argument max is overwritten before used. 2. If additional data is behind a valid DTLS record in the UDP packet, it is