Re: [openssl.org #2470] [PATCH] Cygwin: Don't call ERR_remove_state from DllMain

2011-06-20 Thread Corinna Vinschen via RT
Ping 2? It's 3 months since I asked to apply this simple patch. Is something wrong with the patch, apart from removing the call to ERR_remove_state entirely, as discussed in http://www.mail-archive.com/openssl-dev@openssl.org/msg29218.html ? Corinna On May 16 15:38, Corinna Vinschen wrote: >

Re: [openssl.org #2470] [PATCH] Cygwin: Don't call ERR_remove_state from DllMain

2011-05-16 Thread Corinna Vinschen
On May 16 07:46, David Schwartz wrote: > > Shouldn't this code be removed on all platforms? It seems that the > issue Cygwin is having could occur on any platform, perhaps it just > happens not to on Win32 with the default locking callbacks. > > It should be obvious that calling any OpenSSL funct

Re: [openssl.org #2470] [PATCH] Cygwin: Don't call ERR_remove_state from DllMain

2011-05-16 Thread David Schwartz
Shouldn't this code be removed on all platforms? It seems that the issue Cygwin is having could occur on any platform, perhaps it just happens not to on Win32 with the default locking callbacks. It should be obvious that calling any OpenSSL functions that require the locking callbacks to be

Re: [openssl.org #2470] [PATCH] Cygwin: Don't call ERR_remove_state from DllMain

2011-05-16 Thread Corinna Vinschen via RT
Ping? On Mar 22 12:03, Corinna Vinschen via RT wrote: > On Mar 17 09:11, Corinna Vinschen via RT wrote: > > Hi, > > > > the below patch is against current CVS HEAD, but it should be applied > > to all supported branches of OpenSSL, starting with 0.9.8. > > > > On systems running on the Windows p

Re: [openssl.org #2470] [PATCH] Cygwin: Don't call ERR_remove_state from DllMain

2011-05-16 Thread Corinna Vinschen
Ping? On Mar 22 12:03, Corinna Vinschen via RT wrote: > On Mar 17 09:11, Corinna Vinschen via RT wrote: > > Hi, > > > > the below patch is against current CVS HEAD, but it should be applied > > to all supported branches of OpenSSL, starting with 0.9.8. > > > > On systems running on the Windows p

Re: [openssl.org #2470] [PATCH] Cygwin: Don't call ERR_remove_state from DllMain

2011-03-22 Thread Corinna Vinschen via RT
On Mar 17 09:11, Corinna Vinschen via RT wrote: > Hi, > > the below patch is against current CVS HEAD, but it should be applied > to all supported branches of OpenSSL, starting with 0.9.8. > > On systems running on the Windows platform, there's a DllMain function > in crypto/cryptlib.c which alwa

[openssl.org #2470] [PATCH] Cygwin: Don't call ERR_remove_state from DllMain

2011-03-17 Thread Corinna Vinschen via RT
Hi, the below patch is against current CVS HEAD, but it should be applied to all supported branches of OpenSSL, starting with 0.9.8. On systems running on the Windows platform, there's a DllMain function in crypto/cryptlib.c which always calls ERR_remove_state(0) if an application thread exits.