Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-16 Thread Mike Frysinger
On Mon 16 Jun 2014 06:39:40 Viktor Dukhovni wrote: > On Mon, Jun 16, 2014 at 02:10:14AM -0400, Mike Frysinger wrote: > > On Mon 28 Apr 2014 09:32:40 Salz, Rich wrote: > > > > While rpaths are not needed in some contexts, they are important in > > > > others, please do not remove rpath support. > >

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-15 Thread Viktor Dukhovni
On Mon, Jun 16, 2014 at 02:10:14AM -0400, Mike Frysinger wrote: > On Mon 28 Apr 2014 09:32:40 Salz, Rich wrote: > > > While rpaths are not needed in some contexts, they are important in > > > others, please do not remove rpath support. > > Yes, such as cross-compiling or embedded systems. I think

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-15 Thread Mike Frysinger
On Mon 28 Apr 2014 09:32:40 Salz, Rich wrote: > > While rpaths are not needed in some contexts, they are important in > > others, please do not remove rpath support. > Yes, such as cross-compiling or embedded systems. I think it's reasonable > to make it a config option tho. eh ? rpaths are not

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-06 Thread Mike Frysinger via RT
On Fri 06 Jun 2014 09:15:09 Kurt Roeckx via RT wrote: > On Fri, Jun 06, 2014 at 01:27:02AM -0400, Mike Frysinger wrote: > > On Thu 05 Jun 2014 22:53:32 Matt Caswell via RT wrote: > > > On Sun Apr 27 13:04:20 2014, vap...@gentoo.org wrote: > > > > It's a standard setting that other build systems use

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-06 Thread Mike Frysinger
On Fri 06 Jun 2014 09:15:09 Kurt Roeckx via RT wrote: > On Fri, Jun 06, 2014 at 01:27:02AM -0400, Mike Frysinger wrote: > > On Thu 05 Jun 2014 22:53:32 Matt Caswell via RT wrote: > > > On Sun Apr 27 13:04:20 2014, vap...@gentoo.org wrote: > > > > It's a standard setting that other build systems use

RE: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-06 Thread Salz, Rich
> I think this misses the point, one can already just pass a table entry on the > command-line as a colon-separated target name. Yes, you're right, I was mis-using the thread. But putting a config spec on the command line is, shall we say, awkward. And adding the flag would help with code clea

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-06 Thread Viktor Dukhovni
On Fri, Jun 06, 2014 at 10:42:06AM -0400, Salz, Rich wrote: > Perhaps Configure should have a "-f nnn" flag, that lets folks > add their own local table without having to patch the script I think this misses the point, one can already just pass a table entry on the command-line as a colon-separat

RE: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-06 Thread Salz, Rich
penssl.org [mailto:owner-openssl-...@openssl.org] On Behalf Of Viktor Dukhovni Sent: Friday, June 06, 2014 10:31 AM To: openssl-dev@openssl.org Subject: Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build On Fri, Jun 06, 2014 at 09:15:02AM +0200, Kurt Roeckx wrote: > I ended up using

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-06 Thread Viktor Dukhovni
On Fri, Jun 06, 2014 at 09:15:02AM +0200, Kurt Roeckx wrote: > I ended up using the cflags in Configure for that. I wrote a script that takes the output of "Configure TABLE" to extract the settings for my desired target, makes appropriate additions to the desired field, and then runs "Configure"

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-06 Thread Kurt Roeckx via RT
On Fri, Jun 06, 2014 at 01:27:02AM -0400, Mike Frysinger wrote: > On Thu 05 Jun 2014 22:53:32 Matt Caswell via RT wrote: > > On Sun Apr 27 13:04:20 2014, vap...@gentoo.org wrote: > > > It's a standard setting that other build systems use. > > > > Can you explain why you need this? > > because peo

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-06 Thread Kurt Roeckx
On Fri, Jun 06, 2014 at 01:27:02AM -0400, Mike Frysinger wrote: > On Thu 05 Jun 2014 22:53:32 Matt Caswell via RT wrote: > > On Sun Apr 27 13:04:20 2014, vap...@gentoo.org wrote: > > > It's a standard setting that other build systems use. > > > > Can you explain why you need this? > > because peo

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-05 Thread Mike Frysinger via RT
On Thu 05 Jun 2014 22:53:32 Matt Caswell via RT wrote: > On Sun Apr 27 13:04:20 2014, vap...@gentoo.org wrote: > > It's a standard setting that other build systems use. > > Can you explain why you need this? because people want to set custom linker flags. `man ld` shows quite a large number tha

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-06-05 Thread Mike Frysinger
On Thu 05 Jun 2014 22:53:32 Matt Caswell via RT wrote: > On Sun Apr 27 13:04:20 2014, vap...@gentoo.org wrote: > > It's a standard setting that other build systems use. > > Can you explain why you need this? because people want to set custom linker flags. `man ld` shows quite a large number tha

RE: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-04-28 Thread Salz, Rich
> While rpaths are not needed in some contexts, they are important in others, > please do not remove rpath support. Yes, such as cross-compiling or embedded systems. I think it's reasonable to make it a config option tho. /r$ -- Principal Security Engineer Akamai Technologies, Cambr

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-04-27 Thread Viktor Dukhovni
On Sun, Apr 27, 2014 at 02:08:12PM +0200, Kurt Roeckx via RT wrote: > But then I think think that we shouldn't have rpaths in the first > place, so I wouldn't have a problem with removing the rpath. While rpaths are not needed in some contexts, they are important in others, please do not remove r

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-04-27 Thread Mike Frysinger via RT
On Sun 27 Apr 2014 14:08:12 Kurt Roeckx via RT wrote: > > -DO_GNU_APP=LDFLAGS="$(CFLAGS) -Wl,-rpath,$(LIBRPATH)" > > +DO_GNU_APP=LDFLAGS="$(LDFLAGS) $(CFLAGS)" > > Shouldn't that be this? > +DO_GNU_APP=LDFLAGS="$(LDFLAGS) -Wl,-rpath,$(LIBRPATH)" i didn't mean to include dropping of the rpath in t

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-04-27 Thread Mike Frysinger
On Sun 27 Apr 2014 14:08:12 Kurt Roeckx via RT wrote: > > -DO_GNU_APP=LDFLAGS="$(CFLAGS) -Wl,-rpath,$(LIBRPATH)" > > +DO_GNU_APP=LDFLAGS="$(LDFLAGS) $(CFLAGS)" > > Shouldn't that be this? > +DO_GNU_APP=LDFLAGS="$(LDFLAGS) -Wl,-rpath,$(LIBRPATH)" i didn't mean to include dropping of the rpath in t

Re: [openssl.org #3331] [PATCH] respect LDFLAGS during build

2014-04-27 Thread Kurt Roeckx via RT
> -DO_GNU_APP=LDFLAGS="$(CFLAGS) -Wl,-rpath,$(LIBRPATH)" > +DO_GNU_APP=LDFLAGS="$(LDFLAGS) $(CFLAGS)" Shouldn't that be this? +DO_GNU_APP=LDFLAGS="$(LDFLAGS) -Wl,-rpath,$(LIBRPATH)" But then I think think that we shouldn't have rpaths in the first place, so I wouldn't have a problem with removing