Re: [openssl-dev] Feedback on BIO API changes in 1.1

2016-06-29 Thread Matt Caswell
On 27/06/16 21:56, Timothy B. Terriberry wrote: > Because I am writing a library, which I > intend to be re-entrant, but which does not have any explicit threading > support (or dependencies), I don't have any convenient global place to > cache it. I haven't needed one for anything else. You cou

Re: [openssl-dev] Feedback on BIO API changes in 1.1

2016-06-27 Thread Matt Caswell
On 27/06/16 21:56, Timothy B. Terriberry wrote: >> Did you see BIO_meth_set_write etc ? > > I did. I also saw that exactly no code in OpenSSL itself uses this API. Not strictly true. s_server uses it as does asynciotest. We also use the similar RSA_METHOD functions and DSA_METHOD functions in

Re: [openssl-dev] Feedback on BIO API changes in 1.1

2016-06-27 Thread Salz, Rich
> > That sounds like a bug we need to fix. Perhaps something like > > int BIO_meth_new_index([int flags?]) > But I think even just some advice on _how_ to pick a value here would be > sufficient. As long as the space is sufficiently sparse, picking a static > value > with reasonably low pro

Re: [openssl-dev] Feedback on BIO API changes in 1.1

2016-06-27 Thread Timothy B. Terriberry
Salz, Rich wrote: This feedback is very useful. 1) There is no accessor for the "num" field in the BIO struct. This is typically used to store a file descriptor or similar value. As can be seen by its explicit access in BIO_dup_chain(), there may be legitimate reasons to get at its value, even

Re: [openssl-dev] Feedback on BIO API changes in 1.1

2016-06-27 Thread Salz, Rich
This feedback is very useful. > 1) There is no accessor for the "num" field in the BIO struct. > This is typically used to store a file descriptor or similar value. As can be > seen > by its explicit access in BIO_dup_chain(), there may be legitimate reasons to > get at its value, even if you are