Re: [openssl-dev] Minor bug in custom TLS extensions

2015-09-02 Thread Bill Cox
On Wed, Sep 2, 2015 at 7:55 AM, Matt Caswell wrote: > > > On 02/09/15 15:50, Bill Cox wrote: > > As for the order issue, we parse headers before creating any, so I'll > > just not add the header in the AddCallback if s->hit is set on the > > server side. This should behave well long term, I thin

Re: [openssl-dev] Minor bug in custom TLS extensions

2015-09-02 Thread Matt Caswell
On 02/09/15 15:50, Bill Cox wrote: > As for the order issue, we parse headers before creating any, so I'll > just not add the header in the AddCallback if s->hit is set on the > server side. This should behave well long term, I think. Except that in master (i.e. version 1.1.0) you will not be a

Re: [openssl-dev] Minor bug in custom TLS extensions

2015-09-02 Thread Emilia Käsper
On Wed, Sep 2, 2015 at 3:00 AM, Bill Cox wrote: > On Tue, Sep 1, 2015 at 2:50 PM, Emilia Käsper wrote: > >> It's not quite clear to me why you'd have to resend parameters on >> resumption. After all, they are definitive for the session. Best if the >> draft explicitly specifies resumption behavi

Re: [openssl-dev] Minor bug in custom TLS extensions

2015-09-01 Thread Emilia Käsper
On Fri, Aug 28, 2015 at 2:21 AM, Bill Cox wrote: > On Thu, Aug 27, 2015 at 5:00 PM, Emilia Käsper wrote: > >> A client should (SHOULD) always repeat extensions on resumption though, >> as it can't know whether the resumption will be accepted. >> >> Do you have a specific example where you need t

Re: [openssl-dev] Minor bug in custom TLS extensions

2015-08-27 Thread Emilia Käsper
It's not really a bug. The behaviour upon resumption is extension-specific. Most extensions are only needed for establishing the session; they're ignored during resumption, and aren't stored in the session state. So it's rather that the custom extensions API doesn't support stateful extensions. A