Re: Avoid multiple locks in FIPS mode commit to OpenSSL_1_0_1-stable

2013-12-11 Thread Dr. Stephen Henson
On Wed, Dec 11, 2013, Ben Laurie wrote: > On 11 December 2013 08:55, Tomas Mraz wrote: > > On Út, 2013-12-10 at 14:45 +0100, Dr. Stephen Henson wrote: > >> On Mon, Dec 09, 2013, geoff_l...@mcafee.com wrote: > >> > >> > Shouldn't the code read: > >> > > >> > if (!FIPS_mode()) > >> >

Re: Avoid multiple locks in FIPS mode commit to OpenSSL_1_0_1-stable

2013-12-11 Thread Ben Laurie
On 11 December 2013 08:55, Tomas Mraz wrote: > On Út, 2013-12-10 at 14:45 +0100, Dr. Stephen Henson wrote: >> On Mon, Dec 09, 2013, geoff_l...@mcafee.com wrote: >> >> > Shouldn't the code read: >> > >> > if (!FIPS_mode()) >> > CRYPTO_w_[un]lock(CRYPTO_LOCK_RAND); >> > >> > Note the

Re: Avoid multiple locks in FIPS mode commit to OpenSSL_1_0_1-stable

2013-12-11 Thread Dr. Stephen Henson
On Wed, Dec 11, 2013, Tomas Mraz wrote: > On Út, 2013-12-10 at 14:45 +0100, Dr. Stephen Henson wrote: > > On Mon, Dec 09, 2013, geoff_l...@mcafee.com wrote: > > > > > Shouldn't the code read: > > > > > > if (!FIPS_mode()) > > > CRYPTO_w_[un]lock(CRYPTO_LOCK_RAND); > > > > > > Not

Re: Avoid multiple locks in FIPS mode commit to OpenSSL_1_0_1-stable

2013-12-11 Thread Tomas Mraz
On Út, 2013-12-10 at 14:45 +0100, Dr. Stephen Henson wrote: > On Mon, Dec 09, 2013, geoff_l...@mcafee.com wrote: > > > Shouldn't the code read: > > > > if (!FIPS_mode()) > > CRYPTO_w_[un]lock(CRYPTO_LOCK_RAND); > > > > Note the '!' operator. > > > > Yes it should, sorry about th

Re: Avoid multiple locks in FIPS mode commit to OpenSSL_1_0_1-stable

2013-12-10 Thread Dr. Stephen Henson
On Mon, Dec 09, 2013, geoff_l...@mcafee.com wrote: > Shouldn't the code read: > > if (!FIPS_mode()) > CRYPTO_w_[un]lock(CRYPTO_LOCK_RAND); > > Note the '!' operator. > Yes it should, sorry about that. Fixed now. Steve. -- Dr Stephen N. Henson. OpenSSL project core developer. Co