Re: possible crash in BIO_printf()

1999-11-29 Thread Richard Levitte - VMS Whacker
kris> > int BIO_printf (BIO *bio, ...) kris> > { kris> > va_list args; kris> > char *format; kris> > int ret; kris> > MS_STATIC char hugebuf[1024*2]; /* 10k in one chunk is the limit */ kris> kris> Hmm, isn't this comment wrong? 1024*2*sizeof(char) = 2k, no

Re: possible crash in BIO_printf()

1999-11-29 Thread Kris Kennaway
On Mon, 29 Nov 1999, Richard Levitte - VMS Whacker wrote: > No. I remember there being a 10K limit on arrays in Borland C, unless > you used the "huge" memory model, or something like that. So that > comment does not apply to the size you see there, but to the limit > beyond which that size can

Re: possible crash in BIO_printf()

1999-11-28 Thread Kris Kennaway
On Sat, 27 Nov 1999, Goetz Babin-Ebell wrote: > We should fix this by using vsnprintf() instead of vsprintf(). > (and snprintf instead of sprintf) > > But on some systems there is no (v)snprintf. > There we must use (v)sprintf(). > (And hope this will be fixed soon...) OpenSSL could (and probab

possible crash in BIO_printf()

1999-11-27 Thread Goetz Babin-Ebell
Hallo, I have a problem with BIO_printf: It is possible to crash a program using BIO_printf passing data resulting in a very long (> 1024*2 char) string. We should fix this by using vsnprintf() instead of vsprintf(). (and snprintf instead of sprintf) But on some systems there is no (v)snprintf