Re: [openssl.org #3125] [PATCH 1.0.1e] openssl/crypto/armcap.c: fix a typo in OPENSSL_rdtsc

2013-09-16 Thread Ben Laurie
I find these easier to deal with as pull requests... On 12 September 2013 17:14, Kyle McMartin via RT r...@openssl.org wrote: a | 1 is always true, regardless of OPENSSL_armcap_P, and mrc cp15 will fail on = v6. --- a/crypto/armcap.c +++ b/crypto/armcap.c @@ -23,7 +23,7 @@ unsigned int

Re: [openssl.org #3124] potential bug in ssl/s3_cbc.c

2013-09-16 Thread Ben Laurie
On 12 September 2013 17:14, Arthur Mesh via RT r...@openssl.org wrote: I am not 100% sure this is a real bug, hence first tried mailing openssl-users instead of rt@. But since there was no reply, I am sending this to rt@ 641 if (is_sslv3) 642 { snip

Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-16 Thread Yuriy Kaminskiy
Cristian Rodríguez wrote: El 12/09/13 14:17, Yuriy Kaminskiy escribió: This will break on glibc-3.0. #if defined(__GLIBC_PREREQ) __GLIBC_PREREQ(2, 16) Yes, that is the correct way, but ensure features.h is being included. (it seems this patch will be rejected for different reasons

Re: [openssl.org #2459] ecdsa_method declaration prevents use in implementing a dynamic engine

2013-09-16 Thread Douglas E. Engert
On 9/12/2013 10:46 AM, Dr. Stephen Henson wrote: On Thu, Sep 12, 2013, Douglas E. Engert wrote: On 9/11/2013 2:01 PM, Stephen Henson via RT wrote: [snip] Yes similar to that but with a few minor changes. The analogous functions for EVP_PKEY_METHOD are called set and not put. For

Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-16 Thread Mike Frysinger
On Sunday 15 September 2013 18:30:32 Yuriy Kaminskiy wrote: Cristian Rodríguez wrote: El 12/09/13 14:17, Yuriy Kaminskiy escribió: This will break on glibc-3.0. #if defined(__GLIBC_PREREQ) __GLIBC_PREREQ(2, 16) Yes, that is the correct way, but ensure features.h is being included.