Re: [openssl.org #3435] I updated George Shaw's 0.9.8e port to OS/400 from 2007

2014-07-09 Thread Andy Polyakov via RT
We will try and look at this again at a later time. I'd argue that it would be more appropriate to handle this by giving it a spot at http://www.openssl.org/contrib/. Well, at the same time we should be open to modifications that can *facilitate* ports to exotic platforms. I mean it doesn't have

Re: [openssl.org #3441]

2014-07-09 Thread valentin radulescu via RT
Hi, So It's my understanding that you're talking about things like s_client, genrsa, ... - Yes Those applications don't support multiple connections as far as I know.  Are you saying that you run 2 at the same time and when 1 stops that other fails? - Yes Are you saying that multiple

[patch] AES XTS: supporting custom iv from openssl enc command

2014-07-09 Thread Jitendra Lulla
Hi, openssl enc command with -aes-xxx-xts doesnt work if an IV is specified as below: openssl enc -engine af_alg -aes-256-xts -in plaintext_file -out output_encrypted_file -K 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef -iv I am proposing a

Unit Testing/statically analysing OpenSSL

2014-07-09 Thread Paul Morriss
I am keen to get more involved in the development of OpenSSL, I am curious, has the code been run through a static analysis tool (such as Coverity)? There are self checks, are there unit tests (e.g. Google Test/Mock)created for any part of OpenSSL? Paul

Re: Unit Testing/statically analysing OpenSSL

2014-07-09 Thread Mike Bland
I'm (slowly) helping on the unit testing front. Check out http://wiki.openssl.org/index.php/Unit_Testing and https://groups.google.com/forum/#!forum/openssl-testing for more info. Currently I'm working on trying to refactor bits of the build system, which I hope will make it easier to perform

[openssl.org #3442] [patch] AES XTS: supporting custom iv from openssl enc command

2014-07-09 Thread Jitendra Lulla via RT
Hi, openssl enc command with -aes-xxx-xts doesnt work if an IV is specified as below: openssl enc -engine af_alg -aes-256-xts -in plaintext_file -out output_encrypted_file -K 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef -iv I am proposing a

[openssl.org #3443] [patch] Implement Camellia-CBC suites from RFC6367

2014-07-09 Thread Hubert Kario via RT
RFC6367 describes few cipher suites that can be easily implemented in current openssl Adds ECDH cipher suites that use Camellia cipher in CBC mode Pull request: https://github.com/openssl/openssl/pull/148 -- Regards, Hubert Kario Quality Engineer, QE BaseOS Security team Email:

[openssl.org #3444] [patch] document next protocol negotiation

2014-07-09 Thread Hubert Kario via RT
Add description of -nextprotoneg option to man pages of s_client and s_server Pull request: https://github.com/openssl/openssl/pull/149 -- Regards, Hubert Kario Quality Engineer, QE BaseOS Security team Email: hka...@redhat.com Web: www.cz.redhat.com Red Hat Czech s.r.o., Purkyňova 99/71, 612

Re: Unit Testing/statically analysing OpenSSL

2014-07-09 Thread dcruette
I'm also on the way to create unit tests on the source code basis I'm stuck for the moment on controling the Windows/mingw compile / test process, quite long I must admit ! I'll make feedback as soon as good news are available ! Didier CRUETTE QualiteSys Le 09.07.2014 15:56, Mike Bland a

Re: Unit Testing/statically analysing OpenSSL

2014-07-09 Thread Paul Morriss
It sounds like us three should try and coordinate our efforts. Ideally, once we start getting working tests we can setup a Jenkins server to automate the process. Paul On 2014-07-09 15:42, dcrue...@qualitesys.com wrote: I'm also on the way to create unit tests on the source code basis I'm

Re: Unit Testing/statically analysing OpenSSL

2014-07-09 Thread Ben Laurie
On 9 July 2014 14:38, Paul Morriss paul.morr...@tokenbay.co.uk wrote: I am keen to get more involved in the development of OpenSSL, I am curious, has the code been run through a static analysis tool (such as Coverity)? Coverity do run OpenSSL through their tool. The false positive rate is

Preferred method: email patches or pull requests?

2014-07-09 Thread Mike Bland
I've got a pile of small test/build system commits pending in the following pull requests: test/testutil.h test registry macros https://github.com/openssl/openssl/pull/144 Build environment updates https://github.com/openssl/openssl/pull/145 Should I trickle them into openssl-dev a

Re: Preferred method: email patches or pull requests?

2014-07-09 Thread Kurt Roeckx
On Wed, Jul 09, 2014 at 01:34:07PM -0400, Mike Bland wrote: I've got a pile of small test/build system commits pending in the following pull requests: test/testutil.h test registry macros https://github.com/openssl/openssl/pull/144 Build environment updates

Re: Preferred method: email patches or pull requests?

2014-07-09 Thread Paul Morriss
Is there some form of review process for changes? Paul On 2014-07-09 18:40, Kurt Roeckx wrote: On Wed, Jul 09, 2014 at 01:34:07PM -0400, Mike Bland wrote: I've got a pile of small test/build system commits pending in the following pull requests: test/testutil.h test registry macros

Re: Preferred method: email patches or pull requests?

2014-07-09 Thread Kurt Roeckx
On Wed, Jul 09, 2014 at 07:00:46PM +0100, Paul Morriss wrote: Is there some form of review process for changes? It's described here: http://wiki.openssl.org/index.php/Defect_and_Feature_Review_Process Kurt __ OpenSSL Project

[openssl.org #3445] Server Name Identification is done in case-sensitively

2014-07-09 Thread Hubert Kario via RT
Server Name Indentification extension is compared case-sensitively Steps to reproduce: openssl req -x509 -newkey rsa:2048 -keyout server.key -out server.crt -subj /CN=localhost -nodes -batch openssl req -x509 -newkey rsa:2048 -keyout server2.key -out server2.crt -subj /CN=localhost2 -nodes

[openssl.org #3446] test/testutil.h test registry macros

2014-07-09 Thread Mike Bland via RT
https://github.com/openssl/openssl/pull/144 These macros help standardize the structure of main() and result reporting, providing confirmation that all tests have run, even when they pass. This pull also contains the change to apply these macros to ssl/heartbeat_test.c.

[openssl.org #3447] Build environment updates

2014-07-09 Thread Mike Bland via RT
https://github.com/openssl/openssl/pull/145 This pull contains commits to fix the OS X build and allow GitMake test to pass. __ OpenSSL Project http://www.openssl.org Development Mailing List

Re: Unit Testing/statically analysing OpenSSL

2014-07-09 Thread Theodore Ts'o
On Wed, Jul 09, 2014 at 06:20:49PM +0100, Ben Laurie wrote: On 9 July 2014 14:38, Paul Morriss paul.morr...@tokenbay.co.uk wrote: I am keen to get more involved in the development of OpenSSL, I am curious, has the code been run through a static analysis tool (such as Coverity)? Coverity do

Re: Unit Testing/statically analysing OpenSSL

2014-07-09 Thread dcruette
Ideally to, making a Jenkins CI up and running feed by the nightly Snapshoots would be a good start, with a Linux distrib and a Windows distrib for a start. I could afterwards provide you my custom C/C++ maven sonar plugin (for free for Openssl) for static source code audit. And at last (not

Re: [openssl.org #3442] [patch] AES XTS: supporting custom iv from openssl enc command

2014-07-09 Thread Jitendra Lulla
[with pull request now] Hi, openssl enc command with -aes-xxx-xts doesnt work if an IV is specified as below: openssl enc -engine af_alg -aes-256-xts -in plaintext_file -out output_encrypted_file -K 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef -iv

Re: Unit Testing/statically analysing OpenSSL

2014-07-09 Thread Kurt Roeckx
On Wed, Jul 09, 2014 at 03:33:28PM -0400, Theodore Ts'o wrote: On Wed, Jul 09, 2014 at 06:20:49PM +0100, Ben Laurie wrote: On 9 July 2014 14:38, Paul Morriss paul.morr...@tokenbay.co.uk wrote: I am keen to get more involved in the development of OpenSSL, I am curious, has the code

[openssl.org #3439] Memory leak bug

2014-07-09 Thread Matt Caswell via RT
Fixed: https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=66816c53bea0ecddb9448da7ea9a51a334496127 I think you meant it should be done like this: if ((a-method != NULL) (a-method-destroy != NULL)) a-method-destroy(a); This has been lurking there since SSLeay. In practice I don't think it