[openssl.org #3547] [PATCH] Add missing static qualifier
Add missing static qualifier to constant_time_select_int that was
introduced in 294d1e36c2495ff00e697c9ff622856d3114f14f
--
Kurt Cancemi
https://www.x64architecture.com
From 183bd1581c15a164cc2e511e839452401571f05b Mon Sep 17 00:00:00 2001
From: Kurt Cancemi k...@x64architecture.com
Date: Sun, 28 Sep 2014 15:28:49 -0400
Subject: [PATCH] Add missing static qualifier
---
crypto/constant_time_locl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/constant_time_locl.h b/crypto/constant_time_locl.h
index c048393..7b339a7 100644
--- a/crypto/constant_time_locl.h
+++ b/crypto/constant_time_locl.h
@@ -204,7 +204,7 @@ static inline unsigned char constant_time_select_8(unsigned char mask,
return (unsigned char)(constant_time_select(mask, a, b));
}
-inline int constant_time_select_int(unsigned int mask, int a, int b)
+static inline int constant_time_select_int(unsigned int mask, int a, int b)
{
return (int)(constant_time_select(mask, (unsigned)(a), (unsigned)(b)));
}
--
2.1.1
RE: [openssl-dev] Adding GET support to ocsp app
The decoder does not correctly NUL terminate p when it shrinks by replacing '%xx' with the corresponding octet. Arrgh. Thanks. -- Principal Security Engineer, Akamai Technologies IM: rs...@jabber.me Twitter: RichSalz __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
HOST_c2l warnings...
Building 1.0.2 with gcc 4.9 and no-asm, I get a lot of: ADS -pthread -D_THREAD_SAFE -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -DL_ENDIAN -DTERMIOS -O3 -Wall -c sha256.c In file included from sha256.c:115:0: sha256.c: In function 'sha256_block_data_order': ../md32_common.h:248:41: warning: right-hand operand of comma expression has no effect [-Wunused-value] l|=(((unsigned long)(*((c)++)))), \ ^ sha256.c:243:3: note: in expansion of macro 'HOST_c2l' HOST_c2l(data,l); T1 = X[0] = l; ROUND_00_15(0,a,b,c,d,e,f,g,h); ^ I don't think anything actually uses the value of HOST_c2l, so we could just drop the final comma and make the whole thing (void)? __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
[openssl.org #3548] Remove some unsupported platforms
This ticket is a catch-all for removing a handful of unsupported platforms. This list includes: BEOS NeXT NEWS SUNOS MPE/iX ReliantUNIX SINIX DGUX NCR Tandem Cray WIN16 The intent is that each one will be done as a single commit, separate from all the others, and merged to main one at a time, but to have only one ticket for this first round of general platform reduction. Ticket 3540, BEOS, is being merged into this. This will be done on master, for part of the next release after 1.0.2 -- Rich Salz, OpenSSL dev team; rs...@openssl.org __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
