[openssl-dev] [openssl.org #4685] [PATCH v2] Add missing prototype for FIPS callback

2016-09-26 Thread Dr. Matthias St. Pierre via RT
The call to FIPS_crypto_set_id_callback() was added in revision a43cfd7bb1fc681d563e, but there is no prototype for it in . --- Moved the function prototype upwards, because declarations can only be placed at the top of a function in C. crypto/o_init.c | 5 + 1 file changed, 5 insertions(+

[openssl-dev] [openssl.org #4685] [PATCH] Add missing prototype for FIPS callback

2016-09-26 Thread Dr. Matthias St. Pierre via RT
The call to FIPS_crypto_set_id_callback() was added in revision a43cfd7bb1fc681d563e, but there is no prototype for it in . --- This leads to warnings on some platforms (e.g. x86_64-ncp-linux-gnu-gcc): o_init.c:77:5: warning: implicit declaration of function 'FIPS_crypto_set_id_callback' [-Wimpl

Re: [openssl-dev] [openssl.org #3676] Resolved: [PATCH] Export ASN1 templates for DH and ECDH groups

2016-03-23 Thread Dr. Matthias St. Pierre via RT
> > The fact we don't export the DHparameters item I'd regard as a bug which > > should be fixed. Will the missing export for DHparameters still be fixed for 1.1? Matthias St. Pierre > -Ursprüngliche Nachricht----- > Von: Dr. Matthias St. Pierre via RT [mailto:

Re: [openssl-dev] [openssl.org #3676] Resolved: [PATCH] Export ASN1 templates for DH and ECDH groups

2016-03-09 Thread Dr. Matthias St. Pierre via RT
> According to our records, your request has been resolved. If you have any > further questions or concerns, please respond to this message. Thanks a lot for finally adding the patch. Since our software is not ready for version 1.1 yet, I can't try it directly with the master, but I will backport

Re: [openssl-dev] [openssl.org #3676] [PATCH] Export ASN1 templates for DH and ECDH groups

2016-03-05 Thread Dr. Matthias St. Pierre via RT
> Von: Stephen Henson via RT [mailto:r...@openssl.org] > Gesendet: Samstag, 5. März 2016 17:53 > An: Dr. Matthias St. Pierre > Cc: openssl-dev@openssl.org > Betreff: [openssl.org #3676] [PATCH] Export ASN1 templates for DH and ECDH > groups > > ... > > The fact we don't export the DHparameters ite

Re: [openssl-dev] [openssl.org #3676] [PATCH] Export ASN1 templates for DH and ECDH groups

2016-03-05 Thread Dr. Matthias St. Pierre via RT
Is there any chance that this change will find it's way into OpenSSL 1.1 ? Regards, Matthias St. Pierre -Ursprüngliche Nachricht- Von: Rich Salz via RT [mailto:r...@openssl.org] Gesendet: Mittwoch, 2. März 2016 15:28 An: Dr. Matthias St. Pierre Cc: openssl-dev@openssl.org Betreff: [open

[openssl-dev] [openssl.org #3925] [PATCH] Removed trailing semicolon from macro body of three function-like macros

2015-06-24 Thread Dr. Matthias St. Pierre via RT
The trailing semicolon turned the macros into statements and prevented them from being used in arbitrary expressions. --- include/openssl/bio.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/openssl/bio.h b/include/openssl/bio.h index 7fe88ec..12f59ac 100644 ---

[openssl-dev] [openssl.org #3921] [PATCH] Fix const-correctness issues of new ECDSA_METHOD api

2015-06-22 Thread Dr. Matthias St. Pierre via RT
- The function ECDSA_METHOD_new() acts like a copy constructor, but unfortunately its argument is not declared const. This leads to compiler errors when it is used as follows: ECDSA_METHOD * method = ECDSA_METHOD_new(ECDSA_OpenSSL()); - The ECDSA_METHOD_set_name() should take a 'const ch

[openssl-dev] [openssl.org #3676] [PATCH] Export ASN1 templates for DH and ECDH groups

2015-01-30 Thread Dr. Matthias St. Pierre via RT
From: "Dr. Matthias St. Pierre" Add missing forward declarations and export declarations for DHparams and EC[PK]PARAMETERS. Add public functions to convert between EC_GROUP objects and EC[PK]PARAMETERS objects: EC_GROUP_new_from_ec[pk]parameters(), EC_GROUP_get_ec[pk]parameters(). Signed-off-by

[openssl-dev] [openssl.org #3676] [PATCH] Export ASN1 templates for DH and ECDH groups

2015-01-28 Thread Dr. Matthias St. Pierre via RT
Add missing forward declarations and export declarations for DHparams and EC[PK]PARAMETERS. Add public functions to convert between EC_GROUP objects and EC[PK]PARAMETERS objects: EC_GROUP_new_from_ec[pk]parameters(), EC_GROUP_get_ec[pk]parameters(). Signed-off-by: Dr. Matthias St. Pierre --- cr