[openssl-dev] [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2016-05-09 Thread Matt Caswell via RT
This doesn't seem to be the case any more. Closing. Matt -- Ticket here: http://rt.openssl.org/Ticket/Display.html?id=1833 Please log in as guest with password guest if prompted -- openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-07 Thread Darryl Miles
Stephen Henson via RT wrote: SSL structures should only ever be initialised by calling SSL_new(). Allocating and initialising an SSL structure manually in an application is itself a very non-portable thing to do and requires setting of many undocumented internal fields which will change across

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-06 Thread Darryl Miles
Robin Seggelmann via RT wrote: The latest patch was modified to maintain the previous values of new_session for legacy applications. We can either break compatibility of a few applications, if any, by adding a new field or by adding new values. I don't see any possibility to avoid this at

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-06 Thread Bodo Moeller
On Sep 6, 2010, at 10:39 AM, Darryl Miles wrote: The only user of these field(s) is libssl.so itself. The exact meaning, usage and interpretation of the field(s) is a matter of implementation detail which is encapsulated and presented to the application via the document OpenSSL APIs.

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-06 Thread Bodo Moeller via RT
On Sep 6, 2010, at 10:39 AM, Darryl Miles wrote: The only user of these field(s) is libssl.so itself. The exact meaning, usage and interpretation of the field(s) is a matter of implementation detail which is encapsulated and presented to the application via the document OpenSSL APIs.

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-06 Thread Darryl Miles
Bodo Moeller wrote: Ideally this would be true, but in practice various applications do access some fields directly. The big change to stop that would be to move all the struct details completely out of the externally visible header files. Of course, that change too would be rather painful for

[openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-06 Thread Stephen Henson via RT
[darryl-mailingli...@netbauds.net - Mon Sep 06 13:48:47 2010]: The suggestion I have thrown in, will not alter the meaning of the lowest 2 bits of ssl_st.new_session (between older versions of OpenSSL and future versions of OpenSSL). So it would be possible for a user doing this to

[openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-06 Thread Stephen Henson via RT
[seggelm...@fh-muenster.de - Sun Sep 05 19:44:26 2010]: The latest patch was modified to maintain the previous values of new_session for legacy applications. We can either break compatibility of a few applications, if any, by adding a new field or by adding new values. I don't see

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-05 Thread Robin Seggelmann via RT
On 05.09.2010, at 02:08, Stephen Henson via RT wrote: [seggelm...@fh-muenster.de - Mon Aug 30 16:26:24 2010]: On Aug 27, 2010, at 2:32 PM, Stephen Henson via RT wrote: [seggelm...@fh-muenster.de - Fri Aug 27 11:34:17 2010]: Unfortunately, there was newer code which was not yet covered

[openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-09-04 Thread Stephen Henson via RT
[seggelm...@fh-muenster.de - Mon Aug 30 16:26:24 2010]: On Aug 27, 2010, at 2:32 PM, Stephen Henson via RT wrote: [seggelm...@fh-muenster.de - Fri Aug 27 11:34:17 2010]: Unfortunately, there was newer code which was not yet covered by the patch. This caused an abbreviated

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-08-30 Thread Robin Seggelmann via RT
On Aug 27, 2010, at 2:32 PM, Stephen Henson via RT wrote: [seggelm...@fh-muenster.de - Fri Aug 27 11:34:17 2010]: Unfortunately, there was newer code which was not yet covered by the patch. This caused an abbreviated handshake to fail. Applied now, thanks. Note that since we need to

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-08-30 Thread Darryl Miles
Robin Seggelmann via RT wrote: Note that since we need to retain binary compatibility between 1.0.0 and 1.0.1 we will need to either avoid having to add a new field to ssl.h or move it to the end of the structure. As things are any application accessing a field after the new member would

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-08-30 Thread Darryl Miles via RT
Robin Seggelmann via RT wrote: Note that since we need to retain binary compatibility between 1.0.0 and 1.0.1 we will need to either avoid having to add a new field to ssl.h or move it to the end of the structure. As things are any application accessing a field after the new member would

[openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-08-27 Thread Stephen Henson via RT
[seggelm...@fh-muenster.de - Fri Aug 27 11:34:17 2010]: Unfortunately, there was newer code which was not yet covered by the patch. This caused an abbreviated handshake to fail. Applied now, thanks. Note that since we need to retain binary compatibility between 1.0.0 and 1.0.1 we will

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-08-26 Thread Robin Seggelmann via RT
Updated version. The variable new_session is now set during a full handshake as before, to avoid breaking applications which access it directly instead using SSL_renegotiate_pending() to determine whether a handshake is in progress. --- ssl/d1_clnt.c 26 Jan 2010 19:46:29 -

Re: [openssl.org #1833] [PATCH] Abbreviated Renegotiations

2010-06-17 Thread Robin Seggelmann via RT
Here is an up to date version of the patch for OpenSSL 1.0.1. This patch adds the new variable 'renegotiate' to the SSL struct. Until now the variable 'new_session' is used to indicate if a renegotiation is in progress AND if a new session has to be created, i.e. a full handshake has to be

[openssl.org #1833] [PATCH] Abbreviated Renegotiations

2009-04-16 Thread Robin Seggelmann via RT
Updated version for compatibility with 1.0.0beta1: --- ssl/d1_clnt.c 2008-06-02 00:33:24.0 +0200 +++ ssl/d1_clnt.c 2009-04-16 09:41:59.0 +0200 @@ -169,7 +169,7 @@ switch(s-state) { case SSL_ST_RENEGOTIATE: -

[openssl.org #1833] [PATCH] Abbreviated Renegotiations

2009-01-30 Thread Robin Seggelmann via RT
Whenever a handshake is initiated, the variable s-new_session is set to indicate that a handshake is being performed. This is not the correct context because a handshake can also be abbreviated and will not create a new session then. This variable is also used in the right context to