Re: [CVS] OpenSSL: OpenSSL_1_0_1-stable: openssl/crypto/ cryptlib.c

2012-09-18 Thread Ben Laurie
On Mon, Sep 17, 2012 at 6:24 PM, Bodo Moeller b...@openssl.org wrote: OpenSSL CVS Repository http://cvs.openssl.org/ Server: cvs.openssl.org Name: Bodo Moeller Root: /v/openssl/cvs

Re: [CVS] OpenSSL: OpenSSL_1_0_1-stable: openssl/crypto/ cryptlib.c

2012-09-18 Thread Ben Laurie
On Tue, Sep 18, 2012 at 9:47 AM, Ben Laurie b...@links.org wrote: On Mon, Sep 17, 2012 at 6:24 PM, Bodo Moeller b...@openssl.org wrote: OpenSSL CVS Repository http://cvs.openssl.org/ Server:

Re: [CVS] OpenSSL: OpenSSL_1_0_1-stable: openssl/crypto/ cryptlib.c

2012-09-18 Thread Bodo Moeller
Doh. I see it doesn't write to it. Nevertheless, seems like a bad piece of code - its assuming errno is thread local, right? This code uses the address of errno as a default thread ID for OpenSSL purposes. This works precisely because you typically have something like #define errno