[openssl-dev] [openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2016-02-06 Thread Rich Salz via RT
Can't reproduce it. Maybe the machine that had the problem got infected by aliens or something :) Please open a new ticket if needed. -- Rich Salz, OpenSSL dev team; rs...@openssl.org -- Ticket here: http://rt.openssl.org/Ticket/Display.html?id=3344 Please log in as guest with password guest if

[openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-06-01 Thread Matt Caswell via RT
On Thu May 29 08:28:24 2014, noloa...@gmail.com wrote: Matt - I have not forgot about this I can't find the machine I wrote the code on (my place probably looks a lot like your place - different computers and laptops with different OSes all over the place). My place does look a bit like

Re: [openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-05-29 Thread noloa...@gmail.com via RT
Matt - I have not forgot about this I can't find the machine I wrote the code on (my place probably looks a lot like your place - different computers and laptops with different OSes all over the place). Looking at the return values, I don't believe Test 3 should have failed. Also, add a

Re: [openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-05-29 Thread Jeffrey Walton
Matt - I have not forgot about this I can't find the machine I wrote the code on (my place probably looks a lot like your place - different computers and laptops with different OSes all over the place). Looking at the return values, I don't believe Test 3 should have failed. Also, add a

[openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-05-19 Thread Matt Caswell via RT
Hi Jeff Do you have an update on this, as per my last message? Thanks Matt __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org

[openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-05-14 Thread Matt Caswell via RT
Hi Jeff Hmmm, I cannot reproduce this. Using the attached as a test case I see the following output (i.e. no crashes): Test one Return code 0 Test two NULL 1 (0x1) Return code 1 Test three Return code 0 Test four 1 (0x1) Return code 1 The NULL bio should be checked ultimately in BIO_write

[openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-05-05 Thread noloa...@gmail.com via RT
PATCH: don't crash or fail in ASN1_print from crypto/asn1/t_pkey.c. ASN1_print crashes if the BIO is NULL. ASN1_print crashes if the label is NULL. ASN1_print fails *if* the label is empty (i.e., ). This patch fixes the three issues by validating the BIO pointer and providing an alternate

RE: [openssl.org #3344] PATCH: don't crash or fail in ASN1_print from t_pkey.c

2014-05-05 Thread Salz, Rich
I dunno about this. Fprintf(NULL, ... Crashes... And shows that you didn't check back at the fopen call. -- Principal Security Engineer Akamai Technologies, Cambridge, MA IM: rs...@jabber.me; Twitter: RichSalz