[openssl.org #3603] EVP_DecryptFinal_ex error in case of padding failure

2014-11-17 Thread Kurt Roeckx via RT
Hi, I've received the attached patch to make EVP_DecryptFinal_ex call EVPerr() in case of an error. I'm not sure if not calling EVPerr() is intentional or not. Background: http://bugs.debian.org/768681, nodejs's test suite fails because it's not getting the error anymore. Kurt From: William

RE: [openssl.org #3603] EVP_DecryptFinal_ex error in case of padding failure

2014-11-17 Thread Salz, Rich
I've received the attached patch to make EVP_DecryptFinal_ex call EVPerr() in case of an error. I think that unless Emilia (or other constant-time expert) agrees, then the current behavior makes the right trade-off. It sacrifies some level of error detail in favor of protecting against a