The new prime generator does not ensure that generated primes are
safe modulo 2, 3, 5, 7 or 11. In particular (p-1)/2 might not
be co-prime to 2310.
The patch below my signature addresses this problem.
--
Viktor.
diff --git a/crypto/bn/bn_prime.c b/crypto/bn/bn_prime.c
index
On Sun, Jun 01, 2014 at 08:14:00PM +, Viktor Dukhovni wrote:
The new prime generator does not ensure that generated primes are
safe modulo 2, 3, 5, 7 or 11. In particular (p-1)/2 might not
be co-prime to 2310.
The patch below my signature addresses this problem.
Oops, previous patch
You didn't update the test...
On 1 June 2014 21:26, Viktor Dukhovni openssl-us...@dukhovni.org wrote:
On Sun, Jun 01, 2014 at 08:14:00PM +, Viktor Dukhovni wrote:
The new prime generator does not ensure that generated primes are
safe modulo 2, 3, 5, 7 or 11. In particular (p-1)/2 might
On Sun, Jun 01, 2014 at 09:45:15PM +0100, Ben Laurie wrote:
You didn't update the test...
You're right. The below should take care of that.
--
Viktor.
diff --git a/crypto/bn/bn_prime.c b/crypto/bn/bn_prime.c
index 2d66b61..df50305 100644
--- a/crypto/bn/bn_prime.c
+++
On Sun, Jun 01, 2014 at 09:04:29PM +, Viktor Dukhovni wrote:
@@ -1,21 +1,37 @@
-primes = [2, 3, 5, 7, 11]
-safe = False # Not sure if the period's right on safe primes.
+# Odd primes 13
+#
+primes = [3, 5, 7, 11, 13, 17, 19]
Maybe the comment is wrong?
Kurt
On Sun, Jun 01, 2014 at 11:12:53PM +0200, Kurt Roeckx wrote:
On Sun, Jun 01, 2014 at 09:04:29PM +, Viktor Dukhovni wrote:
@@ -1,21 +1,37 @@
-primes = [2, 3, 5, 7, 11]
-safe = False # Not sure if the period's right on safe primes.
+# Odd primes 13
+#
+primes = [3, 5, 7, 11, 13,
Only just joined the list and I see that there's been some follow up
stuff to my contribution, but I submitted a follow up pull request to
some of this stuff on GitHub
(https://github.com/openssl/openssl/pull/118). So probably some
duplication there :).
--
Felix - http://www.erbridge.co.uk/
On
