Re: OPENSSL_gmtime on platforms that don't have a safe gmtime function

2006-08-13 Thread Corinna Vinschen
On Aug 11 12:29, Joe Gluck wrote: The OPENSSL_gmtime in o_time.c (that gets called from other places like ASN1_UTCTIME_cmp_time_t in a_utctm.c) does not use the safe version of gmtime in lots of platforms including: OPENSSL_SYS_WIN32 OPENSSL_SYS_OS2 __CYGWIN32__ OPENSSL_SYS_MACOSX

RE: OPENSSL_gmtime on platforms that don't have a safe gmtime function

2006-08-12 Thread Stefan . Neis
Hi, why not use mutexes to wrap the gmtime and memcpy, like other places in the library? Because it is either needless or insufficient. (snipp) On platforms where thread-specific data is not used, the mutexes would not prevent other code (not part of OpenSSL) from calling

Re: OPENSSL_gmtime on platforms that don't have a safe gmtime function

2006-08-12 Thread Joe Gluck
All, David cam up with a solution that looks to me as some thing that would be really nice, he suggested that OpenSSL would allow the developer to register a callback function to do the unsafe functions. However while he thinks OpenSSL should default to the OS 'best' function available, I am

OPENSSL_gmtime on platforms that don't have a safe gmtime function

2006-08-11 Thread Joe Gluck
The OPENSSL_gmtime in o_time.c (that gets called from other places like ASN1_UTCTIME_cmp_time_t in a_utctm.c) does not use the safe version of gmtime in lots of platforms including:OPENSSL_SYS_WIN32OPENSSL_SYS_OS2 __CYGWIN32__OPENSSL_SYS_MACOSXOPENSSL_SYS_SUNOS This could cause problems in

RE: OPENSSL_gmtime on platforms that don't have a safe gmtime function

2006-08-11 Thread David Schwartz
The OPENSSL_gmtime in o_time.c (that gets called from other places like ASN1_UTCTIME_cmp_time_t in a_utctm.c) does not use the safe version of gmtime in lots of platforms including: OPENSSL_SYS_WIN32 OPENSSL_SYS_OS2 __CYGWIN32__ OPENSSL_SYS_MACOSX OPENSSL_SYS_SUNOS This could cause problems in