RE: RE: Change needed for "-DPURIFY" builds.

2010-01-08 Thread Kevin Regan
. --Kevin From: Kevin Regan Sent: Friday, January 08, 2010 10:53 AM To: 'openssl-dev@openssl.org' Subject: RE: Change needed for "-DPURIFY" builds. >> You're missing the point -- your comment is the height of irony, in a >> way. >> >> Use a suppression

RE: Change needed for "-DPURIFY" builds.

2010-01-08 Thread Kevin Regan
>> You're missing the point -- your comment is the height of irony, in a >> way. >> >> Use a suppression to make Valgrind shut up. >> >> /r$ > > I think you misunderstand his issue. His issue is not "valgrind reports a > spurious error/warning". His issue is "-DPURIFY does not do what I thi

RE: Change needed for "-DPURIFY" builds.

2010-01-04 Thread David Schwartz
Allan K Pratt wrote: > EASY FIX: wherever RAND_add is defined (macro? function?), give it a > different body for -DPURIFY builds. When PURIFY is defined, don't use > the > memory being passed in at all. This sounds extreme, but it should work. > Sure, the entropy factors will change and the result

RE: Change needed for "-DPURIFY" builds.

2010-01-04 Thread Allan K Pratt
As a developer on the PurifyPlus product at IBM, I'd like to contribute a Purify usage note to this discussion. I see that the issue is RAND_add using whatever memory it's given (some of which can be uninitialized garbage) as entropy input for the random number generator. Tools like Purify repo

RE: Change needed for "-DPURIFY" builds.

2010-01-02 Thread David Schwartz
> You're missing the point -- your comment is the height of irony, in a > way. > > Use a suppression to make Valgrind shut up. > > /r$ I think you misunderstand his issue. His issue is not "valgrind reports a spurious error/warning". His issue is "-DPURIFY does not do what I think it's s

Re: Change needed for "-DPURIFY" builds.

2010-01-02 Thread Kurt Roeckx
On Sat, Jan 02, 2010 at 10:29:38AM -0500, Richard Salz wrote: > I took a closer look at current valgrind and the client requests. I > assume you mean doing something like this: > > if (VG_USERREQ__RUNNING_ON_VALGRIND) memset(&st, 0, sizeof st); > > It might be a nuisance to fix these, b

Re: Change needed for "-DPURIFY" builds.

2010-01-02 Thread Richard Salz
I took a closer look at current valgrind and the client requests. I assume you mean doing something like this: if (VG_USERREQ__RUNNING_ON_VALGRIND) memset(&st, 0, sizeof st); It might be a nuisance to fix these, but at least it keeps the code more correct. Right? (Separating valgrind

Re: Change needed for "-DPURIFY" builds.

2010-01-02 Thread Kurt Roeckx
On Fri, Jan 01, 2010 at 11:50:29PM -0500, Richard Salz wrote: > You're missing the point -- your comment is the height of irony, in a way. > > Use a suppression to make Valgrind shut up. Maybe you should try to suppress that in valgrind before telling us what to do. Try running a simple program

Re: Change needed for "-DPURIFY" builds.

2010-01-01 Thread Richard Salz
You're missing the point -- your comment is the height of irony, in a way. Use a suppression to make Valgrind shut up. /r$ -- STSM, WebSphere Appliance Architect https://www.ibm.com/developerworks/mydeveloperworks/blogs/soma/ _