[openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-26 Thread Richard Levitte via RT
Frankly, you did all the work. With your analysis, it became very easy to figure out what needed to be done. Low hanging fruit ;-) So, thank you! Cheers, Richard Vid Sat, 26 Mar 2016 kl. 02.38.47, skrev craigbe...@mac.com: > Wow, that was fast. The patch looks good here: now all tests pass on >

Re: [openssl-dev] [openssl.org #4483] Wrong results with Poly1305 functions

2016-03-26 Thread David Benjamin via RT
On Fri, Mar 25, 2016 at 3:26 PM David Benjamin wrote: > Right. What I meant is that a fully reduced h has $h2 < 4. Is it possible > that $h2, after that adc, ends up at 4, exceeding that bound? If it were, > that would require one more reduction. > > In the non-SIMD paths, I

[openssl-dev] Testing for a type with a define in e_os2.h?

2016-03-26 Thread Jeffrey Walton
e_os2.h has this around line 260: # if defined(OPENSSL_SYS_UEFI) && !defined(ssize_t) # define ossl_ssize_t int # define OSSL_SSIZE_MAX INT_MAX # endif I don't believe you can test for a type by using 'defined(t)'. Also see

Re: [openssl-dev] [openssl.org #4472] [PATCH] alllowing wrap mode using enc command

2016-03-26 Thread Michel via RT
And attached a better patch, with updated documentation and some test data. -Message d'origine- De : openssl-dev [mailto:openssl-dev-boun...@openssl.org] De la part de Michel via RT Envoyé : samedi 26 mars 2016 17:21 Cc : openssl-dev@openssl.org Objet : Re: [openssl-dev] [openssl.org

Re: [openssl-dev] Testing for a type with a define in e_os2.h?

2016-03-26 Thread Viktor Dukhovni
On Sat, Mar 26, 2016 at 06:14:05PM -0400, Jeffrey Walton wrote: > e_os2.h has this around line 260: > > # if defined(OPENSSL_SYS_UEFI) && !defined(ssize_t) > # define ossl_ssize_t int > # define OSSL_SSIZE_MAX INT_MAX > # endif > > I don't believe you can test for a type by using

Re: [openssl-dev] [openssl.org #4472] [PATCH] alllowing wrap mode using enc command

2016-03-26 Thread Michel via RT
Hi, Here is an updated patch which prevents 'unstreamable' modes (Wrap only for the moment) to be streamed, while still allowing them to be encrypted or decrypted if the internal buffer size is greater than the total data size. Looks to work just fine to me, but I can still try to improve it

Re: [openssl-dev] AF_ALG engine support and kernel versions

2016-03-26 Thread Jeffrey Walton
On Thu, Mar 17, 2016 at 11:38 PM, Jeffrey Walton wrote: > Hi Everyone, > > Looking at the code in engines/afalg/e_afalg.c, there is the following: > > ... > #define K_MAJ 4 > #define K_MIN1 1 > #define K_MIN2 0 > #if LINUX_VERSION_CODE <= KERNEL_VERSION(K_MAJ,

[openssl-dev] Add cross-compile helpers to official OpenSSL sources?

2016-03-26 Thread Jeffrey Walton
OpenSSL has a few scripts it uses for platforms like Android and iOS. In addition, there are other helper scripts like incore_macho used on the platforms. As far as I know, the bits are not under version control. They are available from the OpenSSL website once you know where to look. There are

Re: [openssl-dev] Testing for a type with a define in e_os2.h?

2016-03-26 Thread Richard Levitte
In message on Sat, 26 Mar 2016 18:14:05 -0400, Jeffrey Walton said: noloader> e_os2.h has this around line 260: noloader> noloader> # if defined(OPENSSL_SYS_UEFI) && !defined(ssize_t) noloader> # define

Re: [openssl-dev] Testing for a type with a define in e_os2.h?

2016-03-26 Thread Jeffrey Walton
On Sat, Mar 26, 2016 at 11:10 PM, Richard Levitte wrote: > In message > on Sat, > 26 Mar 2016 18:14:05 -0400, Jeffrey Walton said: > > noloader> e_os2.h has this around line 260: >

[openssl-dev] no-ui, warnings and errors

2016-03-26 Thread Jeffrey Walton
Is this a supported configuration (no-ui and apps)? There's a fair number of warnings when configuring with no-ui: apps/enc.c:357:13: warning: implicit declaration of function ‘EVP_read_pw_string’ [-Wimplicit-function-declaration] i = EVP_read_pw_string((char *)strbuf, SIZE, prompt,

Re: [openssl-dev] Testing for a type with a define in e_os2.h?

2016-03-26 Thread Jeffrey Walton
On Sat, Mar 26, 2016 at 6:44 PM, Viktor Dukhovni wrote: > On Sat, Mar 26, 2016 at 06:14:05PM -0400, Jeffrey Walton wrote: > >> e_os2.h has this around line 260: >> >> # if defined(OPENSSL_SYS_UEFI) && !defined(ssize_t) >> # define ossl_ssize_t int >> # define

[openssl-dev] LHASH, -Wcast-align and the union (redux)

2016-03-26 Thread Jeffrey Walton
I'm on CentOS 5 with GCC 4.1.2. It appears there are side effects to the union for the down level compiler. Removing the union squashes the warning, but I like Viktor's idea and placing a few of the larger types in it. I think its safer in the long run. Naming the union squashes the warning. The

Re: [openssl-dev] [openssl.org #4479] ROLLUP PATCH: OS X 10.8 (x86_64): Compile errors when using "no-asm -ansi"

2016-03-26 Thread noloa...@gmail.com via RT
The rollup was updated to include both -ansi and -std=c90. Nearly all the pieces were available to support it. The patch simply needed better integration with existing library facilities. For example, there's an OPENSSL_strdup() for strdup(), there's workarounds for strncmpcase() that performs

Re: [openssl-dev] [openssl.org #4479] ROLLUP PATCH: OS X 10.8 (x86_64): Compile errors when using "no-asm -ansi"

2016-03-26 Thread Jeffrey Walton
The rollup was updated to include both -ansi and -std=c90. Nearly all the pieces were available to support it. The patch simply needed better integration with existing library facilities. For example, there's an OPENSSL_strdup() for strdup(), there's workarounds for strncmpcase() that performs

Re: [openssl-dev] [openssl.org #4480] ROLLUP PATCH: Ubuntu 14 (x86_64): Compile errors and warnings when using "no-asm -ansi"

2016-03-26 Thread noloa...@gmail.com via RT
The rollup was updated to include both -ansi and -std=c90. Nearly all the pieces were available to support it. The patch simply needed better integration with existing library facilities. For example, there's an OPENSSL_strdup() for strdup(), there's workarounds for strncmpcase() that performs

Re: [openssl-dev] [openssl.org #4480] ROLLUP PATCH: Ubuntu 14 (x86_64): Compile errors and warnings when using "no-asm -ansi"

2016-03-26 Thread Jeffrey Walton
The rollup was updated to include both -ansi and -std=c90. Nearly all the pieces were available to support it. The patch simply needed better integration with existing library facilities. For example, there's an OPENSSL_strdup() for strdup(), there's workarounds for strncmpcase() that performs