Our intent is that all FREE functions can handle NULL. If you find things
missing or undocumented, please open an issue on GitHub. Thanks!
--
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
On 12/22/2017 9:24 AM, Salz, Rich via openssl-users wrote:
if (ptr!= NULL) free(ptr);
That shouldn’t be necessary for OpenSSL. If you find places where it is, please open an issue.
OK. I'll mention a few, but it's a global issue.
The code may handle NULL. However,
> if (ptr!= NULL) free(ptr);
That shouldn’t be necessary for OpenSSL. If you find places where it is,
please open an issue.
➢ BTW, "can handle" should explicitly say what happens. Perhaps use the C
library text, which says:
If ptr is NULL, no operation is
On Fri, Dec 22, 2017 at 09:30:19AM -0500, Ken Goldman wrote:
> On 12/22/2017 9:24 AM, Salz, Rich via openssl-users wrote:
> > > if (ptr!= NULL) free(ptr);
> > That shouldn’t be necessary for OpenSSL. If you find places where it is,
> > please open an issue.
>
> OK. I'll mention a few, but
On 12/22/2017 9:59 AM, Salz, Rich via openssl-dev wrote:
I think we fixed all such cases in 1.1.0, all *_free()
functions should handle NULL. I don't think we backported to changes
to 1.0.2.
Yes, and we fixed the documentation. I backported all/most of them
to 1.0.2 to make cherry-picking
Hi,
I think it should be documented, but currently the two supported
branches are ok with NULL:
- following from IMPLEMENT_ASN1_FUNCTIONS(X509), for both
openssl-1.0.2n and 1.1.0g:
- 1.0.2n ends up in asn1_item_combine_free()
- 1.1.0g ends up in asn1_item_embed_free()
- in both cases an explicit
➢So it's guaranteed for 1.1, mostly guaranteed for recent 1.0.2, but not
guaranteed for older 1.0.2.
yes.
➢ I also think it would be good to backport all to 1.0.2
Yes. I believe I did that, but I am not absolutely 100% positive.
--
openssl-dev mailing list
To unsubscribe:
On Fri, Dec 22, 2017 at 01:06:20PM +, Salz, Rich via openssl-dev wrote:
> Our intent is that all FREE functions can handle NULL. If you find things
> missing or undocumented, please open an issue on GitHub. Thanks!
I think we fixed all such cases in 1.1.0, all *_free() functions
should
➢ I think we fixed all such cases in 1.1.0, all *_free() functions
should handle NULL. I don't think we backported to changes to 1.0.2.
Yes, and we fixed the documentation. I backported all/most of them to 1.0.2 to
make cherry-picking easier. I don’t know if I changed the docs.
