Re: [openssl.org #1452] OpenSSL 0.9.7l make install syntax error

[Alain Guibert via RT]

Hello Andy,

 On Saturday, October 13, 2007 at 13:13:22 +0200, Andy Polyakov via RT wrote:

 this was eventually fixed. thanks for report. a.

This syntax error problem is still present in latest 0.9.7m release, but
is indeed fixed in the CVS 0.9.7 branch. And it never impacted the 0.9.8
branch nor HEAD. Much thanks to you!


Alain.


__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   [EMAIL PROTECTED]

[openssl.org #1452] OpenSSL 0.9.7l make install syntax error

[Andy Polyakov via RT]

this was eventually fixed. thanks for report. a.


__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   [EMAIL PROTECTED]

[openssl.org #1452] OpenSSL 0.9.7l make install syntax error

[Alain Guibert via RT]

Hello,

When doing make install in OpenSSL 0.9.7l, there is a syntax error,
some apps are not installed, but Makefile still continues:

| # make install
| [...]
| installing apps...
| make[1]: Entering directory `/tmp/openssl-0.9.7l/apps'
| /bin/sh: -c: line 1: syntax error near unexpected token `;'
| /bin/sh: -c: line 1: `for i in openssl;  do   (echo installing $i;  cp $i 
/usr/local/bin/$i.new;  chmod 755 /usr/local/bin/$i.new;  mv -f  
/usr/local/bin/$i.new  /usr/local/bin/$i;  ) done;'
| make[1]: *** [install] Error 2
| make[1]: Leaving directory `/tmp/openssl-0.9.7l/apps'
| installing test...
| make[1]: Entering directory `/tmp/openssl-0.9.7l/test'
| make[1]: Nothing to be done for `install'.
| make[1]: Leaving directory `/tmp/openssl-0.9.7l/test'
| installing tools...
| make[1]: Entering directory `/tmp/openssl-0.9.7l/tools'
| make[1]: Leaving directory `/tmp/openssl-0.9.7l/tools'
| installing libcrypto.a
| installing libssl.a
| cp openssl.pc /tmp/ossl/lib/pkgconfig
| chmod 644 /tmp/ossl/lib/pkgconfig/openssl.pc


Syntax error seems to be a misplaced semicolon in shell syntax inside
apps/Makefile. Schematically the bad:

| for i in list; do (commands) done;

Instead of the correct:

| for i in list; do (commands); done

The attached patch fixes that. Problem seen in 0.9.7[hijkl], absent in
0.9.7g and before. Problem absent in 0.9.8*, but there is still a
useless semicolon after the done.


Alain.
__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   [EMAIL PROTECTED]