Correct, it has no way to know if something has been put into ready to
merge deliberately despite it failing checks etc so it won't mess with
removing the label.
Mark
On Wed, Feb 12, 2020 at 10:39 AM Dr. Matthias St. Pierre
wrote:
>
> > check. It will not move to 'ready to merge' state automati
> check. It will not move to 'ready to merge' state automatically
> unless (or until) all CI passes. (I'll do a PR for the tool with that
> change shortly).
If the does not automatically remove the "ready to merge" label, but only
refrains from setting it automatically, that's a good compromise
I thought about it some more and Kurt is right. Something shouldn't
be in "Ready to Merge" unless it's actually ready to merge. For
example 10993. This PR shouldn't be ever automatically moved to ready
to merge because it failed CI. A human has determined it is ready to
merge and applied the la
> > Does it also check that the CI says that everything is OK?
>
> Do we want it to? I assumed that Approval: done was not being applied
> unless tests past (but looking that's not always the case). Can we
> assume that something in "approval: ready to merge" but that failed CI
> won't get merged?
> Does it also check that the CI says that everything is OK?
Do we want it to? I assumed that Approval: done was not being applied
unless tests past (but looking that's not always the case). Can we
assume that something in "approval: ready to merge" but that failed CI
won't get merged? Otherwise
On Sat, Feb 08, 2020 at 03:56:19PM +, Mark J Cox wrote:
> So right now here's what it does:
>
> Every hour it looks at open PRs that are labelled "approval: done".
> If 24 hours has elapsed since that label was assigned and if there
> have been no comments made to the PR since the label was as
I've seen some projects enjoying https://github.com/apps/stale, though
its focus is not so much relabelling things that are ready, but
closing things that are not active, which might not be relevant here.
On Sun, Feb 9, 2020 at 2:23 AM Mark J Cox wrote:
>
> Okay, I'll leave things as they are wit
Okay, I'll leave things as they are with those issues and just add the
addition of notification on urgent labels.
As to the earlier question form the thread as why this isn't a github
automation: the actual reason I was writing the script was to get some
on-demand statistics for my own interest an
On 08/02/2020 15:56, Mark J Cox wrote:
> I've currently got a cron job running every hour that looks at open PR
> requests against github openssl repo and does various actions. So if
> you were wondering why I was altering labels and making comments at
> 4am, now you know. No doubt we'll use s
Please don’t automatically drop the "appoval: done" label after a comment. I
feel that is not uncommon for comments to be added that in no way invalidate
the approval.
I agree with not switching to “ready to merge” if there are comments — manual
intervention in this case is required to judge t
> -Original Message-
> From: openssl-project On Behalf Of Mark
> J Cox
> Sent: Saturday, February 8, 2020 8:52 PM
> To: Dmitry Belyavsky
> Cc: openssl-project@openssl.org
> Subject: Re: Github PR label automation
>
> Thanks Dmitry; I hope that the comment tr
First of all, thank you Mark for implementing the notification daemon. You did
a great job
and I think it's very useful. Here are some comments and thoughts about your
last mail.
> No doubt we'll use some tool user for this in the future.
Can't you just use an API-token generated for the opens
Thanks Dmitry; I hope that the comment triggers notifications to the
creator without mentioning them? (let me know if you get something
changed labels that doesn't) Mark
On Sat, Feb 8, 2020 at 4:57 PM Dmitry Belyavsky wrote:
>
> Dear Mark,
>
> Thank you for a nice job!
>
> As the reviewers are
Dear Mark,
Thank you for a nice job!
As the reviewers are expected to commit the PRs, could you also add the
reviewers' names as a part of the notification?
On Sat, Feb 8, 2020 at 6:56 PM Mark J Cox wrote:
> I've currently got a cron job running every hour that looks at open PR
> requests agai
I've currently got a cron job running every hour that looks at open PR
requests against github openssl repo and does various actions. So if
you were wondering why I was altering labels and making comments at
4am, now you know. No doubt we'll use some tool user for this in the
future.
So right no
15 matches
Mail list logo
