On Mon, Feb 05, 2018 at 08:43:04PM +0100, Dr. Matthias St. Pierre wrote:
>
>
> Am 05.02.2018 um 19:13 schrieb Salz, Rich:
> >
> >
> > Do not put a size after sizeof; do use parens.
> >
>
> nit: Do not put a /space /after sizeof.
>
> >
> >
> > Treat a single-statement with comment as if it
* nit: Do not put a space after sizeof.
fixed.
* Wasn't there also the suggestion by someone that if one part of an
if-else statements needs braces that the other part should get some, too?
It already says that.
___
openssl-project mailing
On 05/02/18 19:43, Dr. Matthias St. Pierre wrote:
>
> Wasn't there also the suggestion by someone that if one part of an
> if-else statements needs braces that the other part should get some, too?
That's already in the style guide:
Do not unnecessarily use braces around a single statement:
Am 05.02.2018 um 19:13 schrieb Salz, Rich:
>
>
> Do not put a size after sizeof; do use parens.
>
nit: Do not put a /space /after sizeof.
>
>
> Treat a single-statement with comment as if it were multi-line and use
> curly braces
>
>
>
> if (test()) {
>
>
➢ In general we should prefer ossl_assert over assert. Never use
OPENSSL_assert() in libcrypto or libssl.
Maybe that’s all to put into the guide, then.
___
openssl-project mailing list
openssl-project@openssl.org