Re: Cleaning up include file inconsistencies

2019-07-07 Thread Dr. Matthias St. Pierre
I am beginning to wonder whether it is a good idea to make the fact whether a private header file contains exported symbols as selection criterion for where the header file needs to go in the source tree: > > - headers in `include/internal` > > For internal things that we want to make

Re: Cleaning up include file inconsistencies

2019-07-06 Thread Dr. Matthias St. Pierre
> > ./crypto/include/internal/store.h > > ./crypto/include/internal/store_int.h > ... > > I have *no* idea why there are two header files. I must have > forgotten about one of them when creating the other... > > They should be merged into one. Ok, I can take care of it. Matthias

Re: Cleaning up include file inconsistencies

2019-07-06 Thread Dmitry Belyavsky
Hello, I'd like either _lcl.h or _local.h. _locl.h seems weird to me :) On Sat, Jul 6, 2019 at 10:32 AM Dr. Matthias St. Pierre < matthias.st.pie...@ncp-e.com> wrote: > Hi all, > > pull request #9274 started out as a task to clean up inconsistencies in > the naming > of the include guards. It