Re: AW: Build failures on master?!
On 18/11/2019 22:29, Dr. Matthias St. Pierre wrote: >>> The last 19 commits on https://github.com/openssl/openssl/commits/master, >>> starting from Nov 14 have a red cross from the CIs. What's going on again? >>> My personal impression is that builds on master are failing 50% of the time. >> >> The builds on master have been failing for *much* longer than that. They >> should be succeeded on the PRs, but its the extended tests that fail. > > Yes I know. I was just counting the last consecutive failures. What actually > wonders > me is the fact that the tests do not fail throughout. In between there are > always short > periods where the tests succced. Why is this? Really? I don't see that. The travis dashboard shows red for as far back as I checked: https://travis-ci.org/openssl/openssl/builds Matt > > The reason why I issued this cry for help is because after watching it for a > long time I > got the impression that due to the ongoing failures everybody has become dull > and > indifferent agains the red crosses. > > Matthias >
AW: Build failures on master?!
> > The last 19 commits on https://github.com/openssl/openssl/commits/master, > > starting from Nov 14 have a red cross from the CIs. What's going on again? > > My personal impression is that builds on master are failing 50% of the time. > > The builds on master have been failing for *much* longer than that. They > should be succeeded on the PRs, but its the extended tests that fail. Yes I know. I was just counting the last consecutive failures. What actually wonders me is the fact that the tests do not fail throughout. In between there are always short periods where the tests succced. Why is this? The reason why I issued this cry for help is because after watching it for a long time I got the impression that due to the ongoing failures everybody has become dull and indifferent agains the red crosses. Matthias
Re: Build failures on master?!
On 18/11/2019 21:48, Dr. Matthias St. Pierre wrote: > The last 19 commits on https://github.com/openssl/openssl/commits/master, > starting from Nov 14 have a red cross from the CIs. What's going on again? > My personal impression is that builds on master are failing 50% of the time. The builds on master have been failing for *much* longer than that. They should be succeeded on the PRs, but its the extended tests that fail. > > It is really tedious to check pull requests for build errors just to find > that those errors > are well known failures from master. In particular, the krb5 an pyca tests > are notoriously > failing. Are there any plans to fix them or disable them? The build failures mostly come from the external tests (or that was the case I haven't checked recently). The problem with these is that, on occasion we need the maintainers of these packages to help us track down a problem. Or in some cases we actually need them to make a change (for example because something changed on master which revealed that they were relying on some behaviour in master which they really shouldn't be relying on). Once one of them is failing then multiple errors can build up and they get masked by the earlier failure. I'll try and find some time to take another pass at the current failures. I suspect the answer might be to disable some of the external tests. Matt > > 95-test_external_krb5.t (Wstat: 256 Tests: 1 Failed: 1) > 95-test_external_pyca.t (Wstat: 256 Tests: 1 Failed: 1) > > Clean builds on master should have highest priority. Because if there are too > many red > crosses, nobody cares about them anymore. > > Matthias > >
Re: Build failures on master?!
On Mon, Nov 18, 2019 at 09:48:38PM +, Dr. Matthias St. Pierre wrote: > The last 19 commits on https://github.com/openssl/openssl/commits/master, > starting from Nov 14 have a red cross from the CIs. What's going on again? I have filed 2 issues on Nov 9 that that caused the CIs to fail, that that haven't been closed yet. > My personal impression is that builds on master are failing 50% of the time. > > It is really tedious to check pull requests for build errors just to find > that those errors > are well known failures from master. In particular, the krb5 an pyca tests > are notoriously > failing. Are there any plans to fix them or disable them? > > 95-test_external_krb5.t (Wstat: 256 Tests: 1 Failed: 1) > 95-test_external_pyca.t (Wstat: 256 Tests: 1 Failed: 1) > > Clean builds on master should have highest priority. Because if there are too > many red > crosses, nobody cares about them anymore. Note that they are also broken in the 1.1.1-stable branch. At least pyca is something you should be able to fix with a new upstream version. Kurt
Build failures on master?!
The last 19 commits on https://github.com/openssl/openssl/commits/master, starting from Nov 14 have a red cross from the CIs. What's going on again? My personal impression is that builds on master are failing 50% of the time. It is really tedious to check pull requests for build errors just to find that those errors are well known failures from master. In particular, the krb5 an pyca tests are notoriously failing. Are there any plans to fix them or disable them? 95-test_external_krb5.t (Wstat: 256 Tests: 1 Failed: 1) 95-test_external_pyca.t (Wstat: 256 Tests: 1 Failed: 1) Clean builds on master should have highest priority. Because if there are too many red crosses, nobody cares about them anymore. Matthias
