Re: [openssl-project] Issues review

2018-01-23 Thread Matt Caswell


On 23/01/18 20:55, Benjamin Kaduk wrote:
> On Tue, Jan 23, 2018 at 06:11:50PM +, Matt Caswell wrote:
>>
>>
>> On 23/01/18 18:05, Benjamin Kaduk wrote:
>>> On Tue, Jan 23, 2018 at 05:51:41PM +, Matt Caswell wrote:


 On 23/01/18 17:49, Matt Caswell wrote:
> I completed my first pass review of all issues. I still need to look at
> PRs. I have put all PRs against a milestone using the following criteria:

 I have put all *issues* against a milestone not PR!!
>>>
>>> Do we still need to review the issues assigned to milestones that
>>> have already happened (e.g., 1.1.0, post-1.1.0)?
>>
>> There no issues against post-1.1.0 (there are PRs - but that will be
>> fixed when I do the PR review).
>>
>> 1.1.0 and 1.0.2 are still supported so issues against those milestones
>> are still relevant. They are *not* relevant to the 1.1.1 release
>> timetable though (which is why I started this exercise). Consider an
>> issues against the 1.1.0 milestone to mean, relevant to the next 1.1.0
>> letter release.
> 
> That's great if that's the intent, but I don't think that the
> current application of those tags is consistent with the above
> description.  For example, #1418 is a somewhat abstract question of
> what it means for acertificate to be self-signed, yet has the 1.0.2
> milestone, when (to me) 1.2.0 would seem more appropriate.

That *is* the intent. What I've done here is *triage* - spending a few
minutes on each one to assess the correct milestone. It would not
surprise me to learn that, having done that for over 380 issues, we
might have come to a different assessment on a few of them. :-)

To be absolutely sure though I just re-reviewed all of those issues
against the 1.0.2 and 1.1.0 milestones (there weren't that many of
them), to make sure I got them right. I made 2 or 3 changes including to
the issue you highlighted (moving it to the "Post 1.1.1" milestone).
Feel free to make any other adjustments you think might be necessary as
you come across them.

The primary objective here is to inform the debate on the release
criteria for 1.1.1 and the associated timeframes. You will recall that
one of the proposed criteria was:

"- All open github issues/PRs older than 2 weeks at the time of release
to be assessed for relevance to 1.1.1. Any flagged with the 1.1.1
milestone to be closed (see below)

...

Valid reasons for closing an issue/PR with a 1.1.1 milestone might be:
- We have just now or sometime in the past fixed the issue
- Unable to reproduce (following discussion with original reporter if
possible)
- Working as intended
- Deliberate decision not to fix until a later release
- Not enough information and unable to contact reporter
- etc"

We then got into discussions about timeframes - which was difficult
without knowing the scope of the work.

Although there may be some disagreements on a few of the issues. I am
confident that the milestones as they are currently set are broadly
correct - and a good basis for planning.

Matt

___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] Welcome Dr. Matthias St. Pierre

2018-01-23 Thread Richard Levitte
In message  on Tue, 23 Jan 
2018 16:35:02 +, "Salz, Rich"  said:

rsalz> In a little while, Richard should have his SSH keys integrated
rsalz> into our systems, and will email him some more detailed
rsalz> instructions.

Done and done!  Welcome, Matthias

-- 
Richard Levitte levi...@openssl.org
OpenSSL Project http://www.openssl.org/~levitte/
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] Welcome Dr. Matthias St. Pierre

2018-01-23 Thread Paul Dale
Very much deserved.  Congratulations Matthias.


Pauli
-- 
Oracle
Dr Paul Dale | Cryptographer | Network Security & Encryption 
Phone +61 7 3031 7217
Oracle Australia

-Original Message-
From: Dr. Matthias St. Pierre [mailto:matthias.st.pie...@ncp-e.com] 
Sent: Wednesday, 24 January 2018 2:56 AM
To: openssl-project@openssl.org
Subject: Re: [openssl-project] Welcome Dr. Matthias St. Pierre

Thank you everybody! Feels great to be here!

Matthias


On 23.01.2018 17:49, Matt Caswell wrote:
> I invited him to the committers team on github.
>
> Welcome Matthias!
>
> Matt
>
>
> On 23/01/18 16:35, Salz, Rich wrote:
>> Please welcome Matthias as our newest committer.
>>
>>  
>>
>> I have added him to the committers email list, and enabled posting 
>> privileges to the project mailing list.  In a little while, Richard 
>> should have his SSH keys integrated into our systems, and will email 
>> him some more detailed instructions.
>>
>>  
>>
>> Thanks.
>>
>>  
>>
>>
>>
>> ___
>> openssl-project mailing list
>> openssl-project@openssl.org
>> https://mta.openssl.org/mailman/listinfo/openssl-project
>>
> ___
> openssl-project mailing list
> openssl-project@openssl.org
> https://mta.openssl.org/mailman/listinfo/openssl-project

___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project

Re: [openssl-project] Issues review

2018-01-23 Thread Benjamin Kaduk
On Tue, Jan 23, 2018 at 06:11:50PM +, Matt Caswell wrote:
> 
> 
> On 23/01/18 18:05, Benjamin Kaduk wrote:
> > On Tue, Jan 23, 2018 at 05:51:41PM +, Matt Caswell wrote:
> >>
> >>
> >> On 23/01/18 17:49, Matt Caswell wrote:
> >>> I completed my first pass review of all issues. I still need to look at
> >>> PRs. I have put all PRs against a milestone using the following criteria:
> >>
> >> I have put all *issues* against a milestone not PR!!
> > 
> > Do we still need to review the issues assigned to milestones that
> > have already happened (e.g., 1.1.0, post-1.1.0)?
> 
> There no issues against post-1.1.0 (there are PRs - but that will be
> fixed when I do the PR review).
> 
> 1.1.0 and 1.0.2 are still supported so issues against those milestones
> are still relevant. They are *not* relevant to the 1.1.1 release
> timetable though (which is why I started this exercise). Consider an
> issues against the 1.1.0 milestone to mean, relevant to the next 1.1.0
> letter release.

That's great if that's the intent, but I don't think that the
current application of those tags is consistent with the above
description.  For example, #1418 is a somewhat abstract question of
what it means for acertificate to be self-signed, yet has the 1.0.2
milestone, when (to me) 1.2.0 would seem more appropriate.

-Ben
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] Issues review

2018-01-23 Thread Benjamin Kaduk
On Tue, Jan 23, 2018 at 05:51:41PM +, Matt Caswell wrote:
> 
> 
> On 23/01/18 17:49, Matt Caswell wrote:
> > I completed my first pass review of all issues. I still need to look at
> > PRs. I have put all PRs against a milestone using the following criteria:
> 
> I have put all *issues* against a milestone not PR!!

Do we still need to review the issues assigned to milestones that
have already happened (e.g., 1.1.0, post-1.1.0)?

-Ben
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


[openssl-project] Issues review

2018-01-23 Thread Matt Caswell
I completed my first pass review of all issues. I still need to look at
PRs. I have put all PRs against a milestone using the following criteria:

If it only applies to 1.0.2 or below: 1.0.2 milestone
If it only applies to 1.1.0 or below: 1.1.0 milesone
If it's API/ABI breaking to fix: 1.2.0 milestone
If it's a feature request that we aren't already planning to do for
1.1.1: Post 1.1.1 milestone
If it's something which is independent of a release (e.g. web issues,
policy/procedure etc): Other milestone
If it applies to master and doesn't fit into one of the categories
above: 1.1.1 milestone


Some stats:

We now have 249 issues open.
Since I started this exercise we have closed 134 issues.
Issues against 1.0.2: 17
Issues against 1.1.0: 3
Issues against 1.1.1: 141
Issues against 1.2.0: 15
Issues against Post 1.1.1: 58
Issues against Other: 15


Matt
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project